diff options
| author | Luke Granger-Brown <git@lukegb.com> | 2022-09-19T05·25+0000 |
|---|---|---|
| committer | lukegb <lukegb@tvl.fyi> | 2022-09-19T11·04+0000 |
| commit | ae98240df2f9a9d11be85d61697532e17c1ed5f8 (patch) | |
| tree | cfe362e090bfa963bce111631551cff9ee9b5a9c /tvix | |
| parent | f358be4a1d44eb989c8a1eb293b1233cf653911e (diff) | |
feat(gerrit): add code-owners plugin r/4921
This is the New Thing that is intended to replace the find-owners and owners plugins. In particular: * It inserts a submit requirement rather than providing a Prolog predicate. * The default OWNERS file formats are suspiciously Googley. * It provides a neat UI for finding OWNERS and tracking approval state on a per-file basis. When we fully migrate to using the code-owners plugin, a few things will need to land, which I will likely do "offline" directly to the Gerrit backing Git repos: * Add the corresponding Gerrit config * Replace OWNERS files depot-wide * Add OWNERS files to the refs/meta/config branch * Introduce the Owners-Override label, settable by depot-interventions The enclosed patch adds two extra pieces of functionality that we need in tvldepot but aren't upstream: 1. The ability to just specify usernames rather than email addresses 2. The ability to specify `group:GROUPNAME`, _as long as_ that group is visible to everyone. This is a restriction intended to avoid having the plugin just leak group membership. Change-Id: I27d92b6cb7449af83030b9015f09a1571aa8452f Reviewed-on: https://cl.tvl.fyi/c/depot/+/6664 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix')
0 files changed, 0 insertions, 0 deletions