about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-04-13T10·11+0300
committerclbot <clbot@tvl.fyi>2024-04-13T11·45+0000
commit0dd421414e0bf111269329a113753e0bf8591204 (patch)
tree796216efa127411c8aa1bac70559592069577605
parentf6bb8dbe1c3bb238ce9b77f2e69884755bba4dbd (diff)
feat(tvix/nix-compat/wire/bytes): add #[inline] for ensure_* funcs r/7905
While the compiler might realize it's a good idea to inline these,
especially considering this is in the same crate [1], it doesn't hurt to
add that annotation too.

Suggested in cl/11385.

[1]: https://nnethercote.github.io/perf-book/inlining.html

Change-Id: If679fce0e1aab9ec681ba60f689d386d6fd92d61
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11403
Tested-by: BuildkiteCI
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Autosubmit: flokli <flokli@flokli.de>
-rw-r--r--tvix/nix-compat/src/wire/bytes/reader.rs1
-rw-r--r--tvix/nix-compat/src/wire/bytes/writer.rs1
2 files changed, 2 insertions, 0 deletions
diff --git a/tvix/nix-compat/src/wire/bytes/reader.rs b/tvix/nix-compat/src/wire/bytes/reader.rs
index 4c450b55db..c36729c614 100644
--- a/tvix/nix-compat/src/wire/bytes/reader.rs
+++ b/tvix/nix-compat/src/wire/bytes/reader.rs
@@ -60,6 +60,7 @@ where
     }
 }
 /// Returns an error if the passed usize is 0.
+#[inline]
 fn ensure_nonzero_bytes_read(bytes_read: usize) -> Result<usize, std::io::Error> {
     if bytes_read == 0 {
         Err(std::io::Error::new(
diff --git a/tvix/nix-compat/src/wire/bytes/writer.rs b/tvix/nix-compat/src/wire/bytes/writer.rs
index f278b8335f..347934b3dc 100644
--- a/tvix/nix-compat/src/wire/bytes/writer.rs
+++ b/tvix/nix-compat/src/wire/bytes/writer.rs
@@ -56,6 +56,7 @@ where
 }
 
 /// Returns an error if the passed usize is 0.
+#[inline]
 fn ensure_nonzero_bytes_written(bytes_written: usize) -> Result<usize, std::io::Error> {
     if bytes_written == 0 {
         Err(std::io::Error::new(