2 files changed, 17 insertions, 2 deletions
diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs
index 0b1fe540fe..55135c4d8d 100644
--- a/tvix/eval/src/builtins/mod.rs
+++ b/tvix/eval/src/builtins/mod.rs
@@ -103,9 +103,9 @@ fn pure_builtins() -> Vec<Builtin> {
         }),
         Builtin::new("compareVersions", &[true, true], |args, _| {
             let s1 = args[0].to_str()?;
-            let s1 = VersionPartsIter::new(s1.as_str());
+            let s1 = VersionPartsIter::new_for_cmp(s1.as_str());
             let s2 = args[1].to_str()?;
-            let s2 = VersionPartsIter::new(s2.as_str());
+            let s2 = VersionPartsIter::new_for_cmp(s2.as_str());
 
             match s1.cmp(s2) {
                 std::cmp::Ordering::Less => Ok(Value::Integer(-1)),
diff --git a/tvix/eval/src/builtins/versions.rs b/tvix/eval/src/builtins/versions.rs
index ee75eeaeed..e149cc4dba 100644
--- a/tvix/eval/src/builtins/versions.rs
+++ b/tvix/eval/src/builtins/versions.rs
@@ -1,4 +1,5 @@
 use std::cmp::Ordering;
+use std::iter::{once, Chain, Once};
 use std::ops::RangeInclusive;
 
 /// Version strings can be broken up into Parts.
@@ -69,6 +70,20 @@ impl<'a> VersionPartsIter<'a> {
             version,
         }
     }
+
+    /// Create an iterator that yields all version parts followed by an additional
+    /// `VersionPart::Word("")` part (i.e. you can think of this as
+    /// `builtins.splitVersion version ++ [ "" ]`). This is necessary, because
+    /// Nix's `compareVersions` is not entirely lexicographical: If we have two
+    /// equal versions, but one is longer, the longer one is only considered
+    /// greater if the first additional part of the longer version is not `pre`,
+    /// e.g. `2.3 > 2.3pre`. It is otherwise lexicographical, so peculiar behavior
+    /// like `2.3 < 2.3.0pre` ensues. Luckily for us, this means that we can
+    /// lexicographically compare two version strings, _if_ we append an extra
+    /// component to both versions.
+    pub fn new_for_cmp(version: &'a str) -> Chain<Self, Once<VersionPart>> {
+        Self::new(version).chain(once(VersionPart::Word("")))
+    }
 }
 
 impl<'a> Iterator for VersionPartsIter<'a> {