diff options
author | Florian Klink <flokli@flokli.de> | 2024-11-17T23·00+0200 |
---|---|---|
committer | flokli <flokli@flokli.de> | 2024-11-18T22·10+0000 |
commit | a01760fceed240de7787d95e384e83294af1350f (patch) | |
tree | b1650fa8209560cedcbb849a87ec9f1353e3bf0a /tvix/nix-compat/src/nix_daemon | |
parent | 9656686fb3767d2e111132be856bc97e93c01b2c (diff) |
refactor(tvix/tracing): simplify flushing channel r/8942
The TracingHandle::flush function allowed a user to pass in their own (optional) oneshot::Sender<()> to get notified once the flush is completed, but that's making things unnecessary complicated. By simply having the flush() function await the flush, we make its interface more intuitive, and callsites (only inside tvix-tracing itself so far) simpler. We can also remove the Option around the oneshot::Sender entirely, as we now always call it with that. For some more clarity, we can remove the channel from the struct fields entirely if otlp support isn't compiled in. Change-Id: I0870b9e8e88c6be6494a9c201c1c70b87e0f0810 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12801 Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/nix-compat/src/nix_daemon')
0 files changed, 0 insertions, 0 deletions