diff options
author | Vincent Ambo <mail@tazj.in> | 2022-09-11T20·12+0300 |
---|---|---|
committer | tazjin <tazjin@tvl.su> | 2022-09-11T21·13+0000 |
commit | 1844c788f557ff0f80943c127b727498676f04e4 (patch) | |
tree | e554092daf31095454a59acce8b6bfa47ccf596e /tvix/eval/src/warnings.rs | |
parent | 0dc2b19ebeb9e0045328bc48fa369ae9de1a829b (diff) |
refactor(tvix/eval): remove `todo!()` calls in compiler r/4823
It is impossible for tvixbolt to recover from panics, so the user experience of typing an expression using an unsupported feature was that it would get sad and stop responding to input. Instead, raise a normal value-level error of a new variant and continue where possible. Change-Id: Ibe016c92cacb87b85095c0f83758eddc6468053e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6528 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tvix/eval/src/warnings.rs')
-rw-r--r-- | tvix/eval/src/warnings.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs index 3bae2554cff1..b37d0fc91863 100644 --- a/tvix/eval/src/warnings.rs +++ b/tvix/eval/src/warnings.rs @@ -9,7 +9,7 @@ pub enum WarningKind { ShadowedGlobal(&'static str), /// Tvix internal warning for features triggered by users that are - /// not actually implemented yet. + /// not actually implemented yet, but do not cause runtime failures. NotImplemented(&'static str), } |