From 1844c788f557ff0f80943c127b727498676f04e4 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Sun, 11 Sep 2022 23:12:02 +0300 Subject: refactor(tvix/eval): remove `todo!()` calls in compiler It is impossible for tvixbolt to recover from panics, so the user experience of typing an expression using an unsupported feature was that it would get sad and stop responding to input. Instead, raise a normal value-level error of a new variant and continue where possible. Change-Id: Ibe016c92cacb87b85095c0f83758eddc6468053e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6528 Autosubmit: tazjin Tested-by: BuildkiteCI Reviewed-by: sterni --- tvix/eval/src/warnings.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tvix/eval/src/warnings.rs') diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs index 3bae2554cff1..b37d0fc91863 100644 --- a/tvix/eval/src/warnings.rs +++ b/tvix/eval/src/warnings.rs @@ -9,7 +9,7 @@ pub enum WarningKind { ShadowedGlobal(&'static str), /// Tvix internal warning for features triggered by users that are - /// not actually implemented yet. + /// not actually implemented yet, but do not cause runtime failures. NotImplemented(&'static str), } -- cgit 1.4.1