feat(tvix/eval): implement legacy let syntax r/4877

... and emit a warning if anyone decides to use.

Change-Id: Iaa6fe9fa932340e6d0fa9f357155e78823702576
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6611
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>

1 files changed, 6 insertions, 0 deletions

diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs
index 6f4f54160167..ddb7510c8ab7 100644
--- a/tvix/eval/src/warnings.rs
+++ b/tvix/eval/src/warnings.rs
@@ -10,6 +10,7 @@ pub enum WarningKind {
     UselessInherit,
     UnusedBinding,
     ShadowedGlobal(&'static str),
+    DeprecatedLegacyLet,
 
     /// Tvix internal warning for features triggered by users that are
     /// not actually implemented yet, but do not cause runtime failures.
@@ -75,6 +76,10 @@ impl EvalWarning {
                 format!("declared variable '{}' shadows a built-in global!", name)
             }
 
+            WarningKind::DeprecatedLegacyLet => {
+                "legacy `let` syntax used, please rewrite this as `let .. in ...`".to_string()
+            }
+
             WarningKind::NotImplemented(what) => {
                 format!("feature not yet implemented in tvix: {}", what)
             }
@@ -89,6 +94,7 @@ impl EvalWarning {
             WarningKind::UselessInherit => "W002",
             WarningKind::UnusedBinding => "W003",
             WarningKind::ShadowedGlobal(_) => "W004",
+            WarningKind::DeprecatedLegacyLet => "W005",
             WarningKind::NotImplemented(_) => "W999",
         }
     }