From e86acd32122424f5ca2e8ee630d03991b9f9126b Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Fri, 16 Sep 2022 19:48:30 +0300 Subject: feat(tvix/eval): implement legacy let syntax ... and emit a warning if anyone decides to use. Change-Id: Iaa6fe9fa932340e6d0fa9f357155e78823702576 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6611 Tested-by: BuildkiteCI Reviewed-by: sterni --- tvix/eval/src/warnings.rs | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'tvix/eval/src/warnings.rs') diff --git a/tvix/eval/src/warnings.rs b/tvix/eval/src/warnings.rs index 6f4f541601..ddb7510c8a 100644 --- a/tvix/eval/src/warnings.rs +++ b/tvix/eval/src/warnings.rs @@ -10,6 +10,7 @@ pub enum WarningKind { UselessInherit, UnusedBinding, ShadowedGlobal(&'static str), + DeprecatedLegacyLet, /// Tvix internal warning for features triggered by users that are /// not actually implemented yet, but do not cause runtime failures. @@ -75,6 +76,10 @@ impl EvalWarning { format!("declared variable '{}' shadows a built-in global!", name) } + WarningKind::DeprecatedLegacyLet => { + "legacy `let` syntax used, please rewrite this as `let .. in ...`".to_string() + } + WarningKind::NotImplemented(what) => { format!("feature not yet implemented in tvix: {}", what) } @@ -89,6 +94,7 @@ impl EvalWarning { WarningKind::UselessInherit => "W002", WarningKind::UnusedBinding => "W003", WarningKind::ShadowedGlobal(_) => "W004", + WarningKind::DeprecatedLegacyLet => "W005", WarningKind::NotImplemented(_) => "W999", } } -- cgit 1.4.1