refactor(tvix/eval): box PathBuf r/5969

This shaves another 8 bytes off Value. How did that type get so big?!

Change-Id: I65e9b59a1636bd57e3cc4aec5fea16887070b832
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8153
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Tested-by: BuildkiteCI

1 files changed, 6 insertions, 3 deletions

diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs
index 80e1cd27c9..5460514ba1 100644
--- a/tvix/eval/src/compiler/mod.rs
+++ b/tvix/eval/src/compiler/mod.rs
@@ -342,7 +342,10 @@ impl Compiler<'_> {
                 debug_assert!(raw_path.len() > 2 && raw_path.starts_with("~/"));
 
                 let home_relative_path = &raw_path[2..(raw_path.len())];
-                c.emit_constant(Value::UnresolvedPath(home_relative_path.into()), node);
+                c.emit_constant(
+                    Value::UnresolvedPath(Box::new(home_relative_path.into())),
+                    node,
+                );
                 c.push_op(OpCode::OpResolveHomePath, node);
             });
         } else if raw_path.starts_with('<') {
@@ -356,7 +359,7 @@ impl Compiler<'_> {
             let path = &raw_path[1..(raw_path.len() - 1)];
             // Make a thunk to resolve the path (without using `findFile`, at least for now?)
             return self.thunk(slot, node, move |c, _| {
-                c.emit_constant(Value::UnresolvedPath(path.into()), node);
+                c.emit_constant(Value::UnresolvedPath(Box::new(path.into())), node);
                 c.push_op(OpCode::OpFindFile, node);
             });
         } else {
@@ -367,7 +370,7 @@ impl Compiler<'_> {
 
         // TODO: Use https://github.com/rust-lang/rfcs/issues/2208
         // once it is available
-        let value = Value::Path(crate::value::canon_path(path));
+        let value = Value::Path(Box::new(crate::value::canon_path(path)));
         self.emit_constant(value, node);
     }