From 43d04d9b985855cb431024d9895d52ea52fd4180 Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Mon, 27 Feb 2023 13:50:16 +0300 Subject: refactor(tvix/eval): box PathBuf This shaves another 8 bytes off Value. How did that type get so big?! Change-Id: I65e9b59a1636bd57e3cc4aec5fea16887070b832 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8153 Reviewed-by: raitobezarius Tested-by: BuildkiteCI --- tvix/eval/src/compiler/mod.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'tvix/eval/src/compiler/mod.rs') diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs index 80e1cd27c9..5460514ba1 100644 --- a/tvix/eval/src/compiler/mod.rs +++ b/tvix/eval/src/compiler/mod.rs @@ -342,7 +342,10 @@ impl Compiler<'_> { debug_assert!(raw_path.len() > 2 && raw_path.starts_with("~/")); let home_relative_path = &raw_path[2..(raw_path.len())]; - c.emit_constant(Value::UnresolvedPath(home_relative_path.into()), node); + c.emit_constant( + Value::UnresolvedPath(Box::new(home_relative_path.into())), + node, + ); c.push_op(OpCode::OpResolveHomePath, node); }); } else if raw_path.starts_with('<') { @@ -356,7 +359,7 @@ impl Compiler<'_> { let path = &raw_path[1..(raw_path.len() - 1)]; // Make a thunk to resolve the path (without using `findFile`, at least for now?) return self.thunk(slot, node, move |c, _| { - c.emit_constant(Value::UnresolvedPath(path.into()), node); + c.emit_constant(Value::UnresolvedPath(Box::new(path.into())), node); c.push_op(OpCode::OpFindFile, node); }); } else { @@ -367,7 +370,7 @@ impl Compiler<'_> { // TODO: Use https://github.com/rust-lang/rfcs/issues/2208 // once it is available - let value = Value::Path(crate::value::canon_path(path)); + let value = Value::Path(Box::new(crate::value::canon_path(path))); self.emit_constant(value, node); } -- cgit 1.4.1