refactor(tvix/eval): use Clap for arg+env parsing r/4911

Refactor the environment variable and argument parsing for the tvix repl
to use Clap instead of doing things ad-hoc, and thread through options
obtained from environment variables via explicit arguments rather than
obtaining them from the environment as they're needed. This makes adding
more flags more sustainable, and also makes the binary fully
self-documenting, including supported env vars, via `--help`.

Change-Id: Ib1f6a0cd20056e8c9196760ff755fa5729667760
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6653
Autosubmit: grfn <grfn@gws.fyi>
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>

1 files changed, 11 insertions, 3 deletions

diff --git a/tvix/eval/benches/eval.rs b/tvix/eval/benches/eval.rs
index 9be381e0f8..3e4da75936 100644
--- a/tvix/eval/benches/eval.rs
+++ b/tvix/eval/benches/eval.rs
@@ -3,12 +3,20 @@ use itertools::Itertools;
 use tvix_eval::interpret;
 
 fn eval_literals(c: &mut Criterion) {
-    c.bench_function("int", |b| b.iter(|| black_box(interpret("42", None))));
+    c.bench_function("int", |b| {
+        b.iter(|| black_box(interpret("42", None, Default::default())))
+    });
 }
 
 fn eval_merge_attrs(c: &mut Criterion) {
     c.bench_function("merge small attrs", |b| {
-        b.iter(|| black_box(interpret("{ a = 1; b = 2; } // { c = 3; }", None)))
+        b.iter(|| {
+            black_box(interpret(
+                "{ a = 1; b = 2; } // { c = 3; }",
+                None,
+                Default::default(),
+            ))
+        })
     });
 
     c.bench_function("merge large attrs with small attrs", |b| {
@@ -17,7 +25,7 @@ fn eval_merge_attrs(c: &mut Criterion) {
             (0..10000).map(|n| format!("a{n} = {n};")).join(" ")
         );
         let expr = format!("{large_attrs} // {{ c = 3; }}");
-        b.iter(move || black_box(interpret(&expr, None)))
+        b.iter(move || black_box(interpret(&expr, None, Default::default())))
     });
 }