diff options
| author | Florian Klink <flokli@flokli.de> | 2023-05-11T12·49+0300 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2023-05-11T14·27+0000 |
| commit | 616fa4476f93e1782e68dc713e9e8cb77a426c7d (patch) | |
| tree | f76a43e95c75d848d079706fbccfd442210ebebc /tvix/Cargo.lock | |
| parent | b22b685f0b2524c088deacbf4e80e7b7c73b5afc (diff) | |
refactor(tvix/store): remove ChunkService r/6133
Whether chunking is involved or not, is an implementation detail of each Blobstore. Consumers of a whole blob shouldn't need to worry about that. It currently is not visible in the gRPC interface either. It shouldn't bleed into everything. Let the BlobService trait provide `open_read` and `open_write` methods, which return handles providing io::Read or io::Write, and leave the details up to the implementation. This means, our custom BlobReader module can go away, and all the chunking bits in there, too. In the future, we might still want to add more chunking-aware syncing, but as a syncing strategy some stores can expose, not as a fundamental protocol component. This currently needs "SyncReadIntoAsyncRead", taken and vendored in from https://github.com/tokio-rs/tokio/pull/5669. It provides a AsyncRead for a sync Read, which is necessary to connect our (sync) BlobReader interface to a GRPC server implementation. As an alternative, we could also make the BlobReader itself async, and let consumers of the trait (EvalIO) deal with the async-ness, but this is less of a change for now. In terms of vendoring, I initially tried to move our tokio crate to these commits, but ended up in version incompatibilities, so let's vendor it in for now. Change-Id: I5969ebbc4c0e1ceece47981be3b9e7cfb3f59ad0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8551 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/Cargo.lock')
| -rw-r--r-- | tvix/Cargo.lock | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/tvix/Cargo.lock b/tvix/Cargo.lock index 007452d53e..e86773cc14 100644 --- a/tvix/Cargo.lock +++ b/tvix/Cargo.lock @@ -693,12 +693,6 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e88a8acf291dafb59c2d96e8f59828f3838bb1a70398823ade51a84de6a6deed" [[package]] -name = "fastcdc" -version = "3.0.3" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "10010f9b2e601acfda445cb35385cf4241fce85c6e1ea702b157c39f79f8787a" - -[[package]] name = "fastrand" version = "1.9.0" source = "registry+https://github.com/rust-lang/crates.io-index" @@ -2704,10 +2698,11 @@ version = "0.1.0" dependencies = [ "anyhow", "blake3", + "bytes", "clap 4.2.7", "count-write", "data-encoding", - "fastcdc", + "futures", "lazy_static", "nix-compat", "prost", |