about summary refs log tree commit diff
path: root/tools
diff options
context:
space:
mode:
authorVincent Ambo <mail@tazj.in>2020-07-16T00·33+0100
committertazjin <mail@tazj.in>2020-07-16T00·37+0000
commit1bd08e73cd053c526f60b49c6ba2f03b11271e1b (patch)
tree33089ebed2e98bf044045b066c7261225ece5366 /tools
parenteff165425a1a225ac22427ec94b25da9ef6d6e04 (diff)
fix(tools/perf-flamegraph): Get rid of most 'unknown's r/1310
This makes two main changes:

1) It disables profiling of things that aren't part of the invoked
   process (-a). This isn't particularly useful in most cases because
   it will show things like Chrome's VP9 decoding while you're
   profiling something else.

2) It tells perf about the debug symbol format, which for some reason
   isn't DWARF2 by default.

Change-Id: Ida6a54b74f1ec635fec930db7e2a2aa039dd1443
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1185
Reviewed-by: glittershark <grfn@gws.fyi>
Tested-by: BuildkiteCI
Diffstat (limited to 'tools')
-rw-r--r--tools/perf-flamegraph.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf-flamegraph.nix b/tools/perf-flamegraph.nix
index fe5c9a1d59..b472b746ff 100644
--- a/tools/perf-flamegraph.nix
+++ b/tools/perf-flamegraph.nix
@@ -5,7 +5,7 @@
 pkgs.writeShellScriptBin "perf-flamegraph" ''
   set -euo pipefail
 
-  ${pkgs.linuxPackages.perf}/bin/perf record -g -a -F max "$@"
+  ${pkgs.linuxPackages.perf}/bin/perf record -g --call-graph dwarf -F max "$@"
   ${pkgs.linuxPackages.perf}/bin/perf script \
     | ${pkgs.flamegraph}/bin/stackcollapse-perf.pl \
     | ${pkgs.flamegraph}/bin/flamegraph.pl