about summary refs log tree commit diff
path: root/tools
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2025-02-11T16·50+0100
committerclbot <clbot@tvl.fyi>2025-02-11T17·51+0000
commit7549b24863fde23d10da575c5b2461dd62271ed7 (patch)
tree4dcf43fa0c1696dc5ae7f12fb6e121d5e2713e3a /tools
parent87e4ad075309631d47d8702e612c8c6b25442cca (diff)
refactor(tools/emacs-pkgs/tvl): drop lexical-let* HEAD r/9210 canon
As I understand it, the file/buffer local lexical-binding variable
should be enough to have lexical let*:
https://www.gnu.org/software/emacs/manual/html_node/elisp/Using-Lexical-Binding.html

Change-Id: I744d9f47abce8bfa0a5d30fe69ba15fc4e697cac
Reviewed-on: https://cl.tvl.fyi/c/depot/+/13131
Tested-by: BuildkiteCI
Reviewed-by: aspen <root@gws.fyi>
Autosubmit: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'tools')
-rw-r--r--tools/emacs-pkgs/tvl/tvl.el21
1 files changed, 10 insertions, 11 deletions
diff --git a/tools/emacs-pkgs/tvl/tvl.el b/tools/emacs-pkgs/tvl/tvl.el
index 8db718a8359d..358a9770c582 100644
--- a/tools/emacs-pkgs/tvl/tvl.el
+++ b/tools/emacs-pkgs/tvl/tvl.el
@@ -1,11 +1,11 @@
 ;;; tvl.el --- description -*- lexical-binding: t; -*-
 ;;
 ;; Copyright (C) 2020 Griffin Smith
-;; Copyright (C) 2020 The TVL Contributors
+;; Copyright (C) 2020-2023, 2025 The TVL Contributors
 ;;
 ;; Author: Griffin Smith <grfn@gws.fyi>
 ;; Version: 0.0.1
-;; Package-Requires: (cl s magit)
+;; Package-Requires: (s magit)
 ;;
 ;; This file is not part of GNU Emacs.
 ;;
@@ -17,7 +17,6 @@
 
 (require 'magit)
 (require 's)
-(require 'cl) ; TODO(tazjin): replace lexical-let* with non-deprecated alternative
 
 (defgroup tvl nil
   "Customisation options for TVL functionality.")
@@ -213,14 +212,14 @@ passes. This is potentially dangerous, use with care."
 
      (interactive (list (read-string "Attribute: ")
                         (yes-or-no-p "Only include dependencies? ")))
-     (lexical-let* ((outbuf (get-buffer-create (format "*depot-out/%s*" attribute)))
-                    (errbuf (get-buffer-create (format "*depot-errors/%s*" attribute)))
-                    (attr-display (if only-deps attribute (format "dependencies of %s" attribute)))
-                    (expression (if only-deps
-                                    (format "let d = import <depot> {}; in d.nix.buildLisp.sbcl.lispWith d.%s.lispDeps"
-                                            attribute)
-                                    (format "(import <depot> {}).%s.repl" attribute)))
-                    (command (list "nix-build" "--no-out-link" "-I" (format "depot=%s" tvl-depot-path) "-E" expression)))
+     (let* ((outbuf (get-buffer-create (format "*depot-out/%s*" attribute)))
+            (errbuf (get-buffer-create (format "*depot-errors/%s*" attribute)))
+            (attr-display (if only-deps attribute (format "dependencies of %s" attribute)))
+            (expression (if only-deps
+                            (format "let d = import <depot> {}; in d.nix.buildLisp.sbcl.lispWith d.%s.lispDeps"
+                                    attribute)
+                          (format "(import <depot> {}).%s.repl" attribute)))
+            (command (list "nix-build" "--no-out-link" "-I" (format "depot=%s" tvl-depot-path) "-E" expression)))
        (message "Acquiring Lisp for <depot>.%s" attr-display)
        (make-process :name (format "depot-nix-build/%s" attribute)
                      :buffer outbuf