diff options
| author | Vincent Ambo <mail@tazj.in> | 2020-07-15T00·09+0100 |
|---|---|---|
| committer | tazjin <mail@tazj.in> | 2020-07-15T00·16+0000 |
| commit | 1390827b9ea1e04bc9863e48930bfd16db3b716e (patch) | |
| tree | baa57a82bd905ae6282a01d241923f0e5211227c /third_party/nix/tests/lang.sh | |
| parent | 104bf184618e8afbee9ba1998ce6dee7e8663146 (diff) | |
refactor(3p/nix): Revert VectorBindings implementation r/1298
This reverts parts of the CLs splitting the backing implementation for Bindings and moves back to only the BTreeMap-backed implementation. Our evaluation has indicated that the Vector-backed implementation does not match the performance of the plain array used upstream, and in my view the complexity introduced by it is not worth the relatively small (single-digit percentage) performance increase with a pivot-point close to the number of attributes yielded by stdenv.mkDerivation. Going forward we will trial implementations of attribute sets backed by HAMTs, and investigate other mechanisms of speeding up the language. Some changes from the previous CLs are retained, for example the removal of insert_or_assign and the passing of capacity. Change-Id: I6eb4b075b453949583360755055c21a29d7ff642 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1172 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
Diffstat (limited to '')
| -rw-r--r-- | third_party/nix/tests/lang.sh | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/third_party/nix/tests/lang.sh b/third_party/nix/tests/lang.sh index c797a2a74e..151a713166 100644 --- a/third_party/nix/tests/lang.sh +++ b/third_party/nix/tests/lang.sh @@ -1,5 +1,3 @@ -source common.sh - export TEST_VAR=foo # for eval-okay-getenv.nix nix-instantiate --eval -E 'builtins.trace "Hello" 123' 2>&1 | grep -q Hello |