From 1390827b9ea1e04bc9863e48930bfd16db3b716e Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Wed, 15 Jul 2020 01:09:18 +0100 Subject: refactor(3p/nix): Revert VectorBindings implementation This reverts parts of the CLs splitting the backing implementation for Bindings and moves back to only the BTreeMap-backed implementation. Our evaluation has indicated that the Vector-backed implementation does not match the performance of the plain array used upstream, and in my view the complexity introduced by it is not worth the relatively small (single-digit percentage) performance increase with a pivot-point close to the number of attributes yielded by stdenv.mkDerivation. Going forward we will trial implementations of attribute sets backed by HAMTs, and investigate other mechanisms of speeding up the language. Some changes from the previous CLs are retained, for example the removal of insert_or_assign and the passing of capacity. Change-Id: I6eb4b075b453949583360755055c21a29d7ff642 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1172 Reviewed-by: glittershark Tested-by: BuildkiteCI --- third_party/nix/tests/lang.sh | 2 -- 1 file changed, 2 deletions(-) (limited to 'third_party/nix/tests/lang.sh') diff --git a/third_party/nix/tests/lang.sh b/third_party/nix/tests/lang.sh index c797a2a74ed8..151a71316683 100644 --- a/third_party/nix/tests/lang.sh +++ b/third_party/nix/tests/lang.sh @@ -1,5 +1,3 @@ -source common.sh - export TEST_VAR=foo # for eval-okay-getenv.nix nix-instantiate --eval -E 'builtins.trace "Hello" 123' 2>&1 | grep -q Hello -- cgit 1.4.1