diff options
author | Florian Klink <flokli@flokli.de> | 2024-09-19T08·27+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-09-19T12·51+0000 |
commit | 21e5fc024d3ad275112c5bc88476ee38966d9fe1 (patch) | |
tree | 94d1e12524ba5d9497f2904934850890a4087443 /third_party/nix/src/tests/lang | |
parent | 1f5a20736af58045a8e009d12c3b809e87afefcd (diff) |
fix(tvix/castore/import): check small blobs first r/8704
ConcurrentBlobUploader buffers small blobs in memory, and then uploads them to the BlobService in the background. In these cases, we know the hash of the whole blob, so we could check if it exists first before, uploading it. We were however not, and this caused rate limiting issues in GCS, as it has an update limit of one write per second on the same key, which we ran into especially frequently with the empty blob. This reduces the amount of writes of the same blob considerably. In the future, we might be able to drop this, as our chunked blob uploading protocol gets smarter and covers these cases. Change-Id: Icf482df815812f80a0b65cec0426f8e686308abb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12497 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Connor Brewster <cbrewster@hey.com>
Diffstat (limited to 'third_party/nix/src/tests/lang')
0 files changed, 0 insertions, 0 deletions