about summary refs log tree commit diff
path: root/third_party
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2024-12-02T22·54+0100
committerclbot <clbot@tvl.fyi>2024-12-02T23·15+0000
commit962df219f76014816404e2ee4c82db01c899877b (patch)
tree4313ac0175a56e77a6d3c05bf59c9846908464da /third_party
parent604296bb7c2743be60e66e8390498580b2402997 (diff)
chore(3p/lisp/closure-*): disable on ECL for now HEAD r/8980 canon
As it turns out, some of the load/compile time set up the package does
doesn't work in ECL for unknown reasons at the moment. Executables using
closure-* will crash after starting up:

    ;;; Checking for wide character support... WARNING: Lisp implementation doesn't use UTF-16, but accepts surrogate code points.
     yes, using code points.
    ;;; Building Closure with CHARACTER RUNES

    Condition of type: SIMPLE-ERROR
    Invalid relative pathname #P"package.lisp" for component ("closure-common" "package")

Change-Id: I4b4bf96835a39696884ec6fea9c249fdeb53c853
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12863
Reviewed-by: sterni <sternenseemann@systemli.org>
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Diffstat (limited to 'third_party')
-rw-r--r--third_party/lisp/closure-common.nix5
-rw-r--r--third_party/lisp/closure-html/default.nix6
2 files changed, 10 insertions, 1 deletions
diff --git a/third_party/lisp/closure-common.nix b/third_party/lisp/closure-common.nix
index 7f7f79f8551b..164e75233989 100644
--- a/third_party/lisp/closure-common.nix
+++ b/third_party/lisp/closure-common.nix
@@ -33,4 +33,9 @@ depot.nix.buildLisp.library {
     depot.third_party.lisp.trivial-gray-streams
     depot.third_party.lisp.babel #+rune-is-character
   ];
+
+  brokenOn = [
+    # TODO(sterni): fails when loading because it tries to access package.lisp at runtime
+    "ecl"
+  ];
 }
diff --git a/third_party/lisp/closure-html/default.nix b/third_party/lisp/closure-html/default.nix
index 1886ea2ec9a2..5e9eacdcb63e 100644
--- a/third_party/lisp/closure-html/default.nix
+++ b/third_party/lisp/closure-html/default.nix
@@ -9,7 +9,7 @@ let
       # delete unexported and unused double defun in sgml-dtd.lisp
       # which reference undefined CL-USER:*HTML-DTD* (!) which
       # unlike CLOSURE-HTML:*HTML-DTD* is not involved in the
-      # packages operation.
+      # package's operation.
       ./no-double-defun.patch
       # Patches html-parser.lisp to look for the distributed
       # dtd files and catalog in this source derivations out
@@ -62,4 +62,8 @@ depot.nix.buildLisp.library {
     depot.third_party.lisp.flexi-streams
     depot.third_party.lisp.closure-common
   ];
+
+  brokenOn = [
+    "ecl" # see closure-common
+  ];
 }