about summary refs log tree commit diff
diff options
context:
space:
mode:
authorGriffin Smith <grfn@gws.fyi>2020-07-06T15·10-0400
committerglittershark <grfn@gws.fyi>2020-07-06T17·44+0000
commita0f9ae996d33a82b3cf057f92d5560f7f730a44d (patch)
tree34c962002850544a5aef73fe477e05c172059d33
parent9e622eceae688b08eb5d29e0da4f1b7b8d9a75fa (diff)
refactor(tvl.el): Don't submit on rubberstamp r/1225
Now that we're requiring CI to verify all changes (yay) it's not
actually possible to push and submit in one go - this repurposes the
rubberstamp command to push and self-+2, which is still useful for
self-owned things like system config etc.

Change-Id: Ie064adb6b7b0c1fd6bffdf4583a201ea02d4f8ac
Reviewed-on: https://cl.tvl.fyi/c/depot/+/939
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
-rw-r--r--tools/emacs-pkgs/tvl/tvl.el4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/emacs-pkgs/tvl/tvl.el b/tools/emacs-pkgs/tvl/tvl.el
index 987ddcfe93..a5630184f2 100644
--- a/tools/emacs-pkgs/tvl/tvl.el
+++ b/tools/emacs-pkgs/tvl/tvl.el
@@ -75,12 +75,12 @@ rubberstamp operation is dangerous and should only be used in
   (interactive)
   (magit-push-refspecs tvl-gerrit-remote
                        (tvl--gerrit-ref "canon"
-                                        '("Code-Review+2" "publish-comments" "submit"))
+                                        '("Code-Review+2" "publish-comments"))
                        nil))
 
 (transient-append-suffix
   #'magit-push ["r"]
-  (list "P" "push, rubberstamp & submit to Gerrit" #'magit-gerrit-rubberstamp))
+  (list "P" "push & rubberstamp to Gerrit" #'magit-gerrit-rubberstamp))
 
 (defun tvl-depot-status ()
   "Open the TVL monorepo in magit."