From a0f9ae996d33a82b3cf057f92d5560f7f730a44d Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Mon, 6 Jul 2020 11:10:40 -0400 Subject: refactor(tvl.el): Don't submit on rubberstamp Now that we're requiring CI to verify all changes (yay) it's not actually possible to push and submit in one go - this repurposes the rubberstamp command to push and self-+2, which is still useful for self-owned things like system config etc. Change-Id: Ie064adb6b7b0c1fd6bffdf4583a201ea02d4f8ac Reviewed-on: https://cl.tvl.fyi/c/depot/+/939 Tested-by: BuildkiteCI Reviewed-by: tazjin --- tools/emacs-pkgs/tvl/tvl.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/emacs-pkgs/tvl/tvl.el b/tools/emacs-pkgs/tvl/tvl.el index 987ddcfe93..a5630184f2 100644 --- a/tools/emacs-pkgs/tvl/tvl.el +++ b/tools/emacs-pkgs/tvl/tvl.el @@ -75,12 +75,12 @@ rubberstamp operation is dangerous and should only be used in (interactive) (magit-push-refspecs tvl-gerrit-remote (tvl--gerrit-ref "canon" - '("Code-Review+2" "publish-comments" "submit")) + '("Code-Review+2" "publish-comments")) nil)) (transient-append-suffix #'magit-push ["r"] - (list "P" "push, rubberstamp & submit to Gerrit" #'magit-gerrit-rubberstamp)) + (list "P" "push & rubberstamp to Gerrit" #'magit-gerrit-rubberstamp)) (defun tvl-depot-status () "Open the TVL monorepo in magit." -- cgit 1.4.1