about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-01-16T14·56+0100
committerclbot <clbot@tvl.fyi>2023-01-16T16·45+0000
commitf6b4abac358c176cf5f686fed4f2e597e6b73704 (patch)
tree182a8e7583bcc656c4167286fd8cd87899fb6b8a
parent67addf3b3d5533f0b8f37d5d981c31e4313cf317 (diff)
chore(tvix/derivation): drop TODOs related to stripping outputs r/5666
Different to the go-nix implementation, we don't have a custom "writing
mode" where output paths are omitted from output, but we simply run the
serialization with these fields unpopulated (during construction).

This means, there's no need for a custom writing mode that strips
outputs, so we can drop the comments.

Change-Id: Ic0aafd4e34e0294603490cfce2b1aef4085ff34b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7845
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Autosubmit: flokli <flokli@flokli.de>
-rw-r--r--tvix/derivation/src/write.rs2
1 files changed, 0 insertions, 2 deletions
diff --git a/tvix/derivation/src/write.rs b/tvix/derivation/src/write.rs
index 8e9cdfcccaf6..af8f50d9b104 100644
--- a/tvix/derivation/src/write.rs
+++ b/tvix/derivation/src/write.rs
@@ -56,7 +56,6 @@ pub fn write_outputs(
             writer.write_char(COMMA)?;
         }
 
-        // TODO(jrhahn) option to strip output
         let mut elements: Vec<&str> = vec![output_name, &output.path];
 
         match &output.hash {
@@ -170,7 +169,6 @@ pub fn write_enviroment(
             writer.write_char(COMMA)?;
         }
 
-        // TODO(jrhahn) add strip option
         write_array_elements(
             writer,
             false,