From f6b4abac358c176cf5f686fed4f2e597e6b73704 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Mon, 16 Jan 2023 15:56:47 +0100 Subject: chore(tvix/derivation): drop TODOs related to stripping outputs Different to the go-nix implementation, we don't have a custom "writing mode" where output paths are omitted from output, but we simply run the serialization with these fields unpopulated (during construction). This means, there's no need for a custom writing mode that strips outputs, so we can drop the comments. Change-Id: Ic0aafd4e34e0294603490cfce2b1aef4085ff34b Reviewed-on: https://cl.tvl.fyi/c/depot/+/7845 Tested-by: BuildkiteCI Reviewed-by: tazjin Autosubmit: flokli --- tvix/derivation/src/write.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/tvix/derivation/src/write.rs b/tvix/derivation/src/write.rs index 8e9cdfcccaf6..af8f50d9b104 100644 --- a/tvix/derivation/src/write.rs +++ b/tvix/derivation/src/write.rs @@ -56,7 +56,6 @@ pub fn write_outputs( writer.write_char(COMMA)?; } - // TODO(jrhahn) option to strip output let mut elements: Vec<&str> = vec![output_name, &output.path]; match &output.hash { @@ -170,7 +169,6 @@ pub fn write_enviroment( writer.write_char(COMMA)?; } - // TODO(jrhahn) add strip option write_array_elements( writer, false, -- cgit 1.4.1