diff options
| author | Griffin Smith <grfn@gws.fyi> | 2022-04-14T14·12-0400 |
|---|---|---|
| committer | grfn <grfn@gws.fyi> | 2022-04-14T14·26+0000 |
| commit | 47d075924e19e2b474e64765a1cbe38221509df7 (patch) | |
| tree | 17a6b77d7e98e108a74aebbbd3ccb8589aba3178 | |
| parent | 3c294fbabd6622b8cd60984d7ed0dd811e8885eb (diff) | |
fix(web/panettone): Dont double up on borders r/3946
Don't render the <ol class="issue-history"> when we have nothing to put in it, which is the case when there's no issue history and the user is not logged in. This avoids an awkward-looking double bottom border on issues with no comments for unauthenticated users. Change-Id: I1c6aac40e4ba93e9428a0da589c67582b1589c17 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5445 Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
| -rw-r--r-- | web/panettone/src/panettone.lisp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp index 3de7fe25baad..bef5b018e465 100644 --- a/web/panettone/src/panettone.lisp +++ b/web/panettone/src/panettone.lisp @@ -391,13 +391,14 @@ #'local-time:timestamp< :key #'created-at))) (markdownify-comment-bodies comments) - (who:htm - (:ol - :class "issue-history" - (dolist (item history) - (render/issue-history-item item)) - (when *user* - (render/new-comment (id issue)))))))))) + (when (or history *user*) + (who:htm + (:ol + :class "issue-history" + (dolist (item history) + (render/issue-history-item item)) + (when *user* + (render/new-comment (id issue))))))))))) (defun render/not-found (entity-type) (render () |