From 47d075924e19e2b474e64765a1cbe38221509df7 Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Thu, 14 Apr 2022 10:12:26 -0400 Subject: fix(web/panettone): Dont double up on borders Don't render the
    when we have nothing to put in it, which is the case when there's no issue history and the user is not logged in. This avoids an awkward-looking double bottom border on issues with no comments for unauthenticated users. Change-Id: I1c6aac40e4ba93e9428a0da589c67582b1589c17 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5445 Autosubmit: grfn Tested-by: BuildkiteCI Reviewed-by: tazjin --- web/panettone/src/panettone.lisp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp index 3de7fe25baad..bef5b018e465 100644 --- a/web/panettone/src/panettone.lisp +++ b/web/panettone/src/panettone.lisp @@ -391,13 +391,14 @@ #'local-time:timestamp< :key #'created-at))) (markdownify-comment-bodies comments) - (who:htm - (:ol - :class "issue-history" - (dolist (item history) - (render/issue-history-item item)) - (when *user* - (render/new-comment (id issue)))))))))) + (when (or history *user*) + (who:htm + (:ol + :class "issue-history" + (dolist (item history) + (render/issue-history-item item)) + (when *user* + (render/new-comment (id issue))))))))))) (defun render/not-found (entity-type) (render () -- cgit 1.4.1