diff options
| author | Vincent Ambo <mail@tazj.in> | 2020-06-29T17·54+0100 |
|---|---|---|
| committer | tazjin <mail@tazj.in> | 2020-06-29T19·06+0000 |
| commit | d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f (patch) | |
| tree | 9ebac84a0391d1f968bfb844155d6e68c800598f | |
| parent | 40d079240578dd19f1552f6cf610e10396cc8569 (diff) | |
feat(besadii): Temporarily add Code-Review labels on CLs r/1129
Besadii already adds 'Verified'-labels, which are used to signal CI status on CLs, however we don't actually use these labels (yet) which also means that they are not displayed in the Gerrit UI. This change temporarily introduces the Code-Review label *in addition* (with the same values as Verified), providing a build status signal on the CL but without being required for submission. Change-Id: I2c3a37c59aceb426815ad4e400c80ab85be482dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/781 Tested-by: BuildkiteCI Reviewed-by: ericvolp12 <ericvolp12@gmail.com> Reviewed-by: lukegb <lukegb@tvl.fyi>
| -rw-r--r-- | ops/besadii/main.go2 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/ops/besadii/main.go2 b/ops/besadii/main.go2 index 3479a5a74d86..250e65ead834 100644 --- a/ops/besadii/main.go2 +++ b/ops/besadii/main.go2 @@ -267,6 +267,13 @@ func postCommandMain() { OmitDuplicateComments: true, Labels: map[string]int{ "Verified": verified, + // TODO(tazjin): The Code-Review label is only used here + // temporarily, as our build rules do not check for 'Verified' + // right now (because CI doesn't run 24/7). + // + // Having a Code-Review label lets us signal the build status on + // the review, but without having to always require it. + "Code-Review": verified, }, } |