From d3f9cb0ec398d25a3be01cbc7c9b1ee8716b877f Mon Sep 17 00:00:00 2001 From: Vincent Ambo Date: Mon, 29 Jun 2020 18:54:29 +0100 Subject: feat(besadii): Temporarily add Code-Review labels on CLs Besadii already adds 'Verified'-labels, which are used to signal CI status on CLs, however we don't actually use these labels (yet) which also means that they are not displayed in the Gerrit UI. This change temporarily introduces the Code-Review label *in addition* (with the same values as Verified), providing a build status signal on the CL but without being required for submission. Change-Id: I2c3a37c59aceb426815ad4e400c80ab85be482dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/781 Tested-by: BuildkiteCI Reviewed-by: ericvolp12 Reviewed-by: lukegb --- ops/besadii/main.go2 | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ops/besadii/main.go2 b/ops/besadii/main.go2 index 3479a5a74d..250e65ead8 100644 --- a/ops/besadii/main.go2 +++ b/ops/besadii/main.go2 @@ -267,6 +267,13 @@ func postCommandMain() { OmitDuplicateComments: true, Labels: map[string]int{ "Verified": verified, + // TODO(tazjin): The Code-Review label is only used here + // temporarily, as our build rules do not check for 'Verified' + // right now (because CI doesn't run 24/7). + // + // Having a Code-Review label lets us signal the build status on + // the review, but without having to always require it. + "Code-Review": verified, }, } -- cgit 1.4.1