1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
"""Linting"""
load(
"@io_tweag_rules_haskell//haskell:providers.bzl",
"HaskellInfo",
"HaskellLibraryInfo",
"HaskellLintInfo",
)
load(":private/context.bzl", "haskell_context", "render_env")
load(":private/packages.bzl", "expose_packages", "pkg_info_to_compile_flags")
load(
":private/path_utils.bzl",
"target_unique_name",
)
load(":providers.bzl", "get_libs_for_ghc_linker")
load(":private/set.bzl", "set")
def _collect_lint_logs(deps):
lint_logs = set.empty()
for dep in deps:
if HaskellLintInfo in dep:
set.mutable_union(lint_logs, dep[HaskellLintInfo].outputs)
return lint_logs
def _haskell_lint_rule_impl(ctx):
return [DefaultInfo(
files = set.to_depset(_collect_lint_logs(ctx.attr.deps)),
)]
def _haskell_lint_aspect_impl(target, ctx):
hs = haskell_context(ctx, ctx.rule.attr)
if HaskellInfo not in target:
return []
hs_info = target[HaskellInfo]
lib_info = target[HaskellLibraryInfo] if HaskellLibraryInfo in target else None
args = ctx.actions.args()
args.add_all([
"-O0",
"-v0",
"-fno-code",
"-Wall",
"-Werror",
"-Wcompat",
"-Wincomplete-record-updates",
"-Wincomplete-uni-patterns",
"-Wredundant-constraints",
"-Wnoncanonical-monad-instances",
"--make",
])
args.add_all(pkg_info_to_compile_flags(expose_packages(
hs_info,
lib_info,
use_direct = False,
use_my_pkg_id = None,
custom_package_databases = None,
version = ctx.rule.attr.version,
)))
sources = set.to_list(hs_info.source_files)
args.add_all(sources)
lint_log = ctx.actions.declare_file(
target_unique_name(hs, "lint-log"),
)
# Transitive library dependencies for runtime.
(library_deps, ld_library_deps, _ghc_env) = get_libs_for_ghc_linker(
hs,
hs_info.transitive_cc_dependencies,
)
ctx.actions.run_shell(
inputs = depset(transitive = [
depset(sources),
set.to_depset(hs_info.package_databases),
set.to_depset(hs_info.interface_dirs),
set.to_depset(hs_info.dynamic_libraries),
depset(library_deps),
depset(ld_library_deps),
depset([hs.tools.ghc]),
]),
outputs = [lint_log],
mnemonic = "HaskellLint",
progress_message = "HaskellLint {}".format(ctx.label),
command = """
{env}
{ghc} "$@" > {output} 2>&1 || rc=$? && cat {output} && exit $rc
""".format(
ghc = hs.tools.ghc.path,
output = lint_log.path,
# XXX Workaround
# https://github.com/bazelbuild/bazel/issues/5980.
env = render_env(hs.env),
),
arguments = [args],
use_default_shell_env = True,
)
lint_info = HaskellLintInfo(outputs = set.singleton(lint_log))
output_files = OutputGroupInfo(default = [lint_log])
return [lint_info, output_files]
haskell_lint_aspect = aspect(
_haskell_lint_aspect_impl,
attr_aspects = ["deps"],
toolchains = ["@io_tweag_rules_haskell//haskell:toolchain"],
)
haskell_lint = rule(
_haskell_lint_rule_impl,
attrs = {
"deps": attr.label_list(
aspects = [haskell_lint_aspect],
doc = "List of Haskell targets to lint.",
),
},
toolchains = ["@io_tweag_rules_haskell//haskell:toolchain"],
)
"""Check source code of targets in `deps` using a restrictive set of GHC
flags.
The following flags will be used:
* `-Wall`
* `-Werror`
* `-Wcompat`
* `-Wincomplete-record-updates`
* `-Wincomplete-uni-patterns`
* `-Wredundant-constraints`
"""
|
