| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2020-05-19 | r/778 refactor(3p/nix): Make all single-argument constructors explicit | Vincent Ambo | 12 | -31/+31 | |
| Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors | |||||
| 2020-05-19 | r/777 style(3p/nix): Final act in the brace-wrapping saga | Vincent Ambo | 84 | -1556/+2603 | |
| This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon. | |||||
| 2020-05-19 | r/776 chore(3p/nix): Remove OSX only 'resolve-system-dependencies' tool | Vincent Ambo | 4 | -268/+0 | |
| 2020-05-19 | r/775 style(3p/nix/libstore): Additional if/for bracing fixes | Vincent Ambo | 1 | -7/+11 | |
| 2020-05-19 | r/774 chore(3p/abseil-cpp): Bump version to 20200519-768eb2ca | Vincent Ambo | 1 | -3/+3 | |
| 2020-05-19 | r/773 fix(3p/nix/libstore): Fix mistake introduced by bracing changes | Vincent Ambo | 1 | -1/+1 | |
| This statement got included in a loop when it shouldn't have been. At least it led to some funny derivation files! | |||||
| 2020-05-19 | r/772 style(3p/nix): Add braces around single-line for-loops | Vincent Ambo | 45 | -142/+426 | |
| These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for (\(.+\))\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber | |||||
| 2020-05-19 | r/771 style(3p/nix): Add braces around single-line conditionals | Vincent Ambo | 97 | -753/+2223 | |
| These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if (\(.+\))\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber | |||||
| 2020-05-19 | r/770 fix(3p/nix/libexpr): Declare value union types explicitly | Vincent Ambo | 1 | -43/+59 | |
| Previously these structs were declared anonymously inside of the - anonymous - union. This is not actually supported by the C++ standard, but is merely a compiler-specific extension. Unfortunately untangling this required a forward-declaration of the Value type. | |||||
| 2020-05-19 | r/769 fix(3p/nix/libexpr): Use noexcept instead of throw() | Vincent Ambo | 1 | -1/+1 | |
| 2020-05-19 | r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops | Vincent Ambo | 16 | -61/+62 | |
| Fixes mistakes introduced by clang-tidy in the previous commit. | |||||
| 2020-05-19 | r/767 style(3p/nix): Enforce braces around loops and conditionals | Vincent Ambo | 44 | -298/+661 | |
| This change was generated with: fd -e cc -e hh | xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy. | |||||
| 2020-05-19 | r/766 style(3p/nix): Reformat all includes to match new style | Vincent Ambo | 119 | -106/+298 | |
| 2020-05-19 | r/765 style(3p/nix): Change include formatting config for clang-format | Vincent Ambo | 1 | -2/+7 | |
| Changes the configuration to regroup all includes. The include groups will be (in this order): 1. (in .cc): Include of the corresponding header 2. Includes of C++ standard library headers 3. Includes of other external headers 4. Includes of local headers | |||||
| 2020-05-19 | r/764 feat(tools/emacs): Configure eglot to shut down automatically | Vincent Ambo | 1 | -0/+6 | |
| When all buffers related to a specific eglot instance are gone, eglot can shut down. | |||||
| 2020-05-19 | r/763 fix(3p/nix): Set C++ style to "Google" in Emacs locals | Vincent Ambo | 2 | -42/+1 | |
| 2020-05-19 | r/762 refactor(3p/nix/nix-*): Replace logging with glog in binaries | Vincent Ambo | 21 | -168/+120 | |
| 2020-05-19 | r/761 refactor(3p/nix/nix-daemon): Remove activities from protocol | Vincent Ambo | 2 | -112/+27 | |
| Removes the activity transfer that was previously nulled out from the daemon protocol completely. This might actually break Nix completely, I haven't tried yet, but that's fine because this will be replaced with gRPC. | |||||
| 2020-05-19 | r/760 style(3p/nix/libexpr): Reformat with clang-format | Vincent Ambo | 5 | -6/+7 | |
| 2020-05-19 | r/759 chore(3p/nix/nix): Remove progress bar implementation | Vincent Ambo | 2 | -455/+0 | |
| The progress bar has lots of complexity for little benefit. The previous activity tracking stuff has been deleted as part of the logging refactoring and I am not going to implement support for this again for now. | |||||
| 2020-05-19 | r/758 refactor(3p/nix/libexpr): Replace logging.h with glog | Vincent Ambo | 8 | -35/+37 | |
| 2020-05-19 | r/757 refactor(3p/nix/libmain): Replace logging.h with glog | Vincent Ambo | 4 | -98/+58 | |
| 2020-05-19 | r/756 refactor(3p/nix/libstore): Replace logging.h with glog | Vincent Ambo | 25 | -464/+514 | |
| 2020-05-18 | r/755 feat(3p/glog): Update glog version | Vincent Ambo | 2 | -2/+16 | |
| 2020-05-18 | r/754 refactor(3p/nix/libutil): Replace internal logging library with glog | Vincent Ambo | 10 | -44/+76 | |
| 2020-05-18 | r/753 chore(3p/nix/libutil): Remove logging implementation | Vincent Ambo | 3 | -437/+0 | |
| 2020-05-17 | r/752 feat(ci-builds): Build //third_party/nix in CI | Vincent Ambo | 1 | -0/+1 | |
| 2020-05-17 | r/751 feat(tools/emacs): Install meson-mode | Vincent Ambo | 1 | -0/+1 | |
| 2020-05-17 | r/750 | ||||
 |
depot | |
| monorepo for the virus lounge | The Virus Lounge |
| about summary refs log tree commit diff |