about summary refs log tree commit diff
path: root/users
AgeCommit message (Collapse)AuthorFilesLines
11 days r/8898 refactor(nix-compat): Move serialization machinery into wire.Vova Kryachko1-1/+1
This groups most `wire` feature gated logic into a single module. The nix_daemon module will be gated by a feature that adds nix-compat-derive as a dependency. All of this is a way to break the crate2nix dependency cycle between nix-compat and nix-compat-derive(which depends on nix-compat for its doctests). Change-Id: I95938a6f280c11967371ff21f8b5a19e6d3d3805 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12761 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
11 days r/8897 fix(users/flokli/2024-10-25-nixcon-tvix): fix dateFlorian Klink1-1/+1
Change-Id: Icd81415c208c26ae606673f3476bfdf0525eec89 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12759 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-06 r/8894 fix(users/flokli/kb/dilemma): fix one more RALTFlorian Klink1-1/+1
This makes it quite hard to press Alt+Number otherwise. Change-Id: Id1cc4fbfa1575cc213014106f734bec035d46f2c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12737 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
2024-11-02 r/8880 fix(tvix/nix_compat): Fix nix-daemon handshakeVova Kryachko1-3/+3
Existing handshake behavior assumed that the server version is always at least as new as the client. Meaning that the client's version was always picked the handshake details as well as for further communication This change removes that assumption and correctly uses min(server_version, client_version). Change-Id: Ia5dad4613dd5f69a0aeb6c9d86982f1f36fe1a4c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12722 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-27 r/8872 feat(tazjin/nixos): enable automatic-gc on all physical machinesVincent Ambo2-9/+9
Change-Id: I115c29da5d7038a5e6e917928a16a2b8c6eb084e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12692 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-10-27 r/8865 feat(users/flokli/kb/corneish_zen): initFlorian Klink4-0/+146
This builds the keyboard firmware using zmk-nix. The miryoku_zmk config is pulled in from manna-harbour/miryoku_zmk, but slightly patched to add support for RALT and quick-tap. Change-Id: I91efbbd789526cce7f086f367c7bccb7857b06e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12695 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de>
2024-10-27 r/8864 fix(tazjin/emacs): fix completion related problemsVincent Ambo2-8/+15
A while ago I decided to experiment with corfu and orderless instead of company/prescient. This was prompted by issues which I had in EXWM, where some sort of UI race with company elements could lock up a whole frame. Now that I'm not on EXWM anymore this doesn't really matter, so I can bring back company and set up prescient again correctly, fixing a whole bunch of issues along the way: * Completion issues where not all matching candidates where shown based on cursor position (I honestly have no idea what caused this and what was going on there, never figured it out, but enabling prescient properly fixes it). * Code completion works again. Corfu, as I understand it, is technically better/cleaner/whatever than company - but it doesn't work anywhere, especially not in telega.el where I need completion more than anywhere else. With this commit my Emacs behaves a lot better again. Change-Id: I8f082de8211dd3be3bb7a0663d43d414cc320e49 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12690 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2024-10-27 r/8860 chore(3p/sources): bump channels & overlays (2024-10-23)Vincent Ambo5-7/+5
* ops/modules: remove deprecated headscale DNS setting * users/aspen: use stable julia again (upstream ticket is resolved, and 16 has been removed because it's long deprecated) * users/wpcarro: utillinux -> util-linux * 3p/overlays: temporarily restore utillinux until upstream breakage is fixed * users/tazjin: noto-cjk -> noto-cjk-sans * tvix: regenerate Go protobufs Change-Id: I9dbec812306cd4e66030d14bbea3805e8224e0d5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12679 Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: aspen <root@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-26 r/8859 feat(users/flokli/slides/2023-asg): add pdfFlorian Klink1-0/+4
Change-Id: I85b1f2a9bb99df01546f3d0d3f60d9953f1d8d61 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12684 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8858 fix(users/flokli/slides/2023-nixcon): fix pdf genFlorian Klink1-4/+4
reveal-md didn't exit with a nonzero exit code and just didn't contain the PDF. Fix this. Change-Id: Ie4bc7cbf4b9117b0a672a3294e9e64fb13459247 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12683 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8857 fix(users/flokli/nixon-2024): fix pdf genFlorian Klink1-4/+4
Change-Id: I02c101fc16e4ce57d53cd423f7aa0b6a98f856df Reviewed-on: https://cl.tvl.fyi/c/depot/+/12685 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de>
2024-10-26 r/8856 feat(users/flokli/nixon-2024): initFlorian Klink11-0/+297
Change-Id: I547a5504f6782169dd7280c0b5c21cbe66068a2e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12682 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de>
2024-10-23 r/8852 chore(3p/sources): bump channels & overlays (2024-10-12)Vincent Ambo1-4/+0
* amend keycloak configuration as per upgrade guide for their latest, most innovative breaking changes. https://www.keycloak.org/docs/latest/upgrading/index.html#deprecated-proxy-option * users/aspen: remove deprecated noXlibs option. This option has no alternative. Change-Id: I49f45e38cda6b01ddf6f014b7b1c43972b76629f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12601 Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2024-10-22 r/8851 fix(tazjin/dotfiles): make trackball left-handedVincent Ambo1-0/+4
... because it's on the left side! Change-Id: I1d67d797bd6137705e69b96349faa32a9c3e94ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/12678 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-10-20 r/8849 feat(users/edef/weave): use tracing_indicatif for progressedef6-115/+1072
Progress bars :3 Change-Id: I770d0f8381521b6efc8b38c0db4d59c771887fee Reviewed-on: https://cl.tvl.fyi/c/depot/+/12673 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8847 feat(users/edef): add .gitignore fileFlorian Klink1-0/+3
Change-Id: Ia91100f342be2b5ad6ab83bbb3844f2526ea3036 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12672 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-19 r/8846 feat(users/edef/weave): use FxHashSet and dedupe earlyedef4-4/+33
Deduping early saves a fair bit of memory, but the extra hashing is costly. We switch to FxHash, since we don't need a DoS-proof hash, but we do need it to be *fast*. Change-Id: Ic6b7010874c417862baa9b882593208c8dd1d5e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12648 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8845 feat(users/edef/weave): ingest roots in Parquet formatedef1-13/+15
Parsing of store-paths.xz is now handled by //users/edef/fetchroots. Change-Id: I78be5aada0c0a321ed79d80c9b615e5f997ac3e0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12670 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8844 refactor(users/edef/weave/swizzle): use polars streamingedef5-112/+70
This vastly reduces the memory requirements, so we can run in ~40G RAM. Change-Id: I4952a780df294bd852a8b4682ba2fd59b9bae675 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12667 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8843 refactor(users/edef/weave): simplify OwningRef handlingedef2-32/+12
We switch to working with the underlying Arc<Bytes<u8>> type, since Buffer<u8> is already essentially an OwningRef-esque subslice. Because we're now working with an exposed Arc directly, we don't need to have our own `unsafe impl StableAddress` any more. Change-Id: I9ce2edc6899177145e15b72aa5380f708a62173c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12668 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-19 r/8842 refactor(users/edef/weave): use swap rather than CASedef1-3/+5
We only care about ordering on the same variable, and we rely on the release barrier provided by rayon's thread joining. The comparison failing is always an error path, and we're indifferent about which thread it fails on. Change-Id: I592a7eaae5b6935cf424c6576a49786f39909fb6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12666 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-19 r/8841 refactor(users/edef/weave): simplify DoubleEndedIterator boundedef1-1/+1
Thanks, Clippy! Change-Id: I116b478124b72e070e94150ee850532752f64d60 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12669 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-10-17 r/8829 chore(users/edef/crunch-v2): bump crate dependenciesFlorian Klink2-25/+25
Fixes rustls 0.20.9: RUSTSEC-2024-0336 (CVE-2024-32650, GHSA-6g7w-8wpp-frhj) Change-Id: I1be307876465f47c28af05c4b515bf6a7b6713ef Reviewed-on: https://cl.tvl.fyi/c/depot/+/12654 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-10-17 r/8828 fix(users/edef/weave): use safer_owning_refedef4-33/+35
owning_ref has serious unsoundness. Change-Id: Ie760697cd6399e6bc75f1ad17c9bb74adc077a35 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12656 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Autosubmit: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8827 chore(users/edef/turbofetch): bump crate dependenciesFlorian Klink2-20/+20
Fixes rustls 0.20.9: RUSTSEC-2024-0336 (CVE-2024-32650, GHSA-6g7w-8wpp-frhj) Change-Id: Id38f867a85320e3a3ca870dbf224c4fd4c5abacb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12655 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
2024-10-17 r/8819 fix(minecraft-fabric): avoid unset CREDENTIALS_DIRECTORY in ExecStopsterni1-3/+8
For mystifying reasons, Type=simple and CREDENTIALS_DIRECTORY in ExecStop have stopped working (when exactly I don't know, but presumably 256). Apparently, you are supposed to use Type=exec with credentials due to raciness (I've personally never experienced): <https://github.com/systemd/systemd/issues/32583>. Just changing the type did not resolve the issue of CREDENTIALS_DIRECTORY being unset, though. It appears, though, that the issue is merely an unset environment variable and not the credentials being unavailable: We can work around the problem by setting an appropriate environment variable ourselves. Change-Id: Ifcdb1f3bce782ea1c568a9bc413f3fb29f0985c5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12649 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2024-10-17 r/8818 docs(users/edef/fetchroots): add a README for other userszimbatm1-0/+36
Change-Id: Ibce9121fbd209e713ce04271e285f70e2af9867e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12646 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8817 chore(users/edef/fetchroots): wire up the buildzimbatm4-4/+12634
Change-Id: I6830b885394001882b54fddf310bbd38d253679a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12645 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-10-17 r/8816 feat(users/edef/fetchroots): initedef3-0/+3620
Change-Id: I6861661bcd99652a1875ccde421e78e87c45054c Reviewed-on: https://cl.tvl.fyi/c/depot/+/11094 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-12 r/8801 chore(tvix/tools): move narinfo2parquet to //users/edefVincent Ambo6-0/+11617
This is not a core Tvix tool, it's a tool that uses a Tvix component. Change-Id: I81d2b2374da23489df0097dcabb8295c82652fc1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12606 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-10-12 r/8800 chore(tvix/tools): move weave to //users/edefVincent Ambo9-0/+11508
This is not a core Tvix tool, it's a tool that uses a Tvix component. Change-Id: I705f2c4ab87f1512e005007c933e16b84ed4279f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12605 Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2024-10-12 r/8799 chore(tvix/tools): move turbofetch to //users/edefVincent Ambo9-0/+9375
This was introduced in cl/9925 without any commit message, but this is clearly not relevant to Tvix itself (it even says so in a comment in Cargo.toml). Change-Id: I84f12d5145c3f53c9df23863f887bad913856c50 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12604 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: edef <edef@edef.eu>
2024-10-12 r/8798 chore(tvix/tools): move crunch-v2 to //users/edefVincent Ambo12-0/+15454
This is not a core Tvix tool, it's some sort of one-off analysis thing. Change-Id: I05fcbed45abad27d6b5cfd49db1727249dad3971 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12603 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2024-10-12 r/8795 chore(users/picnoir/tvix-daemon): bump crate dependenciesFlorian Klink2-1260/+671
Change-Id: I437126bba36b61b8f266915e0fe0ecc229a5bc5b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12600 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-10-06 r/8781 feat(tazjin/nixos): persist yggdrasil keys for tverskoyVincent Ambo3-11/+5
Change-Id: If2513b009a82a07b90eb06a5dc4db0859aa6c78d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12584 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-10-05 r/8780 chore(users/Profpatsch/sync-abfall): parkProfpatsch4-0/+0
Change-Id: I9284417cb88f0eb2a0525db789069ca6507a500f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12583 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8779 chore(users/Profpatsch/reverse-haskell-deps): parkProfpatsch4-0/+0
Change-Id: I3940764f8aba806f97d62b0e1cf8d200aa6346ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/12582 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8778 fix(users/Profpatsch): remove parked projects from CIProfpatsch2-0/+0
Change-Id: Idf10af114c236f33ed40052fa05f85d1683d78b6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12581 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8777 chore(users/Profpatsch): park mailbox-orgProfpatsch7-5/+0
I should probably remove the default.nix files in these as well so they don’t get built on CI. Change-Id: I09764f2ee198ab4016a1649f1675f7c45d207b09 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12580 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8776 chore(users/Profpatsch): remove iniProfpatsch2-42/+0
Change-Id: I289e133ef64766d4b1a199a26d2eea9db52918a0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12579 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8775 chore(users/Profpatsch/.gitignore): ignore all js lockfilesProfpatsch1-0/+4
Change-Id: Ieeb79ce72e72ffe12ee26576f644e64a5cad456e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12578 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8774 chore(users/Profpatsch/my-prelude): vendor pa-jsonProfpatsch8-4/+535
Want to be able to make changes with low overhead, and having it in a separate library is just annoying. Change-Id: I30b76885d8e0e6ebaefe9506cf36672783ed4988 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12577 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8773 fix(users/Profpatsch/lyric/ext): print upload message to logProfpatsch1-0/+2
Change-Id: I178077894eb78c9f9cb5da07c1be23b7dba6c7cb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12576 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8772 fix(users/Profpatsch/lyric/ext): set user agent in all fetchesProfpatsch1-4/+7
Change-Id: I8de1ef76c4d5789536e528f49226e58ee90b8749 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12575 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8771 chore(users/Profpatsch): remove AoC stuffProfpatsch4-269/+0
Change-Id: Ifb134053c0f92dfdb4f2c0a3418c0c6a7a1a8507 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12574 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8770 feat(users/Profpatsch): move eslint & prettier to toplevelProfpatsch8-156/+120
the linters & prettier config should apply to my whole subdir. This is somewhat nasty, you have to `npm` in the toplevel dir before it starts working, otoh dev tooling is dev time and I’m working on these alone. Change-Id: I96721f549b24a40b7ffbb2d310f37a40d2590b2b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12573 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2024-10-05 r/8769 feat(users/Profpatsch/lyric): add tapping & improve silence warningProfpatsch2-18/+67
Add a tapping command that does not quantize the timestamps. For the silence warning, we make it BPM-dependent (defaulting to 120BPM as everywhere else), meaning for slower songs we give a higher possible time difference before we display a warning. Change-Id: Idefc44166639b23c2105a1a810ac22ed84457225 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12563 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8768 fix(users/Profpatsch/lyric): create new lyric file if not existsProfpatsch1-15/+15
That was the original intention, but I didn’t understand that lua would fail with "r+" if the file does not exist (and "w+" truncates the file, so you have to try "r+" and then fall back to "w+" which will create the file as well.) Change-Id: Ib238f0b73ab403ceeaf035d053a14eba718d1b48 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12562 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8767 feat(users/Profpatsch/lyric/ext): add lrc upload & ms offsetProfpatsch3-6/+405
This adds support for uploading the lyrics part of an .lrc file to lrclib, see https://lrclib.net/docs I pretty much only used ChatGPT to translate the rust “proof of work” challenge to nodejs and it worked first try lol. Before uploading the lyrics, I construct a webview with a preview of what is going to be uploaded, and then only upload when that is accepted. Pretty sweet. Also adds two commands for increasing/decreasing the current timestamp by 100ms and starting playback from 2 seconds before that, very handy for fine-tuning lines. Change-Id: Ia6adfe26d0c21c62554c8f8c55e97e2caec95d1e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12561 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2024-10-05 r/8766 chore(users/Profpatsch/lyric): add typescript linting rulesProfpatsch6-89/+140
Change-Id: I9ab0336450519648f7a8edeec94bd64b78e2f05b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12554 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>