about summary refs log tree commit diff
path: root/users
AgeCommit message (Collapse)AuthorFilesLines
2021-04-01 r/2385 feat(sterni/nix/url): implement urldecodingsterni2-0/+46
We use builtins.split directly as it should be a bit more efficient as lib.splitStrings. Also its returning of a list for every regex match is useful to update the state while parsing the tokens: * The tokens are obtained by splitting the string at every '%' * Everytime we see a boundary (that is a list in the returned list of builtins.split), we know that the first two chars of the next string are a percent encoded character. One implementation flaw is that it will currently crash if it encounters mal-formed URLs (since int.fromHex chrashes if it encounters any non hex digit characters) and accepts some malformed urlencoding like "foo %A". Change-Id: I90d08d7a71b16b4f4a4879214abd7aeff46c20c8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2744 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-01 r/2382 feat(users/Profpatsch/netencode): fully streaming parserProfpatsch1-39/+95
In order to arbitrarily split netencode over multiple reads, we need to make the parser completely streaming, so that it recognizes all cases where it needs more input. Luckily, this is fairly trivial, after working around a bunch of overeager parsing. The tricky part was the giant `alt`, where inner parsers would start consuming input and thus become incomplete when they fail afterwards. Sinc the format *always* starts the different types with one discriminator char, we can use that to instantly return the parser and try the next one instead. The other tricky part was that lists and records would parse all inner elements and then choke on the empty string after the last element, because the inner parser would consume at least the descriminator, and an empty string is always `Incomplete`. We wrap these into a small combinator which plays nice with `many0` in that regard. Change-Id: Ib8d15d9a7cab19d432c6b24a35fcad6a5a72b246 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2704 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: sterni <sternenseemann@systemli.org>
2021-03-30 r/2366 feat(gs/emacs): Add terraform configGriffin Smith3-0/+36
Change-Id: I9266ed310024a2a9437ea983dfdf27b8a395c924 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2707 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-30 r/2365 chore(tverskoy): Disable networking.firewallVincent Ambo1-0/+1
I'm only connected to my own tethering nets anyways and I can't be bothered to figure out all the things I need to open for Chromecasts, maybe later. Change-Id: Id1715b205191d4494a5a7001e1fb0f41a89d3de6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2705 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-29 r/2364 fix(gws.fyi): Make CSS mobile-friendlyGriffin Smith1-1/+12
Don't apply the left-margin if the viewport is too narrow too handle it Change-Id: Ia15641a6f0c94f9b0582f4a48af00b935f3e66bc Reviewed-on: https://cl.tvl.fyi/c/depot/+/2703 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2363 feat(gs/mugwump): Add blackbox prometheus exportersGriffin Smith1-0/+40
Add blackbox prometheus exporters to Mugwump with config for scraping gws.fyi, windtunnel.ci, and app.windtunnel.ci Change-Id: Ied9e329d44b506763b600e4978f65a5a3abcf5df Reviewed-on: https://cl.tvl.fyi/c/depot/+/2702 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2362 feat(gs/home): Install prettierGriffin Smith1-1/+2
Change-Id: I0a416ef919859b7516861de7fb575616f5479d26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2701 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2361 feat(gws.fyi): Make website build easier to testGriffin Smith2-2/+5
Expose website as a top-level attribute, and ignore index.html, both to make test-deving the site easier Change-Id: Ic056446e322ec5f69583d316998103883fc8d55b Reviewed-on: https://cl.tvl.fyi/c/depot/+/2700 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2360 fix(gws.fyi): Explicitly specify personal profile to AWSGriffin Smith2-2/+3
Explicitly pass --profile personal to AWS commands, to avoid deploying this to the wrong aws account on accident Change-Id: Iff8236967adcfdedfbace8930031db9adf60e3d1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2699 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2359 feat(gws.fyi): Link to some of my projectsGriffin Smith1-3/+18
Also start to put things under headings, since we have CSS to make that look decent now Change-Id: I9ad8c5f5bf32360bcae48fb28e390391fcec0a88 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2698 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2358 feat(gws.fyi): Add some very light CSSGriffin Smith3-1/+131
web-brutalism is so 3 years ago, bro but seriously, I'd like to start putting some actual stuff here, so let's make it look halfway-decent. Change-Id: Ic78d725b3755c2307c7ea155af8d0f90e287830c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2697 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-29 r/2357 refactor(gs/home): Move rebuild-mugwump script to all machinesGriffin Smith2-10/+10
Chupacabra doesn't even exist anymore, plus I want this installed on all home systems Change-Id: Id0e5c89797b1ad52b2a24d60ad3ab5e125f60266 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2696 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-28 r/2356 feat(achilles): Implement a Unit typeGriffin Smith16-88/+447
Add support for a zero-sized Unit type. This requires some special at the codegen level because LLVM (unsurprisingly) only allows Void types in function return position - to make that a little easier to handle there's a new pass that strips any unit-only expressions and pulls unit-only function arguments up to new `let` bindings, so we never have to actually pass around unit values. Change-Id: I0fc18a516821f2d69172c42a6a5d246b23471e38 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2695 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-28 r/2353 chore(tverskoy): Add some more missing programs and persisted pathsVincent Ambo1-0/+5
Change-Id: I3fbdbdc177471429d80ed50b4424e5f0b96e6272 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2694 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-26 r/2347 feat(ops/nixos/whitby): add flokli userFlorian Klink1-0/+7
Change-Id: Ibdb5b498f8bbc837fffdb38cdf95499b279773aa Reviewed-on: https://cl.tvl.fyi/c/depot/+/2683 Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2021-03-26 r/2346 chore(flokli): init user folderFlorian Klink1-0/+3
Change-Id: Id19eafb3f2cc7dfa1ec8c47cbe9c5766ac491516 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2682 Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2021-03-26 r/2344 feat(gs/home): Update discord to 0.0.14Griffin Smith1-2/+2
Change-Id: I115ffcf22f7a3bdbc2641d4a9f7858fd0e049248 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2681 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-26 r/2340 feat(tverskoy): Enable moshVincent Ambo1-0/+1
Change-Id: I18fa98aa6ba5892729ab130336f6a5d597865bf4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2667 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-26 r/2339 fix(gs/home): Set dunst max icon size to 45Griffin Smith1-0/+1
Notifications with images appear to be working now, which is cool, but they're also *really* large, especially for spotify album art - let's pull that down a bit. Change-Id: I825798cccb54ebafd3facc08f3d6f0f4a42cf010 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2666 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-26 r/2338 feat(gs/yeren): Install digimend device driversGriffin Smith1-1/+4
Change-Id: Ib8d589bd2110eb23d26a789a9f069f80815dadf3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2665 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-26 r/2337 feat(gs/yeren): Enable tailscaleGriffin Smith1-0/+2
Change-Id: Ibe48761b3161b1dfa6989dd25ec25593b7fe98ec Reviewed-on: https://cl.tvl.fyi/c/depot/+/2664 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-26 r/2335 fix(users/Profpatsch/writers): use s6-portable-utilsProfpatsch1-6/+7
We had a bunch of instances of https://github.com/NixOS/nix/issues/2176, where nix would exit with a “killed by signal 9” error. According to Eelco in that issue, this is perfectly normal behaviour of course, and appears if the last command in a loop closes `stdout` or `stdin`, then the builder will SIGKILL it immediately. This is of course also a perfectly fine error message for that case. It turns out that mainly GNU coreutils exhibit this behaviour … Let’s see if using a more sane tool suite fixes that. Change-Id: If34ab692120e5e299575bf8044aa5802145ab494 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2658 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-03-26 r/2334 fix(users/Profpatsch/writers): fail on rust test failureProfpatsch1-1/+1
`forstdin` iterates over the tests in the test directory, and by default it does *not* fail if an inner loop returns an error, unless `-o okcodes` is given, a list of exit codes that indicate success. Now it fails if a loop returns ≠ 0. Change-Id: I0b1b2a06cd0a894e5ac4e77ec25019629ce2c077 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2657 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-03-26 r/2333 chore(3p): use haskell-language-server from nixpkgssterni2-3/+2
Upstream haskellPackages has a newer haskell-language-server than we had and it is always in sync with the default GHC version of that package set which we incidentally use to build all haskell derivations in depot. I hope this will not cause us more trouble in the future, but I've gotten the impression that maralorn makes an effort to prevent haskell-language-server from being broken in haskellPackages, so ideally we'll never have to worry about hls again. If we do have to, we may need to switch to easy-hls-nix. Note that I haven't had the time yet to verify that the shells actually work since it's kinda late now and the rebuilds are many. Change-Id: I74c192d57355904cfa45bb76d70346792ba05af5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2662 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2021-03-26 r/2331 chore(users/gs/owothia): remove unnecessary overrides, simplifysterni4-39/+18
* chatter and its dependencies have been fixed in upstream haskellPackages, so we can get rid of the packageSet.nix expression: https://github.com/NixOS/nixpkgs/pull/116803 * Merged default.nix and pkg.nix into one expression and use callCabal2nix instead of emulating it with nested imports. * Minor refactor of shell.nix and remove haskell-language-server until we've redone it or replaced it with the upstream one as now the GHC versions are out of sync: hls is built with 8.8.4, but haskellPackages uses 8.10.4 Change-Id: Ie75eaa93ba8bd79e749e2442fb28c855b8a15a1d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2661 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2021-03-26 r/2330 chore(3p): bump NixOS channels to 2021-03-25sterni2-2/+2
OpenSSL released an update which fixes two severity high security issues: * https://mta.openssl.org/pipermail/openssl-announce/2021-March/000197.html * https://mta.openssl.org/pipermail/openssl-announce/2021-March/000198.html Update to the nixpkgs (currently still master) commits updating OpenSSL. Other changes: * Use GHC 8.8.4 for haskell-language-server as GHC 8.8.3 got removed from nixpkgs last friday. Change-Id: Ic1b2f49284e78193a4330da4bb4b718a797f5ab1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2653 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: glittershark <grfn@gws.fyi>
2021-03-25 r/2329 refactor: Replace some uses of builtins.toFile with pkgs.writeTextVincent Ambo1-5/+5
I'm looking at removing some of these because they can cause unnecessary build steps during CI pipeline generation. Change-Id: I84742968918090c050d2eedab8a1b42692632a42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2655 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2021-03-23 r/2324 chore(tazjin/tverskoy): Set git.init.defaultBranch = "canon"Vincent Ambo1-0/+1
Change-Id: Ic03668c152e6d306a47ccc222d2c98901e12dfda Reviewed-on: https://cl.tvl.fyi/c/depot/+/2648 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-23 r/2322 feat(tazjin/emacs): Configurable screen lock & brightness adjustmentVincent Ambo1-10/+15
Change-Id: I749ce827c7d53ecf8dec66c1f62481e6ef44791d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2645 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-23 r/2321 feat(tazjin/tverskoy): Enable automatic screen lockingVincent Ambo1-0/+19
Defines a small helper script that resets the keyboard layout (to avoid getting stuck in Russian layout) and locks the screen via xsecurelock, and configures home-manager to launch this automatically. Fascinatingly this actually seems to be capable of locking the screen *on suspend*, not *after suspend*. Change-Id: Ib6279a445aba18c2fb5bc073b675e6e2598fa228 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2644 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-23 r/2320 fix(tazjin/tverskoy): Forcefully set nix.nixPathVincent Ambo1-0/+6
The out-of-sync channel was previously causing OpenGL applications in nix-shells to fail. Change-Id: Ie527ef70b49468dfb62091abfa878ba1b361fc6d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2643 Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2021-03-22 r/2319 feat(users/Profpatsch): add imap-idleProfpatsch3-0/+235
A small UCSPI client which connects to an IMAP server, authenticates with username and password (for Christ’s sake, put it in `s6-tlsclient`), selects the `INBOX` and proceeds to listen for new mails. Later it will generate an event on stdout and to be used for push messaging and triggering a full `mbsync` run on new message. Currently I’m testing it via ``` env CAFILE=/run/current-system/etc/ssl/certs/ca-bundle.crt \ IMAP_USERNAME=<username> \ backtick -i IMAP_PASSWORD ' pass' ' <password-entry>' '' \ s6-tlsclient -v <imap-server> 993 ./result ``` Change-Id: I221717d374c0efc8d9e05fe0dfccba31798b3c5c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2636 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-03-22 r/2317 chore(tazjin/tverskoy): Install dnsutils and moshVincent Ambo1-0/+2
Change-Id: I3d3a7543dbd09f68890d9daa6ac38c9afa49d35d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2639 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2315 chore(tazjin/keys): Add tverskoy, comment out frogVincent Ambo1-4/+4
frog is in storage and the key shouldn't have privileges while I'm guaranteed to not use it. Change-Id: If2ee8278fcb81f425dcfc151b11d207dfb6f45c7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2631 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2313 fix(tazjin/tverskoy): Persist Mullvad settings & rustup downloadsVincent Ambo1-2/+4
Change-Id: I6ce75bff1d2e6ed318af9edc878cc59604b7a597 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2635 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-21 r/2312 fix(tazjin/tverskoy): Ensure 'pactl' command is availableVincent Ambo1-0/+1
This is required for my volume modification keyboard shortcuts. Change-Id: I95e02be5b08e1f8a14746ace61226e903fbc68a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2634 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-21 r/2311 fix(tazjin/tverskoy): Persist ~/.config/mimeapps.listVincent Ambo1-0/+1
Change-Id: Ifd14d4eb0bdfaee6713219f46bac4257d3d72f51 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2633 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-03-21 r/2310 chore(tazjin/emacs): Use `light` instead of `xbacklight`Vincent Ambo1-2/+2
The latter doesn't work with AMD devices. This will need some changes on one of my non-NixOS machines, unfortunately ... Change-Id: Ib9dfdb9beac67501396a06ea74a0a4371f8ad65e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2628 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2309 fix(tazjin/tverskoy): Configure git to always rebaseVincent Ambo1-0/+3
Change-Id: I2682e350c74a830682ebca12102d00b7e85093f8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2627 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2308 fix(tazjin/tverskoy): Add myself to the 'video' groupVincent Ambo1-1/+1
This group has access to modifying backlight settings (configured by the udev rules for `light`). Change-Id: I1593980757c6265f6822d3d3dce9e19a2473acd8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2626 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2307 chore(tazjin/tverskoy): Enable SSH agent, Spotify, mullvad, ...Vincent Ambo1-0/+6
Just a few more missing things. Change-Id: I54b633296d91c6f8dce72d900d7d38b8af4ae419 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2625 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2306 feat(tazjin/tverskoy): Enable redshift & geoclue2Vincent Ambo1-3/+4
... also nuke that Bluetooth headset daemon, it doesn't work anyways. Change-Id: Iee884046a2bf2718767442ec62b2f731e14e39e8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2624 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2305 feat(tazjin/tverskoy): Configure ephemeral home bind-mountsVincent Ambo1-1/+44
Uses the impermanence module to configure the bind-mounts for the few applications that are allowed to persist stuff between boots. For now this setup uses ZFS rollbacks to get /home back into a clean state, where the `tazjin-clean` snapshot is a partition with only the `/home/tazjin` folder and the correct partitions on it. This gives me enough scratch space to e.g. download stuff larger than my RAM without accumulating state. Change-Id: I7cdb2276f087ea62201690cb8b36ae074203f87c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2623 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2302 fix(gs/emacs): Drop explicit load of slackGriffin Smith1-2/+0
This is getting loaded by use-package now Change-Id: I591629ed26ffac71a0df04d51c10b9290ebd76ff Reviewed-on: https://cl.tvl.fyi/c/depot/+/2428 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-21 r/2301 fix(tazjin/emacs): Ensure company is installedVincent Ambo1-0/+1
I don't know where this went. Change-Id: I82d27e273e38ffeffe683d6ff2236d383c7b1fcf Reviewed-on: https://cl.tvl.fyi/c/depot/+/2622 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2300 feat(tazjin/tverskoy): Configure impermanence moduleVincent Ambo1-0/+17
This module is responsible for mounting persistent storage into the ephemeral root disk of this machine. Currently only very basic configuration and data are retained, and hopefully that won't change. Change-Id: If800cbee60b7b3c5b8c457b9b332a0c05c33f20e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2621 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2299 feat(tazjin/nixos): Initial check in of new host (tverskoy)Vincent Ambo2-1/+205
This is my new X13 AMD Thinkpad, on which many fun things will be done. Change-Id: I4de114a8c5ebb37d2f4844f407d2dc0e7cc9557e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2620 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2298 fix(tazjin/emacs): Use ace-window from MELPA instead of ELPAVincent Ambo1-1/+1
This package definition is broken for ELPA in nixpkgs, but adisbladis is working on it. Change-Id: Ibe140a2daf7a3a294dae4c6340be33db05a47a44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2619 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-20 r/2296 feat(gs/achilles): Implement very basic monomorphizationGriffin Smith12-19/+430
Implement very basic monomorphization, by recording type variable instantiations when typechecking Call nodes and then using those in a new hir Visitor trait to copy the body of any generic decls for each possible set of instantiation of the type variables. Change-Id: Iab54030973e5d66e2b8bcd074b4cb6c001a90123 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2617 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-03-20 r/2295 fix(gs/achilles): Get rid of universalization stepGriffin Smith2-30/+67
The step of "universalizing" function expressions was conflicting with top-level ascriptions for polymorphic function declarations: universalization generates universal type variables, and top-level polymorphic ascription *also* generates universal type variables, and the two were conflicting with each other when unifying. Let's just get rid of this now, and we can bring it back in a more principled manner once we do actual let-generalization (which there's still an ignored test case for) Change-Id: Idc08c8cb5ac92d1e6e1e63c9b8729176cab73f44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2616 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-09T15·18+0000