about summary refs log tree commit diff
path: root/users
AgeCommit message (Collapse)AuthorFilesLines
2022-09-06 r/4683 feat(wpcarro/emacs): Set initial-buffer-choice per-hostWilliam Carroll4-4/+7
Work machines should prefer `/hadrian` and personal machines should prefer `/depot`. Change-Id: I03b605cc5ce233767146d83f14f368863897cf8b Reviewed-on: https://cl.tvl.fyi/c/depot/+/6368 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-09-01 r/4564 docs(users/Profpatsch/netencode): add docstrings to Netencode.hsProfpatsch1-3/+46
Change-Id: I509ea7949990e8c652133bd9ef21243a41f58e44 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6202 Reviewed-by: Profpatsch <mail@profpatsch.de> Autosubmit: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2022-08-30 r/4532 refactor(sterni/emacs): switch to pure gtk emacssterni1-4/+12
This means it'll no longer run under Xwayland. Requires applying small fix to bqn-mode which stopped compiling with emacs HEAD. Change-Id: I998a303a0b98bcd45c1de430462b1069bef8718e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6203 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-08-30 r/4530 chore(3p/sources): Bump channels & overlayssterni1-1/+2
* //users/Profpatsch/writers: adjust for API change in makePythonWriter: Since it has become cross-aware, we also need to provide the buildPackages python set we want to use. Change-Id: I4a201647281827ad983eb2dda6f6305f1ed824e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6196 Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-29 r/4526 fix(wpcarro/emacs): Support rust.el PATH depsWilliam Carroll1-0/+3
There might be a better way to do this using `direnv`'s `use_nix` and shlevy's `nix-buffer` Elisp package, but I'm doing this for now. Change-Id: I4246c519f39eea1bde3191762b184b37d30fbeed Reviewed-on: https://cl.tvl.fyi/c/depot/+/6049 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-29 r/4525 feat(wpcarro/rust): Define stdin exampleWilliam Carroll2-6/+24
Pipe Rust strings to shell commands. Change-Id: Id8afeed642d30c79e193fa9b353de081a5843eb5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6197 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-26 r/4509 feat(tazjin/emacs): add `find-cargo-project` functionVincent Ambo1-0/+10
This is useful for eglot launching rust-analyzer when I'm outside of a depot project. Change-Id: I1fa1dc11e3eabe4bdedbd6389b55411641391c7e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6176 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-08-25 r/4490 fix: reflect renames of Nix configuration optionssterni3-14/+10
Change-Id: I7e28ac3d71acd7d99a1d3ef97bef9422097e4abf Reviewed-on: https://cl.tvl.fyi/c/depot/+/6154 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-08-22 r/4450 chore(tazjin/tgsa): bump cargo dependenciesVincent Ambo1-98/+195
Change-Id: Id52ab2937e32385324ba93f4df7e1da17a1f4eec Reviewed-on: https://cl.tvl.fyi/c/depot/+/6119 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-08-22 r/4449 chore(3p/sources): Bump channels & overlayssterni3-51/+58
* //users/tazjin/predlozhnik: bump wasm-bindgen & run `cargo update` * //users/Profpatsch/writers: use proper keyword syntax to make make flake8 happy. * //third_party/nixpkgs: pick binaryen from stable channel Change-Id: Ia711d8c396aa09b78413d80f35eedf63fa315596 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6118 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-22 r/4448 feat(users/Profpatsch): init haskell arglib-netencodeProfpatsch3-0/+64
Mirrors the rust exec-helpers Change-Id: I96f211d6545e228b8ae0c1dce4e60e6f6867690c Reviewed-on: https://cl.tvl.fyi/c/depot/+/6117 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-22 r/4447 feat(users/Profpatsch): init haskell exec-helpersProfpatsch3-0/+80
Mirrors the rust exec-helpers Change-Id: I8fba49525949a8f38ca8c215e2ec7ba9d97d3bf9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6116 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-22 r/4446 fix(users/Profpatsch/my-prelude): use exactSourceProfpatsch1-1/+4
Change-Id: I1b797fb69f69e09f2dda99fce2f12adef0ac2ad2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6115 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-22 r/4445 feat(users/Profpatsch): init netencode-hsProfpatsch3-0/+445
Haskell implementation of the netncode parser & generators. Change-Id: I904df752e78641110af2857e71d8206bf432d427 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6114 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2022-08-16 r/4444 chore(sterni/emacs): weed out subscriptionssterni1-26/+2
Change-Id: Ie5f57300c380874a83d1cbd25a61eb595760bbf4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6113 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2022-08-10 r/4397 feat(tazjin/emacs): add helper function for navigating tvix testsVincent Ambo1-0/+11
the upstream Nix test suite uses the pattern of having `.nix` and `.exp` files for input/expected output, and with this shitty function navigating between them is a lot simpler Change-Id: I9d91290057521fe1e1599f69fd6b0f35e1b59960 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6058 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-08-09 r/4396 feat(wpcarro/rust): Include std::fmt::Display exampleWilliam Carroll6-50/+123
Gotta know how to `to_string` things Change-Id: I259ef61ecaf6ae7fabe0b3d211706ba5f429b3a7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6057 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4395 feat(wpcarro/fish): Drop support for rebuild-system aliasWilliam Carroll1-2/+0
v0v Change-Id: Icef033d3e400694b0c2246654fd88cda9e298320 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6056 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4394 fix(wpcarro/emacs): Set lsp-rust-serverWilliam Carroll1-0/+1
Whoops Change-Id: I24657c5ca852fd9e22e113ebec999fc873dc883e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6055 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4393 fix(wpcarro/emacs): Update rust configurationWilliam Carroll3-23/+26
- Prefer LSP to racer - Move KBDs to central location Change-Id: Ib3fbf1b383d711f3ac6dd6d7791374b014b9df90 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6054 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4392 fix(wpcarro/emacs): Remove vterm-mgt.el's dep on prelude.elWilliam Carroll1-2/+3
I wonder if there's an Elisp linter that can catch these errors at nix-build time. Change-Id: Ib54e1e57e46ef81021fc373ceecab5a729646472 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6048 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4391 feat(wpcarro/marcus): Disable auto-rebootWilliam Carroll1-9/+0
This only somewhat works, and I don't really need it. Change-Id: I4e78e5fd49ec07e6cb90a3feef8a4c87cb7b7707 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6047 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4390 feat(wpcarro/marcus): Enable Tailscale daemonWilliam Carroll1-0/+3
:) Change-Id: I5b2cd7a25c074a7e76bf97ffadd76c98577527bc Reviewed-on: https://cl.tvl.fyi/c/depot/+/6046 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4389 fix(wpcarro/marcus): Fix fstabWilliam Carroll1-5/+5
Labels `NIXROOT` and `NIXBOOT` don't exist, but `nixos` and `boot` do... Change-Id: I14296f1e03ed4b8953b360977921c3930c8907a6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6045 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4388 chore(wpcarro/emacs): Move list-wrap out of predicates sectionWilliam Carroll1-6/+6
Formatting issue. Change-Id: Ia5fe86572600a388beaf5e96b6dafd52ff223efb Reviewed-on: https://cl.tvl.fyi/c/depot/+/6044 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4387 fix(wpcarro/emacs): Remove lingering dash.el depWilliam Carroll2-1/+5
CI couldn't catch this because the dependency is discovered at runtime, and there were no tests consuming `list-concat`. Added the tests and removed the usage of `-concat`. Change-Id: I5bcce9aa8170001a9d35c104da09374ab30ffbc5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6043 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4386 docs(wpcarro/emacs): Document list.elWilliam Carroll2-32/+25
- Add README.md - Remove stale TODOs - Rephrase some of the module docs Change-Id: I14002836feeca4dd702350151b64600ea2a9125d Reviewed-on: https://cl.tvl.fyi/c/depot/+/6042 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4385 feat(wpcarro/emacs): Add fns to list.elWilliam Carroll4-10/+70
new functions: - duplicate - last - delete - wrap also: - drop support for `list-head` (in favor of `list-first`) - add optional arg to first Change-Id: If3c48d4749a3bc5a853995996fa02a65a4076a10 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6041 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4384 refactor(wpcarro/emacs): Remove list.el's dep on dash.el 🎉William Carroll3-45/+63
Still pruning the dependency tree. Thank you, seq.el, from DWIMing. Change-Id: I797f08abe44853b9d297a99d5ba9e9bde3dcfeec Reviewed-on: https://cl.tvl.fyi/c/depot/+/6040 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4383 docs(wpcarro/emacs): Add README to vterm-mgt.elWilliam Carroll1-0/+17
:) Change-Id: I65a9a4617b23ddc74207f2e45c380bf5988372e3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6039 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4382 fix(wpcarro/emacs): Properly wrap vterm buffers in earmuffsWilliam Carroll1-2/+2
Conventions are conventions... Change-Id: I1c9a0203e70cb9c762537353e8b640973dd93b26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6038 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4381 refactor(wpcarro/emacs): Remove vterm-mgt.el's dep on dash.elWilliam Carroll2-24/+22
TIL (or remembered rather) `seq.el` exists Change-Id: Iec5c21aff7a76906cb24d03bf39bf03f94b67760 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6037 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4380 fix(wpcarro/emacs): Fix load order for ava, tarascoWilliam Carroll2-16/+20
Looks like the everything after the `window-manager-init` call doesn't run. Change-Id: Ib5d81c5f079152bda658d213a39c07276b4ef6e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6036 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4379 refactor(wpcarro/emacs): Remove cycle.el's dep on maybe.elWilliam Carroll3-14/+6
More pruning on inter-library dependencies. Change-Id: I711ab92f2985b543ee2684752f9cdbf5559f2eaf Reviewed-on: https://cl.tvl.fyi/c/depot/+/6035 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4378 refactor(wpcarro/emacs): Prefer (null foo) to (eq nil foo)William Carroll1-4/+1
TIL `null` exists Change-Id: I48ef783cf5762e8770fbc6abf0d79c051e34090e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6034 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4377 docs(wpcarro/emacs): Provide README for struct.elWilliam Carroll1-0/+6
:) Change-Id: Ibf8b051f4ca5a3cded20d5256227ec9accfbb787 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6030 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-03 r/4376 feat(wpcarro/emacs): filteredGitPush struct.elWilliam Carroll1-0/+5
Expose struct.el on Github (precursor to a potential MELPA publish). Change-Id: Ic03af87d77b4bcfd660db8dba35ed3e6695ddc1e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6031 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-02 r/4375 chore(3p/sources): Bump channels & overlayssterni2-5/+9
* //users/grfn/system/home: build rain with Go 1.17, as it fails to build with Go 1.18 which introduces new compile-time errors * //3p/nixpkgs: pick ntfy from stable channel as it does not build on unstable * //users/sterni/emacs: make sure use-package is available before org-tracker can be loaded dynamically from $HOME/src. Interestingly this only became a problem with this channel bump. Change-Id: Id7d23b66bc3ba0202a01b4f8d670854e1f31175e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5988 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
2022-08-02 r/4374 fix(wpcarro/emacs): refs/heads/main -> refs/heads/canonWilliam Carroll1-1/+1
Let's just roll with the TVL conventions Change-Id: I1b90421ca7d9ad0d1ebbe922afdc62f80f0d5e97 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6033 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4373 refactor(wpcarro/emacs): Remove struct.el dep on s.elWilliam Carroll2-14/+6
This removes *all* of `struct.el`'s dependencies, which is liberating. Change-Id: Ic4a2438714ecf547ba5e07a1f0e77d743941073c Reviewed-on: https://cl.tvl.fyi/c/depot/+/6029 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-02 r/4372 docs(wpcarro/emacs): Add README to cycle.elWilliam Carroll1-0/+7
Include asciinema, which is only valid for 7d because their email authentication appears broken at the moment: https: //github.com/asciinema/asciinema-server/issues/347#issuecomment-1203063694 Change-Id: I33a38586a6660cd8c89bd9aff2d2a452e3c61a0b Reviewed-on: https://cl.tvl.fyi/c/depot/+/6032 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-02 r/4371 refactor(wpcarro/emacs): Remove struct.el dep on dash.elWilliam Carroll2-26/+17
Simplifying the dependency graph of struct.el :) Change-Id: I23f990d9f02f76d7f8b69c65f5d5090b1c572eed Reviewed-on: https://cl.tvl.fyi/c/depot/+/6028 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4370 feat(wpcarro/emacs): Support struct-update!William Carroll3-12/+41
Support mutable variant of `struct-update`. Also remove the `dash` dependency in `tests.el`. Change-Id: I76fc809e96b7cbbd3b39fd16db339cb62eab002c Reviewed-on: https://cl.tvl.fyi/c/depot/+/6027 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4369 refactor(wpcarro/emacs): Remove cycle.el dep on list.elWilliam Carroll2-5/+1
Cleaning-up the dependency graph before (maybe) publishing this to MELPA. Change-Id: Ic30c5e155621d57f0fd3ec30ef6c9e4ab14aba3e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6026 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4368 feat(wpcarro/fish): Support systemctl aliasWilliam Carroll1-0/+1
It's about time... Change-Id: If28c2c97d6d953bbe09f6ff811639032df04f4ec Reviewed-on: https://cl.tvl.fyi/c/depot/+/6025 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4367 fix(wpcarro/clipmenu): Enable services.clipmenuWilliam Carroll2-3/+3
Restore `clipmenu.el` functionality! After running `sudo rebuild-system` I still needed to `systemctl --user start clipmenu`, which I didn't expect. Maybe this will DWIM after a reboot. Change-Id: I51550561c5b6d253cd52790749d07a2e3e72aecc Reviewed-on: https://cl.tvl.fyi/c/depot/+/6024 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4366 feat(wpcarro/common): Install syszWilliam Carroll1-0/+1
It's a nice `fzf`-based systemd interface. Change-Id: Iab1598cae9aafd7c7cc4d8a3ac94895393f592c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6023 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-02 r/4365 feat(wpcarro/emacs): Support list-chunk functionWilliam Carroll2-0/+28
Would be nice to remove the top-level `if` statement, but I can't be bothered to debug the first unit test without that workaround. Change-Id: I4ba576bda915eeb11f9fbfeb5d95d8e5668fd0bd Reviewed-on: https://cl.tvl.fyi/c/depot/+/6022 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-01 r/4364 feat(wpcarro/fish): Support more git aliasesWilliam Carroll1-0/+2
These have passed the test of time. Change-Id: I9ae2cfe0b29b0e63f9e98f158840bd0e5ba53bed Reviewed-on: https://cl.tvl.fyi/c/depot/+/6019 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-01 r/4363 feat(wpcarro/emacs): Package vterm-mgt.elWilliam Carroll3-0/+19
Pretty useful (but still needs some polishing) library for working with `vterm`, which I use on a daily basis. Change-Id: Ic6693f52ad9b16b0b4dd1338aedeeccd6ff15379 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6017 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI