about summary refs log tree commit diff
path: root/users
AgeCommit message (Collapse)AuthorFilesLines
2021-06-05 r/2643 feat(gs/emacs): Update irc-connect command for new serversGriffin Smith1-3/+9
No longer connecting to freenode - but I *am* now connecting to both hackint and libera, so add a prompt to the command to decide which one I connect to Change-Id: Iae315ddab753cf9c365cbee7abd94213af656d4c Reviewed-on: https://cl.tvl.fyi/c/depot/+/3177 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-06-02 r/2642 feat(gws.fyi): Use awscli2 to deployGriffin Smith1-1/+1
Use awscli2 rather than awscli to deploy - less because I actually need any specific functionality from the new version, and more because I already use awscli2 on my systems and it's nice to always use the same version of stuff Change-Id: Id0e5b63dde1857c2e417ac2eeb2f769ebcc0f956 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3175 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-06-01 r/2637 fix(tazjin/emacs): Install rust-mode explicitlyVincent Ambo1-0/+1
... rather than dragging it in as some transitive dep, which actually stopped happening. Change-Id: I2331721839d5e53c38236f64487be0e6f1be352e Reviewed-on: https://cl.tvl.fyi/c/depot/+/3170 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-06-01 r/2636 feat(gs/home): Update discord to 0.0.15Griffin Smith1-2/+2
Change-Id: I17b979217360545c52073b67c5ba878e8891a650 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3168 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-05-31 r/2635 revert(grfn/yeren): "Set timezone to Africa/Cairo"Griffin Smith1-2/+0
This reverts commit e1c45be3f58f5ae139439994b8d72f7d58c5c895. I'm back in NY now T.T Change-Id: Iaae2bf778195b9a99ac1a46068703a58e6b69053 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3166 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-05-25 r/2630 chore(nixpkgs): Bump channels to 2021-05-25Vincent Ambo5-16/+13
* users/grfn/system/home/yeren: remove obsolete awscli2 overrides * ops: make new isSystemUser || isNormalUser assertion happy * users/grfn/system/system/mugwump: make buildkite agents system users * users/tazjin/nixos/camden: set isSystemUser = true for git * users/tazjin/emacs: Remove missing & broken packages * third_party/openldap: remove, as the argon2 module is now enabled upstream * third_party/gerrit_plugins: Pinned new unstable hashes * third_party/nix, third_party/grpc: Disabled CI as these are broken * third_party/overlays/emacs: Bumped version to stay in sync with channel * third_party/buzz: Update LIBCLANG_PATH to reference libclang.lib, since libclang's default output no longer contains libclang.so * users/grfn/system/home: Install julia-stable instead of julia (which aliases to julia-lts), as the latter depends on an insecure version of libgit Change-Id: Iff33b0ecb0ef07a82d1de35e23c40d2f4bf0f8ed Reviewed-on: https://cl.tvl.fyi/c/depot/+/3001 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi>
2021-05-25 r/2629 feat(gs/home): Add script to graphviz the clipboardGriffin Smith2-0/+13
Add a script (to PATH, so I can launch it from rofi) to take whatever's in the clipboard, pass it through `dot -Tpng`, and then open the result with feh. Change-Id: I1842fca3585a33d902da20dfa6101d1c6d2f2062 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3160 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-05-24 r/2622 chore(3p/overlays): Remove LLVM11 bump from overlayVincent Ambo3-6/+10
* This was mostly for //third_party/nix and its dependencies which now have been set to use llvmPackages_11 manually. * For //users/grfn/achilles we also manually select the newer LLVM version. * //tools/cheddar doesn't seem to need llvm anymore. * //third_party/buzz also compiles with clang 7.1.0 * replace clang-tools everywhere with new attribute clang-tools_11 For the future we may want to have something similar again, but it may not be necessary to invest too much time into it: nixpkgs is set to upgrade their default llvmPackages to LLVM 11 as well at some point in the near future. Co-Authored-By: sterni <sternenseemann@systemli.org> Change-Id: Id83868dbc476a6c776b59518b856c933f30ea79d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3135 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi>
2021-05-23 r/2618 chore: Replace remaining mentions of ##tvl[-dev] with #tvlVincent Ambo2-2/+2
... and fix the capitalisation of hackint Change-Id: I800aef75152d2dc77a33876888e36530143e9d3e Reviewed-on: https://cl.tvl.fyi/c/depot/+/3148 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: sterni <sternenseemann@systemli.org>
2021-05-22 r/2609 chore: Replace Freenode mentions with HackIntVincent Ambo2-2/+2
This doesn't replace all of them in the repo, but at least the ones that are relevant to our move. Change-Id: I842e7594b4c16af30d880272417874f6b29afd22 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3134 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: grfn <grfn@gws.fyi>
2021-05-22 r/2608 feat(tverskoy): Add mail fetching timer for lieerVincent Ambo1-0/+19
Change-Id: I60b09d2c81c3c69f744a12adc41fbdc43d0fb488 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3133 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-05-22 r/2607 refactor(tazjin/emacs): Switch to sending mail via lieerVincent Ambo3-5/+7
This drops the msmtp requirement from my configuration; there's still some cleanup to be done but I need to double-check this in a few environments first. Change-Id: I298f4ff77b45cb214fbccee84e9bbd861508d11a Reviewed-on: https://cl.tvl.fyi/c/depot/+/3132 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-05-17 r/2595 feat(tools): add rust-crates-advisoryProfpatsch3-11/+5
We have a bunch of crates in `third_party/rust-crates`; it would be great if we could check them for existing CVEs. This tool does that, it takes the rust security advisory database, parses the applicable CVEs, and cross-checks them against the actual crate versions we list in our package database. The dumb parser we wrote is tested against all entries in the database, so we will notice when upstream breaks their shit. Checking the semver stuff is easy enough with the semver crate. If an advisory matches, it prints the whole thing and fails the build. Change-Id: I9e912c43d37a685d9d7a4424defc467a171ea3c4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2818 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: sterni <sternenseemann@systemli.org>
2021-05-17 r/2594 fix(nix/writers/rust): remove args overrideProfpatsch1-2/+0
We can be closed world, so let’s restrict the arguments to the subset we need for now. The existing override was wrong, in that `// args` would use the arguments we already added, again. So instead of deliberating about how to make this work right in all cases, we don’t need it, we trim it. Change-Id: I6443a0808b8bfd5e4db939b669c6afc741954db8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3057 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-05-13 r/2593 feat(grfn/modules/laptop): Enable TLP serviceVincent Ambo1-0/+2
This service performes automatic power tuning and has effectively replaced powertop's tuning functionality in modern systems. Change-Id: I63c6999beed64d96c77b8b9287ed0d5fa6ddd9fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/3121 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-05-13 r/2592 fix(yeren): Force enable ASPM in kernel parametersVincent Ambo1-0/+1
This might help with the issue of devices being stuck in a slow power-saving mode after hibernation. Dell enables this on laptops shipping with Linux by default according to some forum posts. Change-Id: I3d7fdb5c2ed5e24289a6c20f21d027e11b7826e5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3120 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-05-12 r/2584 chore(tazjin/emacs): Ignore messages from blocked senders in telegaVincent Ambo1-1/+3
telega actually supports this for group chats, too, which is very pleasant. https://zevlg.github.io/telega.el/#client-side-messages-ignoring Change-Id: I510207c2de19f748359168d460a25aa9c4e45975 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3111 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-05-12 r/2582 feat(gs/emacs): Update async test snippet for tokio 1.xGriffin Smith1-1/+1
Change-Id: I897f3efae7920dee678f6ca03d743b12212b766c Reviewed-on: https://cl.tvl.fyi/c/depot/+/3109 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-05-12 r/2581 fix(gs/emacs): Correct next/prev error bindingsGriffin Smith1-4/+4
next-error and prev-error are weirdly broken in ways I don't entirely understand, but I only really use flycheck so I can just use the flycheck ones instead Change-Id: Icdb25950f6fdcca163c68db30366af0f6fa28d7d Reviewed-on: https://cl.tvl.fyi/c/depot/+/3108 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-05-11 r/2577 chore(owothia): move to //fun/owothiaVincent Ambo10-353/+0
Owothia graduates, or something. Mostly I don't want infrastructure to depend on stuff in //users. Does anyone know where owothia is running anyways? Change-Id: I198c7ac935736c7aee3ba4fbda1453b82aa10283 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3103 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-05-03 r/2558 feat(users/Profpatsch/blog): add rust-string-conversions noteProfpatsch2-4/+58
Change-Id: I7bee585935e65660f6b25b88ed33f09775eb01a0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3088 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-30 r/2555 feat(users/Profpatsch/blog): implement blog engine lolProfpatsch2-0/+353
My horrible blog engine v0.0.0.0.1. Don’t judge. Change-Id: I427b4e84d67aa49793cb7625e4d8ca2824f00943 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2456 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-30 r/2554 fix(users/Profpatsch/netencode): use write_all in encoderProfpatsch1-4/+4
`write` returns the written usize; now I wonder why rustc didn’t at least produce a warning because the result was unused. Do we need to add any flags to `rustSimple`? Change-Id: If8d51d95c993dec6c92e46dbc82cd8cdd398f441 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3056 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-28 r/2552 feat(grfn/yeren): Install tdesktopGriffin Smith1-0/+1
Change-Id: I951224d0cfd6d8c1d0eda752134bf9b9375c7cdb Reviewed-on: https://cl.tvl.fyi/c/depot/+/3053 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-28 r/2551 feat(grfn/yeren): Install+configure ntfyGriffin Smith1-0/+3
automatic notifications when long-running commands are done! that's cool. Change-Id: Ic9451c0c349661c3df8ba1058748a59159bc4b3f Reviewed-on: https://cl.tvl.fyi/c/depot/+/3044 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-27 r/2549 fix(tazjin/blog): Fix minor typos in WatchGuard postVincent Ambo1-13/+13
Change-Id: Iaeb9fab5a80597469e5efdf24655ae07dca48fe1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3058 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-04-24 r/2547 chore(nix): move rustSimple from users.Profpatsch.writersProfpatsch12-158/+19
I think it’s solid enough to use in a wider context. Change-Id: If53e8bbb6b90fa88d73fb42730db470e822ea182 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3055 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-04-24 r/2546 feat(nix): add basic netstring nix generation functionsProfpatsch2-18/+5
Moving to toplevel so I can use them with `runExecline`. They should be pretty atomic, and are proven to work (tests are still in my user dir, since they test the producers indirectly via the python parser and I don’t want to pull it out right now). Change-Id: Id0baa3adcb2ec646458a104c7868c2889b8c64f5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3054 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2021-04-23 r/2545 feat(users/Profpatsch/lib): add eprint-stdin-netencodeProfpatsch2-3/+17
Like `eprint-stdin`, but reads stdin as netencode and pretty-prints it to stderr. Change-Id: I430c010b0cac45f077cde9dadfd79adfa7a53eca Reviewed-on: https://cl.tvl.fyi/c/depot/+/2533 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2544 feat(users/Profpatsch/netencode): add pretty printerProfpatsch2-0/+172
Simple pretty printer for netencode values, as a rust library and an accompanying command line tool which takes netencode on stdin and prints the pretty version to stdout. Change-Id: I0a57c644985162bc08a9bf1ee78f7be278400199 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2532 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2543 feat(users/Profpatsch/netencode): add env-splice-recordProfpatsch2-8/+37
It’s the inverse of record-splice-env! It sucks up the environment and prints it as a netencode dict! Only the utf-8 clean parts at least. Change-Id: I96c19fc5ea3a67a23e238f15f4d0fa783081859c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2527 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2542 feat(users/Profpatsch/struct-edit): per-level positionProfpatsch1-46/+59
The user expects the editor to remember the positions of fields they navigated from to a new level, so when they return they get put in the same spot. We push the index from one field into every level of the value. Unfortunately this introduces pointers and all the woes they bring. Change-Id: I889c28b71fd7082b765e1d6874faeb1b36dade60 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2866 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2541 chore(users/Profpatsch/struct-edit): factor out non-val enumerationProfpatsch1-5/+17
This will be needed to factor the current cursor position into vals. Change-Id: I73635b13c29b6b8925c68005c8db1c4dda93f15d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2865 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2540 fix(users/Profpatsch/struct-edit): change arrow keysProfpatsch1-4/+4
Since items are aligned per-line, it makes more intuitive sense to use up/down for previous/next item, and left to go up and right to go down. Change-Id: I6bc33bd4e6e8f9fb245d252ca063dfabf972147d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2864 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2539 feat(users/Profpatsch/struct-edit): add support for mapsProfpatsch1-22/+71
This makes it possible to pipe json dicts to the program and fully navigate them. Change-Id: I18dd8683d6f00c8ea967eb0c8dc89d1e0735fbcb Reviewed-on: https://cl.tvl.fyi/c/depot/+/2863 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-23 r/2538 feat(users/Profpatsch/struct-edit): initial versionProfpatsch2-0/+370
A take at a TUI-based structural editor, which should eventually read a type definition of a structure and some values, and build a GUI to edit it. So far you can only pipe it some restricted json (lists, strings and floats) and “navigate” through the structure with the arrow keys. Change-Id: I7c8546459ff86c766fc03723f732c7d9f863ceaa Reviewed-on: https://cl.tvl.fyi/c/depot/+/2862 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de>
2021-04-20 r/2533 chore(3p/emacs): Remove obsolete third-party packagesVincent Ambo1-3/+3
We don't need these in the depot anymore as the Emacs overlay now provides newer versions of them, or because they are not used anymore. Change-Id: I393e1580b66450d0bb128213bc79668172dadacc Reviewed-on: https://cl.tvl.fyi/c/depot/+/3005 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-04-20 r/2531 refactor(grfn/emacs): Use TVL Emacs packages from fixpointVincent Ambo1-3/+1
Change-Id: I01d8993cc900ba34eb780524e040762c884c9815 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3009 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-04-20 r/2528 refactor(grfn): Stop importing nixpkgs a bunch of timesVincent Ambo9-35/+12
Once is enough! <grfn> https://tazj.in/blobs/touch-garbage.jpg Change-Id: I68f66669e82d35a71752638450fa4b820e137172 Signed-Off-By: Florian Klink <flokli@flokli.de> Reviewed-on: https://cl.tvl.fyi/c/depot/+/3048 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-04-20 r/2527 refactor(ops/nixos): Ensure that pkgs == depot.third_party.nixpkgsVincent Ambo3-42/+15
This is currently done ad-hoc in a bunch of our systems, but we should just do it centrally. The commit message is a bit of a lie, as this doesn't yet update grfn's systems. Change-Id: Ic771c1a1da78ec5de9cffbf94c296dce5e11fd84 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3047 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-18 r/2525 feat(grfn/home): Bind brightness keys with brightnessctlGriffin Smith1-0/+4
thanks, flokli! Change-Id: I3256bc66984939dde1bb397c3c5007a8296670ab Reviewed-on: https://cl.tvl.fyi/c/depot/+/3030 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-17 r/2523 feat(tverskoy): enable eink toolingFlorian Klink1-1/+8
Provide ddcutil and paperlike-go in $PATH. Provide the necessary udev and kernel module plumbing so they work as non-root. Icecream-Required-From: Vincent Ambo <mail@tazj.in> Change-Id: Ic9323a45cdbb75571e8f8b3aca4b9a763c271968 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3029 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-17 r/2522 feat(grfn/achilles): Implement tuples, and tuple patternsGriffin Smith12-54/+413
Implement tuple expressions, types, and patterns, all the way through the parser down to the typechecker. In LLVM, these are implemented as anonymous structs, using an `extract` instruction when they're pattern matched on to get out the individual fields. Currently the only limitation here is patterns aren't supported in function argument position, but you can still do something like fn xy = let (x, y) = xy in x + y Change-Id: I357f17e9d4052e741eda8605b6662822f331efde Reviewed-on: https://cl.tvl.fyi/c/depot/+/3027 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-17 r/2521 feat(grfn/yeren): Set timezone to Africa/CairoGriffin Smith2-1/+3
\o/ Change-Id: Ia456e044c48eee095408efc9f6b802b4337ea09f Reviewed-on: https://cl.tvl.fyi/c/depot/+/3026 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-17 r/2520 chore(grfn/achilles): Load shell.nix from depotGriffin Smith1-4/+2
Rather than pinning a nixpkgs in here, just import the relative path to the depot to load nixpkgs. Change-Id: I452727d45e4f44ecc99b86d17e88a413c1911c59 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3025 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-16 r/2518 feat(grfn/emacs): Configure notmuch popup window rulesGriffin Smith1-0/+8
I want notmuch to open in a full window, not as a bottom-of-the-screen popup. Change-Id: If539ff315fabae94d5a849c526c4322f9bdf8c61 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3024 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-16 r/2517 feat(grfn/home): Save GDB history across invocationsGriffin Smith1-0/+8
Change-Id: Icb02d64b036c07f3ab5f41f3b2c714ec164c2b05 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3023 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-16 r/2516 feat(grfn/yeren): Install rrGriffin Smith2-0/+14
This... mostly works! I had to install it from the latest master branch to get it functioning on my CPU, hopefully once they release a new version I can remove the override. Change-Id: I863d2e822b149838c58aa1c1e7dc73a127a0aeb8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3022 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-16 r/2515 feat(grfn/home): Install evcxrGriffin Smith1-0/+1
It's a REPL! for Rust! Change-Id: I920f976790bd974bb3a41e56b94b9e11bbb8e59b Reviewed-on: https://cl.tvl.fyi/c/depot/+/3021 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-16 r/2514 feat(tazjin/tverskoy): Enable TLP daemonVincent Ambo1-0/+1
Change-Id: Ie6d7a6fe07ffccf8dc18257eed54bb990e22e064 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3019 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>