about summary refs log tree commit diff
path: root/users/wpcarro (follow)
AgeCommit message (Collapse)AuthorFilesLines
2022-10-26 r/5202 feat(wpcarro/git): Set --autostash during rebasesWilliam Carroll1-0/+2
Much less painful Change-Id: I77f1220979d3ab2b2a4c45c7d0018b92df84fee1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7101 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-25 r/5197 feat(wpcarro/compiler): Support Vector typeWilliam Carroll5-95/+192
Support an array that dynamically resizes itself, and replace usages of `List`, `Array`, and `Queue` with `Vec`. Change-Id: I910b140b7c1bdddae40e08f8191986dccbc6fddf Reviewed-on: https://cl.tvl.fyi/c/depot/+/7080 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-10-25 r/5196 feat(wpcarro/compiler): Support string literal typeWilliam Carroll3-5/+34
``` repl> "Hello, world" String repl> (fn x "testing") a0 -> String ``` Change-Id: Ia76299a56aa4d2032c9a21277e2fddfb2e055831 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7079 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-10-25 r/5195 refactor(wpcarro/compiler): Modularize debug fnsWilliam Carroll7-85/+91
Define `debug.ml` and `prettify.ml` to clean-up some code. Change-Id: Iee2e1ed666f2ccb5e56cc50054ca85b8ba513f3b Reviewed-on: https://cl.tvl.fyi/c/depot/+/7078 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-10-24 r/5194 feat(wpcarro/scratch): Implement "Algorithm W"William Carroll7-1/+658
I've been wanting to grok Haskell-style type inference for awhile, so instead of just watching conference talks and reading papers about it, I've decided to attempt to implement it to more readily test my understanding of it. Change-Id: I69261202a3d74d55c6e38763d7ddfec73c392465 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6988 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-10-15 r/5139 feat(wpcarro/ava): Set initialPasswordWilliam Carroll1-0/+1
This is useful when first setting up a device. Call `passwd` afterwards to imperatively change the password. Change-Id: I070f1cfaf05a38844ee363be4d511035e77096d6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7013 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2022-10-15 r/5138 feat(wpcarro/gitconfig): Set push.default to currentWilliam Carroll1-0/+2
Also: - move to `dotfiles` subdir - rename .gitignore -> gitignore Change-Id: I098aef39ba3415de54812d4d36f8672b0e094c86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7012 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2022-10-10 r/5093 feat(wpcarro/scratch): Rewrite Python compiler in OCamlWilliam Carroll4-0/+154
Just to see how productive I could be in OCaml with little familiarity. Overall I really like it. Change-Id: I8affc65a5ee86a29d4f8c01426529ae9948660f9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6934 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-10 r/5081 feat(wpcarro/scratch): Proof-of-concept register VMWilliam Carroll1-0/+161
I heard that register VMs might be slightly faster than stack VMs, and then it occurred to me that I wouldn't know how to write a register VM if I tried. So I wrote one (sort of). Change-Id: I15309bca88f4b43f6e04957acedc90d9adf16673 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6902 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-07 r/5056 fix(wpcarro/blog): typos, grammatical errorsWilliam Carroll1-11/+11
More notes to me :) Change-Id: I5264b4234cde67b12610e126ff1d896f6e20457e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6891 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-07 r/5055 feat(wpcarro/blog): git-filter-repo (note to self)William Carroll2-0/+66
More notes to me :) Change-Id: I27859468249a320a6c307937fd54aa7f1279fd8e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6890 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-07 r/5054 feat(wpcarro/dotfiles): Use difftastic as git diff engineWilliam Carroll1-0/+2
Mostly good, but I'm not sure it works with `git diff --patch`. Not a big deal though if true. Change-Id: I268c52dd253f5b0f9dd462a1825206da5dd86dd2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6889 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-07 r/5053 fix(wpcarro/blog): Fix markdown hyperlink syntaxWilliam Carroll2-5/+5
i always seem to get this wrong Change-Id: Ib6f31523aba1d9f9a32d9af95b96b8d75e0ec16e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6863 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-07 r/5052 feat(wpcarro/blog): nix-shell (note to self)William Carroll2-0/+57
Publishing another "note to self" Change-Id: If5d052f0360f3e1f371b0c1fdd3781e5bb846ea4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6861 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-10-04 r/5031 refactor(wpcarro/dotfiles): Move gitconfig into dotfilesWilliam Carroll1-0/+0
Not sure why/how I ended-up with both dotfiles *and* configs, but I don't really like working with `stow`, so I'm preferring dotfiles. Change-Id: Id00566ea8206eef65b9a27dd4765c2d17f3d2317 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6865 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-04 r/5030 feat(wpcarro/keys): Add kyokoWilliam Carroll1-0/+2
yet another computer Change-Id: I77f52b863c9b8567a22ab288ab1c5548ba0e1207 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6862 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-10-04 r/5029 feat(wpcarro/envrc): Add REPO_ROOTWilliam Carroll1-0/+2
Some commit removed this, and I didn't notice. Change-Id: I6686282fd3c0d2569120b5687ecdfdc04367fe1e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6864 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-09-28 r/4980 chore(3p/sources): Bump channels & overlayssterni2-4/+4
Upstream nixpkgs removed a lot of aliases this time, so we needed to do the following transformations. It's a real shame that aliases only really become discoverable easily when they are removed. * runCommandNoCC -> runCommand * gmailieer -> lieer We also need to work around the fact that home-manager hasn't catched on to this rename. * mysql -> mariadb * pkgconfig -> pkg-config This also affects our Nix fork which needs to be bumped. * prometheus_client -> prometheus-client * rxvt_unicode -> rxvt-unicode-unwrapped * nix-review -> nixpkgs-review * oauth2_proxy -> oauth2-proxy Additionally, some Go-related builders decided to drop support for passing the sha256 hash in directly, so we need to use the generic hash arguments. Change-Id: I84aaa225ef18962937f8616a9ff064822f0d5dc3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6792 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-09-19 r/4922 chore(gerrit): migrate OWNERS files to code-owners styleLuke Granger-Brown1-3/+3
Change-Id: Iacc521dfdd4b4a2d5cef3920cf8189bcce35a488
2022-09-14 r/4855 chore(3p/sources): Bump channels & overlayssterni1-2/+0
* //users/wpcarro/emacs: rls was removed from nixpkgs and is hopefully no longer necessary in this emacs setup. Change-Id: Ib8371da652c434e74eb67a2030b212a6423a1891 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6577 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-09-12 r/4826 feat(wpcarro/ssh): Support iPhone SSH keyWilliam Carroll3-12/+18
For termius access Change-Id: Ic91b80bfc8deb816b5a7634ca5e74bb026729067 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6542 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-09-12 r/4825 feat(wpcarro/ava): Enable printingWilliam Carroll1-0/+5
Gotta print stuffs at the office (every decade or so) Change-Id: I3241b7a86eead50cadf785bb0204c803e40ac360 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6543 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-09-06 r/4687 feat(wpcarro/rust): Define Rc<T> exampleWilliam Carroll3-2/+15
My foray into "smart pointer" land. Change-Id: I4ca775c72168dd34d90bf88fa41149867cd7fdae Reviewed-on: https://cl.tvl.fyi/c/depot/+/6244 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-09-06 r/4686 feat(wpcarro/emacs): Drop racer.el supportWilliam Carroll2-3/+5
AFAIU `racer` is deprecated in favor of LSP. Change-Id: I8bee3bb32d208b4f21cd7699ae93fc76a69ec964 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6051 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-09-06 r/4684 fix(users/wpcarro): Fix Hadrian pathWilliam Carroll2-2/+2
This looks like a copy-paste error. Change-Id: I21594412075d361d824074b7612c8dbafb4f9f30 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6369 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-09-06 r/4683 feat(wpcarro/emacs): Set initial-buffer-choice per-hostWilliam Carroll4-4/+7
Work machines should prefer `/hadrian` and personal machines should prefer `/depot`. Change-Id: I03b605cc5ce233767146d83f14f368863897cf8b Reviewed-on: https://cl.tvl.fyi/c/depot/+/6368 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-29 r/4526 fix(wpcarro/emacs): Support rust.el PATH depsWilliam Carroll1-0/+3
There might be a better way to do this using `direnv`'s `use_nix` and shlevy's `nix-buffer` Elisp package, but I'm doing this for now. Change-Id: I4246c519f39eea1bde3191762b184b37d30fbeed Reviewed-on: https://cl.tvl.fyi/c/depot/+/6049 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-29 r/4525 feat(wpcarro/rust): Define stdin exampleWilliam Carroll2-6/+24
Pipe Rust strings to shell commands. Change-Id: Id8afeed642d30c79e193fa9b353de081a5843eb5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6197 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-09 r/4396 feat(wpcarro/rust): Include std::fmt::Display exampleWilliam Carroll6-50/+123
Gotta know how to `to_string` things Change-Id: I259ef61ecaf6ae7fabe0b3d211706ba5f429b3a7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6057 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4395 feat(wpcarro/fish): Drop support for rebuild-system aliasWilliam Carroll1-2/+0
v0v Change-Id: Icef033d3e400694b0c2246654fd88cda9e298320 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6056 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4394 fix(wpcarro/emacs): Set lsp-rust-serverWilliam Carroll1-0/+1
Whoops Change-Id: I24657c5ca852fd9e22e113ebec999fc873dc883e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6055 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-08 r/4393 fix(wpcarro/emacs): Update rust configurationWilliam Carroll3-23/+26
- Prefer LSP to racer - Move KBDs to central location Change-Id: Ib3fbf1b383d711f3ac6dd6d7791374b014b9df90 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6054 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4392 fix(wpcarro/emacs): Remove vterm-mgt.el's dep on prelude.elWilliam Carroll1-2/+3
I wonder if there's an Elisp linter that can catch these errors at nix-build time. Change-Id: Ib54e1e57e46ef81021fc373ceecab5a729646472 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6048 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4391 feat(wpcarro/marcus): Disable auto-rebootWilliam Carroll1-9/+0
This only somewhat works, and I don't really need it. Change-Id: I4e78e5fd49ec07e6cb90a3feef8a4c87cb7b7707 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6047 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4390 feat(wpcarro/marcus): Enable Tailscale daemonWilliam Carroll1-0/+3
:) Change-Id: I5b2cd7a25c074a7e76bf97ffadd76c98577527bc Reviewed-on: https://cl.tvl.fyi/c/depot/+/6046 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-06 r/4389 fix(wpcarro/marcus): Fix fstabWilliam Carroll1-5/+5
Labels `NIXROOT` and `NIXBOOT` don't exist, but `nixos` and `boot` do... Change-Id: I14296f1e03ed4b8953b360977921c3930c8907a6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6045 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4388 chore(wpcarro/emacs): Move list-wrap out of predicates sectionWilliam Carroll1-6/+6
Formatting issue. Change-Id: Ia5fe86572600a388beaf5e96b6dafd52ff223efb Reviewed-on: https://cl.tvl.fyi/c/depot/+/6044 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4387 fix(wpcarro/emacs): Remove lingering dash.el depWilliam Carroll2-1/+5
CI couldn't catch this because the dependency is discovered at runtime, and there were no tests consuming `list-concat`. Added the tests and removed the usage of `-concat`. Change-Id: I5bcce9aa8170001a9d35c104da09374ab30ffbc5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6043 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4386 docs(wpcarro/emacs): Document list.elWilliam Carroll2-32/+25
- Add README.md - Remove stale TODOs - Rephrase some of the module docs Change-Id: I14002836feeca4dd702350151b64600ea2a9125d Reviewed-on: https://cl.tvl.fyi/c/depot/+/6042 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4385 feat(wpcarro/emacs): Add fns to list.elWilliam Carroll4-10/+70
new functions: - duplicate - last - delete - wrap also: - drop support for `list-head` (in favor of `list-first`) - add optional arg to first Change-Id: If3c48d4749a3bc5a853995996fa02a65a4076a10 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6041 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-05 r/4384 refactor(wpcarro/emacs): Remove list.el's dep on dash.el 🎉William Carroll3-45/+63
Still pruning the dependency tree. Thank you, seq.el, from DWIMing. Change-Id: I797f08abe44853b9d297a99d5ba9e9bde3dcfeec Reviewed-on: https://cl.tvl.fyi/c/depot/+/6040 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4383 docs(wpcarro/emacs): Add README to vterm-mgt.elWilliam Carroll1-0/+17
:) Change-Id: I65a9a4617b23ddc74207f2e45c380bf5988372e3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6039 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4382 fix(wpcarro/emacs): Properly wrap vterm buffers in earmuffsWilliam Carroll1-2/+2
Conventions are conventions... Change-Id: I1c9a0203e70cb9c762537353e8b640973dd93b26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6038 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-04 r/4381 refactor(wpcarro/emacs): Remove vterm-mgt.el's dep on dash.elWilliam Carroll2-24/+22
TIL (or remembered rather) `seq.el` exists Change-Id: Iec5c21aff7a76906cb24d03bf39bf03f94b67760 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6037 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4380 fix(wpcarro/emacs): Fix load order for ava, tarascoWilliam Carroll2-16/+20
Looks like the everything after the `window-manager-init` call doesn't run. Change-Id: Ib5d81c5f079152bda658d213a39c07276b4ef6e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6036 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4379 refactor(wpcarro/emacs): Remove cycle.el's dep on maybe.elWilliam Carroll3-14/+6
More pruning on inter-library dependencies. Change-Id: I711ab92f2985b543ee2684752f9cdbf5559f2eaf Reviewed-on: https://cl.tvl.fyi/c/depot/+/6035 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4378 refactor(wpcarro/emacs): Prefer (null foo) to (eq nil foo)William Carroll1-4/+1
TIL `null` exists Change-Id: I48ef783cf5762e8770fbc6abf0d79c051e34090e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6034 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-08-03 r/4377 docs(wpcarro/emacs): Provide README for struct.elWilliam Carroll1-0/+6
:) Change-Id: Ibf8b051f4ca5a3cded20d5256227ec9accfbb787 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6030 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-03 r/4376 feat(wpcarro/emacs): filteredGitPush struct.elWilliam Carroll1-0/+5
Expose struct.el on Github (precursor to a potential MELPA publish). Change-Id: Ic03af87d77b4bcfd660db8dba35ed3e6695ddc1e Reviewed-on: https://cl.tvl.fyi/c/depot/+/6031 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2022-08-02 r/4374 fix(wpcarro/emacs): refs/heads/main -> refs/heads/canonWilliam Carroll1-1/+1
Let's just roll with the TVL conventions Change-Id: I1b90421ca7d9ad0d1ebbe922afdc62f80f0d5e97 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6033 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI