about summary refs log tree commit diff
path: root/tools/emacs-pkgs/tvl/tvl.el (follow)
AgeCommit message (Collapse)AuthorFilesLines
2023-04-07 r/6075 feat(emacs-pkgs/tvl): allow starting sly only including dependenciessterni1-6/+15
Usually the current behavior is best: You are dropped in a REPL with the package(s) you are working on already available. As you are working on them, you recompile individual files and your changes become available. However, I've found that there are some occasions when this is not desireable, e.g.: When you are working on something and have broken the test suite intermittently, it becomes impossible to start a new REPL. Not sure how the yes-or-no-p question should be phrased, its negation may be better? Change-Id: I6a37ebc02f3121f628fc9206e0de650851824cd6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8415 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-08-13 r/4420 feat(tvl.el): add magit-gerrit-push-privateVincent Ambo1-0/+13
This adds a new function (intentionally bound to a rare key (Q)) in the push menu which can push a *private* change to Gerrit. A private change is one that, until submitted, is only visible to its owner and all explicitly added people (reviewers, CC). Change-Id: I6ee13dbbad099584475d3efac96e5d9b86efbc26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6061 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-17 r/3622 refactor(tools/emacs-pkgs): move sly-from-depot to tvl.elsterni1-1/+35
The function is depot specific and thus uses tvl-depot-path, so it belongs in `tvl.el`. Since non-sly-users won't need it, we tie its definition to loading the sly package. Change-Id: I8b104deab455d218d3df6a800e35cc104220a841 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4960 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2021-12-27 r/3462 refactor(tvl.el): use flags of gerrit-ref for WIPzseri1-1/+1
Change-Id: I858070ff8e48ca7e556f33d276e89b6ae940519c Reviewed-on: https://cl.tvl.fyi/c/depot/+/4630 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-12-21 r/3329 fix(tvl.el): Change prompt for different commandsGriffin Smith1-4/+4
Prompting with "Checkout CL" for the gerrit cherry-pick command doesn't make any sense. Change-Id: I51495e7975202146fae2da0807e525596f2d490e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4516 Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-12-15 r/3260 fix(tvl.el): Replace fifth with nth 4Griffin Smith1-1/+1
as before, fifth doesn't exist on all emacsen, but nth definitely does Change-Id: Ic0e4e3790402d960d1546d37187758a4d9ca33c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4346 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-12-10 r/3206 fix(tvl.el): Fix use of label command in refsVincent Ambo1-4/+4
The l= is part of the command, not of the shape of commands, and the previous command concatenation logic was wrong because of that. Fix is done in the most obvious way: Make the l= part of the command. Change-Id: Ia3c08c3da60fe5fc38f29a2d94adcd123e4f3052
2021-12-10 r/3196 feat(tvl.el): Add autosubmit feature to magit-gerrit-rubberstampVincent Ambo1-4/+6
This makes this function a true rubberstamp again, leading to rubberstamped CLs automatically being merged after CI passes. This is similar to the initial functionality we had last year, where this directly submitted changes, but with the addition of the CI checks. Change-Id: I946b074b968eb18a64c4edb0043f7a4af28759b4
2021-12-10 r/3195 feat(tvl.el): Add shortcut for push with Autosubmit+1Vincent Ambo1-0/+11
This almost makes for a sort of fire&forget button, except we don't have a way to automatically pick reviewers yet :) Change-Id: I6f446270f8aaf0409ccb6321bdbb5c349079cd19
2021-12-09 r/3163 feat(tvl.el): Add magit-gerrit-cherry-pickGriffin Smith1-0/+20
Bound to `A g`, this behaves similarly to `magit-gerrit-checkout` - it prompts for a CL number, then cherry-picks the latest patchset of that CL number Change-Id: Ieef970b99d96170e8c960cc7687ead9022948f8b
2021-12-07 r/3152 fix(tvl.el): s/fourth/cadddrGriffin Smith1-1/+1
Apparently some emacsen don't have functions like `fourth` etc. Change-Id: I3d8b698685ce3b1757b427b32d8e27938cc26661
2021-11-20 r/3075 feat(tvl.el): Add magit-gerrit-checkout commandGriffin Smith1-1/+57
Add a new magit-gerrit-checkout command, which prompts for a CL number then fetches and checks out the latest patchset of that CL with a detached HEAD. Change-Id: I88b8209d40017479d97ed40ecbd5fd1ccd7cf650 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3880 Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2021-08-24 r/2764 fix(tvl.el): Fix compilation warningsVincent Ambo1-5/+8
This fixes all compilation warnings except the one about 'tvl lacking a parent group, which we can look into later (it doesn't matter that much). Change-Id: Iaff5e7f5f251f0670afb0a47031ccf197de69818 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3408 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-08-17 r/2746 feat(tvl.el): Make target branch configurableGriffin Smith1-4/+9
I'm using gerrit at work now, and would like to use tvl.el to interact with it via Emacs, but we use a different default branch than "canon". This makes it configurable, and also marks it as safe so I can configure it in .dir-locals.el Change-Id: I66d4c7ce94351f2df863ec49dbc3e1d1d6d1547a Reviewed-on: https://cl.tvl.fyi/c/depot/+/3369 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-06 r/1225 refactor(tvl.el): Don't submit on rubberstampGriffin Smith1-2/+2
Now that we're requiring CI to verify all changes (yay) it's not actually possible to push and submit in one go - this repurposes the rubberstamp command to push and self-+2, which is still useful for self-owned things like system config etc. Change-Id: Ie064adb6b7b0c1fd6bffdf4583a201ea02d4f8ac Reviewed-on: https://cl.tvl.fyi/c/depot/+/939 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-06-25 r/1081 feat(tvl.el): Add push-wip commandGriffin Smith1-0/+11
P W, to push as a work-in-progress CL Change-Id: Ibc6973512e8dcd3ce77b2f1064906a98e9a3a182 Reviewed-on: https://cl.tvl.fyi/c/depot/+/575 Reviewed-by: tazjin <mail@tazj.in>
2020-06-24 r/1074 fix(tvl.el): Use 'canon' branch instead of 'master'Vincent Ambo1-3/+3
Change-Id: I779c3c979cc21a428188d31b399fd8ba97017f8d Reviewed-on: https://cl.tvl.fyi/c/depot/+/567 Reviewed-by: glittershark <grfn@gws.fyi>
2020-06-19 r/1040 feat(emacs-pkgs/tvl): Add #'tvl-depot-status functionVincent Ambo1-0/+9
This function opens the depot in magit. By default the depot path is assumed to be `/depot`, but that is made available as a customise option that users can override. Change-Id: Iefc127cad515dbae330d7af3aa69a0c53aa02015 Reviewed-on: https://cl.tvl.fyi/c/depot/+/504 Reviewed-by: glittershark <grfn@gws.fyi>
2020-06-19 r/1039 feat(emacs-pkgs/tvl): Add magit shortcuts for reviews & coVincent Ambo1-8/+47
Introduces two new shortcuts in the magit popup for pushing: * R: Push for review * S: Push to submit The existing "P" command remains, but has been renamed to "rubberstamp" and documented with a warning. To make this work across people's different setups, customisation options for TVL-specific code are being added. Change-Id: I48e75db55b5f793342fc898093629e437f58dcb2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/503 Reviewed-by: glittershark <grfn@gws.fyi>
2020-06-19 r/1036 feat(emacs-packages/tvl): Init with magit gerrit suffixGriffin Smith1-0/+32
Add a simple tvl.el, with only one magit transient command to push and submit in one go to Gerrit Change-Id: If02065797a8db39669b85acf87a1c4b43d1482ee Reviewed-on: https://cl.tvl.fyi/c/depot/+/494 Reviewed-by: tazjin <mail@tazj.in>