about summary refs log tree commit diff
path: root/third_party
AgeCommit message (Collapse)AuthorFilesLines
2020-05-19 r/778 refactor(3p/nix): Make all single-argument constructors explicitVincent Ambo12-31/+31
Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
2020-05-19 r/777 style(3p/nix): Final act in the brace-wrapping sagaVincent Ambo84-1556/+2603
This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-*,readability-braces-around-statements -fix src/*/*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19 r/776 chore(3p/nix): Remove OSX only 'resolve-system-dependencies' toolVincent Ambo4-268/+0
2020-05-19 r/775 style(3p/nix/libstore): Additional if/for bracing fixesVincent Ambo1-7/+11
2020-05-19 r/774 chore(3p/abseil-cpp): Bump version to 20200519-768eb2caVincent Ambo1-3/+3
2020-05-19 r/773 fix(3p/nix/libstore): Fix mistake introduced by bracing changesVincent Ambo1-1/+1
This statement got included in a loop when it shouldn't have been. At least it led to some funny derivation files!
2020-05-19 r/772 style(3p/nix): Add braces around single-line for-loopsVincent Ambo45-142/+426
These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for (\(.+\))\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19 r/771 style(3p/nix): Add braces around single-line conditionalsVincent Ambo97-753/+2223
These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if (\(.+\))\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19 r/770 fix(3p/nix/libexpr): Declare value union types explicitlyVincent Ambo1-43/+59
Previously these structs were declared anonymously inside of the - anonymous - union. This is not actually supported by the C++ standard, but is merely a compiler-specific extension. Unfortunately untangling this required a forward-declaration of the Value type.
2020-05-19 r/769 fix(3p/nix/libexpr): Use noexcept instead of throw()Vincent Ambo1-1/+1
2020-05-19 r/768 fix(3p/nix): Fix incorrectly braced conditionals and loopsVincent Ambo16-61/+62
Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19 r/767 style(3p/nix): Enforce braces around loops and conditionalsVincent Ambo44-298/+661
This change was generated with: fd -e cc -e hh | xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19 r/766 style(3p/nix): Reformat all includes to match new styleVincent Ambo119-106/+298
2020-05-19 r/765 style(3p/nix): Change include formatting config for clang-formatVincent Ambo1-2/+7
Changes the configuration to regroup all includes. The include groups will be (in this order): 1. (in .cc): Include of the corresponding header 2. Includes of C++ standard library headers 3. Includes of other external headers 4. Includes of local headers
2020-05-19 r/763 fix(3p/nix): Set C++ style to "Google" in Emacs localsVincent Ambo2-42/+1
2020-05-19 r/762 refactor(3p/nix/nix-*): Replace logging with glog in binariesVincent Ambo21-168/+120
2020-05-19 r/761 refactor(3p/nix/nix-daemon): Remove activities from protocolVincent Ambo2-112/+27
Removes the activity transfer that was previously nulled out from the daemon protocol completely. This might actually break Nix completely, I haven't tried yet, but that's fine because this will be replaced with gRPC.
2020-05-19 r/760 style(3p/nix/libexpr): Reformat with clang-formatVincent Ambo5-6/+7
2020-05-19 r/759 chore(3p/nix/nix): Remove progress bar implementationVincent Ambo2-455/+0
The progress bar has lots of complexity for little benefit. The previous activity tracking stuff has been deleted as part of the logging refactoring and I am not going to implement support for this again for now.
2020-05-19 r/758 refactor(3p/nix/libexpr): Replace logging.h with glogVincent Ambo8-35/+37
2020-05-19 r/757 refactor(3p/nix/libmain): Replace logging.h with glogVincent Ambo4-98/+58
2020-05-19 r/756 refactor(3p/nix/libstore): Replace logging.h with glogVincent Ambo25-464/+514
2020-05-18 r/755 feat(3p/glog): Update glog versionVincent Ambo2-2/+16
2020-05-18 r/754 refactor(3p/nix/libutil): Replace internal logging library with glogVincent Ambo10-44/+76
2020-05-18 r/753 chore(3p/nix/libutil): Remove logging implementationVincent Ambo3-437/+0
2020-05-17 r/750 feat(3p/nix): Add glog dependencyVincent Ambo6-73/+87
2020-05-17 r/748 chore(3p/nix): Always enable the garbage collectorVincent Ambo4-64/+10
It's unclear why this toggle existed, now it doesn't.
2020-05-17 r/747 fix(3p/nix): Minor fixes to derivationVincent Ambo2-5/+7
* version must be set to use this as the system Nix * missing busybox path is now set * fixed build output names
2020-05-17 r/745 feat(3p/nix): Add new Meson-based derivation for building NixVincent Ambo1-0/+71
This builds the mesonified Nix and is compatible with the depot structure and nix-shell.
2020-05-17 r/744 chore(3p/nix): Remove symlink setup from Meson buildVincent Ambo2-86/+11
This belongs in the derivation itself, IMO.
2020-05-17 r/743 chore(3p): Remove unused dependencies of NixVincent Ambo1-2/+0
2020-05-17 r/742 chore(3p/nix): Remove old build derivationsVincent Ambo3-506/+0
Removes the autotools-based build derivations, in favour of using a simpler build that just wraps Meson.
2020-05-17 r/741 chore(3p/nix): Remove old build system and other miscellaniesVincent Ambo56-4222/+0
There are still remnants of the old build system (for example, the build derivations are not yet updated at all), but we'll get there.
2020-05-17 r/740 style(3p/nix): Reformat project in Google C++ styleVincent Ambo175-34616/+32053
Reformatted with: fd . -e hh -e cc | xargs clang-format -i
2020-05-17 r/739 fix(3p/nix): Fix Meson configuration for libexprVincent Ambo1-40/+3
2020-05-17 r/738 chore(3p/nix): Use packages from depot treeVincent Ambo3-5/+28
2020-05-17 r/737 chore(3p/nix): Clean up libseccomp_depJohn Ericson1-6/+7
(cherry picked from commit b380f75867d48e6af461513d26803b61250d9c80)
2020-05-17 r/736 docs(3p/nix): Clean up descriptions in MesonJohn Ericson2-6/+6
1. Fix that for libsodium 2. Consistently capitalize (cherry picked from commit 12ce28bdf21d1f261132bdefe3dac25b1aab7dcc)
2020-05-17 r/735 fix(3p/nix): non-existent wrapper dependency .found() should be false tooJohn Ericson1-2/+2
(cherry picked from commit 90f9f4aef781fc5c3ead8652fc408a431f480905)
2020-05-17 r/734 chore(3p/nix): Make libsodium an auto dependencyJohn Ericson2-4/+5
This means do autodetection if the user doesn't specify. (cherry picked from commit 1be6ab4d3eb4d6b04c322b9ed0a108c2b5354ec5)
2020-05-17 r/733 feat(3p/nix/build): Add meson & ninja as nativeBuildDepsVincent Ambo1-0/+2
2020-05-17 r/732 refactor(3p/nix): Remove abstractions in HAVE_STRUCT_DIRENT_D_TYPE codeJohn Ericson1-3/+1
(cherry picked from commit 727dc569a7a13b038d550b8c98a79d5928424d9b)
2020-05-17 r/731 feat(3p/nix): meson: Don't look for libraries in lib dirJohn Ericson1-10/+10
1. First of all, this doesn't work in nixpkgs. Per [1], gcc ignores `-L` for purposes of `--print-file-dirs`, which breaks horribly on linux. But if we don't pass extra dirs, meosn first just tries `-l...`, which does work. 2. Even if it did work, `libdir` means where we are installing libs, not where libs are expected to be found. Those are not necessarily the same (again, nixpkgs), and even when they are and non-standard, it is better to use DESTDIR or have a modified toolchain. [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87758 (cherry picked from commit a142164e746644e20f66908c156ca913bef4664f)
2020-05-17 r/730 feat(3p/nix): meson: Define HAVE_STRUCT_DIRENT_D_TYPE macroJohn Ericson1-2/+20
(cherry picked from commit 7ae66bbef5e92f4a0bba49780d8c316f134884f2)
2020-05-17 r/729 chore(3p/nix): Add Meson and Ninja dependenciesJohn Ericson1-1/+1
(cherry picked from commit 3a968f5152d6f65ea3d9fdd36df3c188a4e20e24)
2020-05-17 r/728 chore(3p/nix): more improvementsp01arst0rm2-10/+9
(cherry picked from commit 507d28fd226e018d5927b49b1bd07833cbd49d25)
2020-05-17 r/727 feat(3p/nix): minor improvementsp01arst0rm2-29/+49
(cherry picked from commit f6f7046acfaf90c19c597687d384b491c852b4c6)
2020-05-17 r/726 feat(3p/nix): added meson supportp01arst0rm27-4/+2045
(cherry picked from commit 086a81b7a5bbe1fc022efb5935ff68f6ad71ddaf)
2020-05-17 r/725 feat(third_party/nix): Add clang-format configurationVincent Ambo1-0/+6
2020-05-17 r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'Vincent Ambo737-0/+105390
git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-21T11·06+0000