Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2021-04-03 | r/2421 feat(3p/rust-crates): get dependencies from the depot fix point | sterni | 1 | -1/+3 | |
I think it is good practice to always get dependencies from the depot fix point if they are exposed. The reasoning for this is that if we improve the support for overriding in depot, say by introducing a depot.extend functions or even full blown overlay support, this will already work as expected. Change-Id: Ibb8dffcf32e8f46817a2db2da26139fabdce55bc Reviewed-on: https://cl.tvl.fyi/c/depot/+/2770 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de> | |||||
2021-04-03 | r/2419 chore: move all 3p buildRustCrate derivations to //third_party | sterni | 2 | -0/+276 | |
Profpatsch and me are basically the only users of depot.users.Profpatsch.writers.rustSimple*. To pull in the odd dependency we usually use buildRustCrate which is rather convenient. However we've picked up the bad habit of inlining these in a let somewhere instead of managing them in a more central location although there has been an (unsuccesful) attempt at this in //users/Profpatsch/rust-crates.nix. This CL moves all buildRustCrate based derivations into third_party.rust-crates and deletes any duplicate derivations we have accumulated in the tree. Change-Id: I8f68b95ebd546708e9af07dca36d72dba9ca8c77 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2769 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: Profpatsch <mail@profpatsch.de> |