depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-22	r/803 chore(3p/nix/libexpr): Delete Bindings::sort	Vincent Ambo	1	-3/+0
	This function does nothing anymore since the attributes are always in-order.
2020-05-22	r/802 fix(3p/nix): Update for usage of new attribute set API	Vincent Ambo	2	-13/+16
	The new attribute set API uses the iterators of the btree_map directly. This requires changes in various files because the internals of libexpr are very entangled. This code runs and compiles, but there is a bug causing empty attribute sets to be assigned incorrectly.
2020-05-21	r/795 fix(3p/nix): Compatibility with updated SymbolTable	Vincent Ambo	3	-5/+5
	The functions in SymbolTable have been renamed to match the Google Style guide, and some debug-only functions have been removed.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	11	-45/+51
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	15	-73/+79
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	11	-26/+31
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-19	r/778 refactor(3p/nix): Make all single-argument constructors explicit	Vincent Ambo	2	-4/+4
	Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	20	-132/+240
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	11	-28/+84
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	17	-54/+162
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	3	-12/+13
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	6	-17/+41
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	16	-7/+28

2020-05-19	r/762 refactor(3p/nix/nix-*): Replace logging with glog in binaries	Vincent Ambo	13	-84/+48

2020-05-19	r/759 chore(3p/nix/nix): Remove progress bar implementation	Vincent Ambo	2	-455/+0
	The progress bar has lots of complexity for little benefit. The previous activity tracking stuff has been deleted as part of the logging refactoring and I am not going to implement support for this again for now.
2020-05-17	r/750 feat(3p/nix): Add glog dependency	Vincent Ambo	2	-66/+72

2020-05-17	r/748 chore(3p/nix): Always enable the garbage collector	Vincent Ambo	1	-0/+1
	It's unclear why this toggle existed, now it doesn't.
2020-05-17	r/744 chore(3p/nix): Remove symlink setup from Meson build	Vincent Ambo	1	-75/+0
	This belongs in the derivation itself, IMO.
2020-05-17	r/741 chore(3p/nix): Remove old build system and other miscellanies	Vincent Ambo	1	-25/+0
	There are still remnants of the old build system (for example, the build derivations are not yet updated at all), but we'll get there.
2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	31	-3726/+3314
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/726 feat(3p/nix): added meson support	p01arst0rm	2	-0/+155
	(cherry picked from commit 086a81b7a5bbe1fc022efb5935ff68f6ad71ddaf)
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	32	-0/+4851
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10