about summary refs log tree commit diff
path: root/third_party/nix/src/nix/repl.cc (unfollow)
AgeCommit message (Collapse)AuthorFilesLines
2020-07-10 r/1250 fix(3p/nix/repl): Scan NixRepl for GC rootsEelco Dolstra1-1/+4
Backport of https://github.com/NixOS/nix/commit/b244e65cdbc2949af70bd539bf8f3bd2fa952d07 Fixes https://github.com/NixOS/nix/issues/3175 ------ Original fault description by puck: I suspect I found the issue: The Nix Command structs are stored on the heap (using ref<T>, a wrapper around std::shared_ptr<T>), which means that any pointers that the NixRepl struct contains are eligible to be reaped by the GC. This includes, but is not limited to, the Env pointer, which seems to cause most of the random segfaults, or random other values in the environment, which seems to be what @arianvp experienced too. Change-Id: I376d7cfd432daaa6f1fbbf77788ff048082f34e5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1001 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-10 r/1249 fix(3p/nix/libstore): use exception instead of assertion when storepath is ↵Andreas Rammhold1-2/+11
malformed Previously the nix-daemon would crash if a user fed it invalid store paths for drv files. The crash was due to the changed assertion triggering. Whenever that assertion would hit the nix-daemon process along with all it's current childs (running builds from all users) would be interrupted. Before this patch: $ nix-store --realise /nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.drv don't know how to build these paths: /nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.drv error: unexpected end-of-file < nix-daemon terminates > With this patch: $ nix-store --realise /nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.drv don't know how to build these paths: /nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.drv error: path '/nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.drv' is not a valid store path < nix-daemon does *NOT* terminate > Change-Id: I01c5048c8a43a8b9154bdeb781d05b7744869ec0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/981 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-07-10 r/1248 feat(tvl-slapd): add `andi`Andreas Rammhold1-0/+5
Message-Id: <20200710190623.26573-1-andi@notmuch.email> Change-Id: Ibd74f93f589beecbf7fa9090550ecf95caa0a3b0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/982 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-07-10 r/1247 chore(gerrit): update to 3.2.2Luke Granger-Brown5-8/+8
Change-Id: Ia41e19250f9f900c73904553a931f0f4dde3a5bf Reviewed-on: https://cl.tvl.fyi/c/depot/+/860 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: isomer <isomer@tvl.fyi>
2020-07-10 r/1246 feat(3p/nix): Add additional worker protocol actions to protoVincent Ambo1-4/+114
This takes us about halfway through worker-protocol.hh I have left out the documentation strings for some of these items because I don't feel that I can currently write an unambigous description of them. For now I am just attempting to match the types. Change-Id: Iae64b1676152fe4ea069e2021b75ad76465cf368 Reviewed-on: https://cl.tvl.fyi/c/depot/+/960 Tested-by: BuildkiteCI Reviewed-by: isomer <isomer@tvl.fyi>
2020-07-09 r/1245 docs(3p/nix): Update links & other things in READMEVincent Ambo1-8/+8
Change-Id: I1a111c11a83f0506e0973615848cc9c0ef4765e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/959 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-07-09 r/1244 fix(gs/emacs): Trim input strings for ERCGriffin Smith1-0/+2
I send a lot of accidental newlines after messages because my muscle memory is very intent on hitting "o" to get into insert mode. Change-Id: Iecd469d1d8d2053e68837b3b65399cb272d7fc29 Reviewed-on: https://cl.tvl.fyi/c/depot/+/958 Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-08 r/1243 feat(tazjin/camden): Configure Quassel core instanceVincent Ambo1-0/+16
I'm not actually sure if this will apply cleanly, because the new NixOS ACME module is kind of broken. Change-Id: I39584333dbea0a5f7b72e68d5e9f752a4c31bfe6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/957 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-08 r/1242