depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	1	-27/+37
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	1	-23/+24
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-20	r/780 chore(third_party/nix): Dump of minor accumulated changes	Vincent Ambo	1	-0/+1
	None of these are worthy of a specific commit, or even have a real reason behind them, but I didn't want to lose them.
2020-05-19	r/778 refactor(3p/nix): Make all single-argument constructors explicit	Vincent Ambo	1	-3/+3
	Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	1	-46/+74
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	1	-4/+12
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-23/+69
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	1	-2/+1
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	1	-10/+20
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-2/+4

2020-05-19	r/761 refactor(3p/nix/nix-daemon): Remove activities from protocol	Vincent Ambo	1	-55/+26
	Removes the activity transfer that was previously nulled out from the daemon protocol completely. This might actually break Nix completely, I haven't tried yet, but that's fine because this will be replaced with gRPC.
2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-905/+861
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+1149
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10