depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-24	r/842 chore(3p/nix/libstore): Remove progress bar remnants from download	Vincent Ambo	1	-19/+0

2020-05-24	r/840 style(3p/nix): Remove 'using std::*' from types.hh	Vincent Ambo	34	-326/+336
	It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes.
2020-05-24	r/835 refactor(3p/nix/libutil): Replace chomp() with absl::strings	Vincent Ambo	5	-7/+16

2020-05-24	r/834 chore(3p/nix): Remove some OS X specific defines	Vincent Ambo	5	-226/+2
	This project will be dropping OS X support until the core is simplified.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	23	-76/+85
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	31	-300/+308
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	24	-141/+158
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-20	r/780 chore(third_party/nix): Dump of minor accumulated changes	Vincent Ambo	1	-18/+0
	None of these are worthy of a specific commit, or even have a real reason behind them, but I didn't want to lose them.
2020-05-19	r/778 refactor(3p/nix): Make all single-argument constructors explicit	Vincent Ambo	8	-18/+18
	Implicit constructors can be confusing, especially in a codebase that is already as unintentionally obfuscated as this one. https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	28	-527/+954
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/775 style(3p/nix/libstore): Additional if/for bracing fixes	Vincent Ambo	1	-7/+11

2020-05-19	r/773 fix(3p/nix/libstore): Fix mistake introduced by bracing changes	Vincent Ambo	1	-1/+1
	This statement got included in a loop when it shouldn't have been. At least it led to some funny derivation files!
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	13	-44/+132
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	30	-289/+861
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	1	-2/+1
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	12	-67/+138
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	39	-36/+103

2020-05-19	r/761 refactor(3p/nix/nix-daemon): Remove activities from protocol	Vincent Ambo	1	-57/+1
	Removes the activity transfer that was previously nulled out from the daemon protocol completely. This might actually break Nix completely, I haven't tried yet, but that's fine because this will be replaced with gRPC.
2020-05-19	r/756 refactor(3p/nix/libstore): Replace logging.h with glog	Vincent Ambo	23	-462/+489

2020-05-17	r/741 chore(3p/nix): Remove old build system and other miscellanies	Vincent Ambo	1	-60/+0
	There are still remnants of the old build system (for example, the build derivations are not yet updated at all), but we'll get there.
2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	57	-14059/+13341
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/726 feat(3p/nix): added meson support	p01arst0rm	2	-1/+171
	(cherry picked from commit 086a81b7a5bbe1fc022efb5935ff68f6ad71ddaf)
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	63	-0/+18019
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10