depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-08-06	r/1613 fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit	Kane York	1	-8/+12
	The behavior to return a list containing a single empty string when provided an empty string is a behavior that absl inherited from legacy code. However, the behavior expected by legacy code in Nix is the behavior provided by the SkipEmpty option. Switch all calls to use SkipEmpty, except for the call already using SkipWhitespace. See also commit 26a59482d2427f640893517f1b24dd650a5bd5da, with the partly-prophetic message: "there may be other places we need to fix this as well." Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-05-27	r/865 refactor(3p/nix): Anchor local includes at src/	Vincent Ambo	1	-3/+3
	Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes.
2020-05-25	r/846 refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit	Vincent Ambo	1	-8/+12
	This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function.
2020-05-25	r/845 refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil	Vincent Ambo	1	-3/+5
	Uses the equivalent absl::StartsWith and absl::EndsWith functions instead.
2020-05-25	r/843 refactor(3p/nix/libutil): Replace string2Int & trim functions	Vincent Ambo	1	-2/+3
	Replaces these functions with corresponding functions from Abseil, namely absl::StripAsciiWhitespace and absl::SimpleAtoi. In the course of doing this some minor things I encountered along the way were also refactored. This also changes the signatures of the various custom readFile functions to use absl::string_view types.
2020-05-24	r/840 style(3p/nix): Remove 'using std::*' from types.hh	Vincent Ambo	1	-12/+12
	It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	1	-6/+6
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	1	-3/+3
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-1/+3
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-1/+4

2020-05-19	r/756 refactor(3p/nix/libstore): Replace logging.h with glog	Vincent Ambo	1	-3/+8

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-81/+74
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+100
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10