depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-27	r/865 refactor(3p/nix): Anchor local includes at src/	Vincent Ambo	1	-7/+7
	Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes.
2020-05-25	r/846 refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit	Vincent Ambo	1	-7/+11
	This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function.
2020-05-25	r/845 refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil	Vincent Ambo	1	-1/+3
	Uses the equivalent absl::StartsWith and absl::EndsWith functions instead.
2020-05-24	r/840 style(3p/nix): Remove 'using std::*' from types.hh	Vincent Ambo	1	-29/+31
	It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	1	-2/+2
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	1	-7/+8
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	1	-1/+1
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	1	-12/+22
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/775 style(3p/nix/libstore): Additional if/for bracing fixes	Vincent Ambo	1	-7/+11

2020-05-19	r/773 fix(3p/nix/libstore): Fix mistake introduced by bracing changes	Vincent Ambo	1	-1/+1
	This statement got included in a loop when it shouldn't have been. At least it led to some funny derivation files!
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	1	-3/+9
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	1	-8/+11
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-0/+1

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-327/+314
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+416
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10