depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-21	r/795 fix(3p/nix): Compatibility with updated SymbolTable	Vincent Ambo	15	-122/+126
	The functions in SymbolTable have been renamed to match the Google Style guide, and some debug-only functions have been removed.
2020-05-21	r/794 refactor(3p/nix/libexpr): Use absl::node_hash_set in SymbolTable	Vincent Ambo	3	-32/+39
	This replaces the previous use of std::unordered_set with absl::node_hash_set. This type was chosen because the current implementation requires pointer stability. This does not yet touch the 'Attr' struct. As a bonus, the implementation of the SymbolTable struct is now consolidated into a single header/implementation file pair.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	7	-9/+10
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	9	-120/+130
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	8	-33/+36
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	11	-225/+382
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	11	-25/+75
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	15	-120/+332
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/770 fix(3p/nix/libexpr): Declare value union types explicitly	Vincent Ambo	1	-43/+59
	Previously these structs were declared anonymously inside of the - anonymous - union. This is not actually supported by the C++ standard, but is merely a compiler-specific extension. Unfortunately untangling this required a forward-declaration of the Value type.
2020-05-19	r/769 fix(3p/nix/libexpr): Use noexcept instead of throw()	Vincent Ambo	1	-1/+1

2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	9	-39/+40
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	12	-154/+339
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	26	-12/+50

2020-05-19	r/760 style(3p/nix/libexpr): Reformat with clang-format	Vincent Ambo	5	-6/+7

2020-05-19	r/758 refactor(3p/nix/libexpr): Replace logging.h with glog	Vincent Ambo	8	-35/+37

2020-05-17	r/748 chore(3p/nix): Always enable the garbage collector	Vincent Ambo	1	-0/+1
	It's unclear why this toggle existed, now it doesn't.
2020-05-17	r/741 chore(3p/nix): Remove old build system and other miscellanies	Vincent Ambo	1	-33/+0
	There are still remnants of the old build system (for example, the build derivations are not yet updated at all), but we'll get there.
2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	31	-6304/+5888
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/739 fix(3p/nix): Fix Meson configuration for libexpr	Vincent Ambo	1	-40/+3

2020-05-17	r/726 feat(3p/nix): added meson support	p01arst0rm	1	-0/+130
	(cherry picked from commit 086a81b7a5bbe1fc022efb5935ff68f6ad71ddaf)
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	35	-0/+9111
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10