depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-07-27	r/1495 fix(3p/nix): apply all clang-tidy fixes	Kane York	1	-8/+12
	Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-05-27	r/865 refactor(3p/nix): Anchor local includes at src/	Vincent Ambo	1	-5/+5
	Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes.
2020-05-25	r/846 refactor(3p/nix): Replace tokenizeStrings with absl::StrSplit	Vincent Ambo	1	-6/+8
	This function was a custom (and inefficient in the case of single-character delimiters) string splitter which was used all over the codebase. Abseil provides an appropriate replacement function.
2020-05-25	r/845 refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil	Vincent Ambo	1	-3/+4
	Uses the equivalent absl::StartsWith and absl::EndsWith functions instead.
2020-05-24	r/835 refactor(3p/nix/libutil): Replace chomp() with absl::strings	Vincent Ambo	1	-1/+3

2020-05-22	r/803 chore(3p/nix/libexpr): Delete Bindings::sort	Vincent Ambo	1	-2/+2
	This function does nothing anymore since the attributes are always in-order.
2020-05-22	r/802 fix(3p/nix): Update for usage of new attribute set API	Vincent Ambo	1	-1/+2
	The new attribute set API uses the iterators of the btree_map directly. This requires changes in various files because the internals of libexpr are very entangled. This code runs and compiles, but there is a bug causing empty attribute sets to be assigned incorrectly.
2020-05-21	r/797 refactor(3p/nix/libexpr): Use std::string as qualified type	Vincent Ambo	1	-2/+2
	Replaces most uses of `string` with `std::string`. This came up because I removed the "types.hh" import from "symbol-table.hh", which percolated through a bunch of files where `string` was suddenly no longer defined ... sigh
2020-05-21	r/795 fix(3p/nix): Compatibility with updated SymbolTable	Vincent Ambo	1	-4/+4
	The functions in SymbolTable have been renamed to match the Google Style guide, and some debug-only functions have been removed.
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-2/+6
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	1	-2/+1
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	1	-2/+4
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-2/+4

2020-05-19	r/760 style(3p/nix/libexpr): Reformat with clang-format	Vincent Ambo	1	-1/+2

2020-05-19	r/758 refactor(3p/nix/libexpr): Replace logging.h with glog	Vincent Ambo	1	-5/+4

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-166/+176
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+219
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10