depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-05-23	r/829 fix(3p/nix/libexpr): Ensure ExprOpUpdate merges into destination	Vincent Ambo	1	-17/+5
	... this fixes nixpkgs eval!
2020-05-23	r/825 docs(3p/nix/libexpr): Add some comments about function calls	Vincent Ambo	1	-4/+8
	These were things that took me a moment to realise.
2020-05-23	r/821 fix(3p/nix/libexpr): Remove the global empty attribute set	Vincent Ambo	1	-4/+0
	In the change to the backing structure of attribute sets, the requirement to manually balance the capacity of the structure went away. This is a) because Abseil's data structures manage this on their own, and b) because the new Bindings class is allocated using `new (GC)` rather than writing into a predefined memory area. As part of this change functions related to the capacity were deprecated and set to 0 values, which in turn caused the creation of new attribute sets to return the same (mutable!) default value in various cases, leading to "side effects" that caused evaluation failures. FWIW, I'm not sure if this optimisation had noticeable performance impact, but while untangling libexpr it definitely doesn't help trying to follow what it's doing - so bye, bye!
2020-05-23	r/820 chore(3p/nix/libexpr): Minor readability improvements in eval/value	Vincent Ambo	1	-2/+2

2020-05-23	r/819 chore(3p/nix/libexpr): Remove unused __overrides feature	Vincent Ambo	1	-47/+11
	This feature does not appear in nixpkgs, so I don't care about it. My only goal is evaluating nixpkgs.
2020-05-22	r/806 refactor(3p/nix/libexpr): Use gc_cpp to allocate Value instances	Vincent Ambo	1	-20/+4

2020-05-22	r/805 refactor(3p/nix/libexpr): state->allocBindings -> Bindings::NewGC	Vincent Ambo	1	-2/+2
	EvalState::allocBindings had little to do with Bindings, other than returning them, and didn't belong in that class.
2020-05-22	r/803 chore(3p/nix/libexpr): Delete Bindings::sort	Vincent Ambo	1	-10/+1
	This function does nothing anymore since the attributes are always in-order.
2020-05-22	r/802 fix(3p/nix): Update for usage of new attribute set API	Vincent Ambo	1	-31/+33
	The new attribute set API uses the iterators of the btree_map directly. This requires changes in various files because the internals of libexpr are very entangled. This code runs and compiles, but there is a bug causing empty attribute sets to be assigned incorrectly.
2020-05-22	r/800 refactor(3p/nix/libexpr): Use absl::btree_map::merge for '//'	Vincent Ambo	1	-22/+3
	Instead of doing some sort of inline merge-sort of the two attribute sets, use the attribute sets merge function. This commit alone does not build and is not supposed to.
2020-05-21	r/799 refactor(3p/nix/libexpr): Use absl::btree_map for AttrSets	Vincent Ambo	1	-6/+10
	This is the first step towards replacing the implementation of attribute sets with an absl::btree_map. Currently many access are done using array offsets and pointer arithmetic, so this change is currently causing Nix to fail in various ways.
2020-05-21	r/797 refactor(3p/nix/libexpr): Use std::string as qualified type	Vincent Ambo	1	-29/+34
	Replaces most uses of `string` with `std::string`. This came up because I removed the "types.hh" import from "symbol-table.hh", which percolated through a bunch of files where `string` was suddenly no longer defined ... sigh
2020-05-21	r/795 fix(3p/nix): Compatibility with updated SymbolTable	Vincent Ambo	1	-38/+39
	The functions in SymbolTable have been renamed to match the Google Style guide, and some debug-only functions have been removed.
2020-05-20	r/789 refactor(3p/nix): Apply clang-tidy's performance-* fixes	Vincent Ambo	1	-1/+1
	This applies the performance fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	1	-43/+45
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	1	-12/+13
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	1	-55/+100
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	1	-9/+27
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-33/+99
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/768 fix(3p/nix): Fix incorrectly braced conditionals and loops	Vincent Ambo	1	-12/+6
	Fixes mistakes introduced by clang-tidy in the previous commit.
2020-05-19	r/767 style(3p/nix): Enforce braces around loops and conditionals	Vincent Ambo	1	-49/+105
	This change was generated with: fd -e cc -e hh \| xargs -I{} clang-tidy {} -p ~/projects/nix-build/ \ --checks='-*,readability-braces-around-statements' --fix \ -fix-errors Some manual fixes were applied because some convoluted unbraced statements couldn't be untangled by clang-tidy. This commit still includes invalid files, but I decided to clean them up in a subsequent commit so that it becomes more obvious where clang-tidy failed. Maybe this will allow for a bug-report to clang-tidy.
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-4/+7

2020-05-19	r/760 style(3p/nix/libexpr): Reformat with clang-format	Vincent Ambo	1	-1/+1

2020-05-19	r/758 refactor(3p/nix/libexpr): Replace logging.h with glog	Vincent Ambo	1	-5/+5

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-1604/+1461
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+1991
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10