depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-07-04	r/1206 chore(3p/nix/libexpr): Remove dead code from attribute sets	Vincent Ambo	1	-14/+1
	These bits are no longer required with the hashmap-backed implementation of attribute sets. Change-Id: I8b936d8d438a00bad4ccf8e0b4dd719c559ce8c2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/912 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu>
2020-05-27	r/865 refactor(3p/nix): Anchor local includes at src/	Vincent Ambo	1	-3/+3
	Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes.
2020-05-23	r/828 refactor(3p/nix/libexpr): Make other 'const' in Bindings::merge	Vincent Ambo	1	-1/+1

2020-05-23	r/827 fix(3p/nix/libexpr): Actually use AttributeMap type alias	Vincent Ambo	1	-2/+2
	Without this alias, the garbage-collecting allocator won't be used and allocated attribute set values won't be visible during GC.
2020-05-23	r/820 chore(3p/nix/libexpr): Minor readability improvements in eval/value	Vincent Ambo	1	-1/+1

2020-05-23	r/818 chore(3p/nix/libexpr): Expose separate insert & "upsert" methods	Vincent Ambo	1	-2/+4
	Reading more through the old code, it seems like the intention /sometimes/ is to replace values.
2020-05-22	r/817 fix(3p/nix/libexpr): Use gc_allocator<T> as the btree_map allocator	Vincent Ambo	1	-1/+8
	This will make all Attr values visible to the GC.
2020-05-22	r/805 refactor(3p/nix/libexpr): state->allocBindings -> Bindings::NewGC	Vincent Ambo	1	-0/+4
	EvalState::allocBindings had little to do with Bindings, other than returning them, and didn't belong in that class.
2020-05-22	r/803 chore(3p/nix/libexpr): Delete Bindings::sort	Vincent Ambo	1	-3/+0
	This function does nothing anymore since the attributes are always in-order.
2020-05-22	r/801 refactor(3p/nix/libexpr): Use absl::btree_map::iterator type	Vincent Ambo	1	-1/+2
	Instead of using a custom Args* iterator, use the one belonging to the map type directly.
2020-05-22	r/800 refactor(3p/nix/libexpr): Use absl::btree_map::merge for '//'	Vincent Ambo	1	-0/+3
	Instead of doing some sort of inline merge-sort of the two attribute sets, use the attribute sets merge function. This commit alone does not build and is not supposed to.
2020-05-21	r/799 refactor(3p/nix/libexpr): Use absl::btree_map for AttrSets	Vincent Ambo	1	-49/+34
	This is the first step towards replacing the implementation of attribute sets with an absl::btree_map. Currently many access are done using array offsets and pointer arithmetic, so this change is currently causing Nix to fail in various ways.
2020-05-21	r/797 refactor(3p/nix/libexpr): Use std::string as qualified type	Vincent Ambo	1	-3/+4
	Replaces most uses of `string` with `std::string`. This came up because I removed the "types.hh" import from "symbol-table.hh", which percolated through a bunch of files where `string` was suddenly no longer defined ... sigh
2020-05-19	r/772 style(3p/nix): Add braces around single-line for-loops	Vincent Ambo	1	-1/+3
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'for ($.+$)\s([a-z].*;)' 'for $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-1/+3
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-0/+1

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-76/+61
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+95
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10