depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-07-20	r/1408 chore(3p/nix): Remove support for plugins	Griffin Smith	1	-2/+0
	Plugins seem to not really be used anywhere (I can find one plugin that's actually defined, and it doesn't seem very useful, especially since we got rid of builtins.exec) and their presence is adding additional complexity and potential sources of bugs to an already unsteady refactor. At some point we may want to bring back something like plugins, but their design will likely be different and it will definitely be after we have a functioning Nix again. Change-Id: I3bc40e55917f70bf260fbc208c1705e2e6a7c626 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1291 Tested-by: BuildkiteCI Reviewed-by: Alyssa Ross <hi@alyssa.is> Reviewed-by: isomer <isomer@tvl.fyi>
2020-05-27	r/865 refactor(3p/nix): Anchor local includes at src/	Vincent Ambo	1	-9/+9
	Previously all includes were anchored in one global mess of header files. This moves the includes into filesystem "namespaces" (if you will) for each sub-package of Nix. Note: This commit does not introduce the relevant build system changes.
2020-05-25	r/845 refactor(3p/nix/libutil): Replace hasPrefix/Suffix with Abseil	Vincent Ambo	1	-1/+2
	Uses the equivalent absl::StartsWith and absl::EndsWith functions instead.
2020-05-24	r/840 style(3p/nix): Remove 'using std::*' from types.hh	Vincent Ambo	1	-3/+3
	It is considered bad form to use things from includes in headers, as these directives propagate to everywhere else and can make it confusing. types.hh (which is includes almost literally everywhere) had some of these directives, which this commit removes.
2020-05-24	r/835 refactor(3p/nix/libutil): Replace chomp() with absl::strings	Vincent Ambo	1	-2/+5

2020-05-24	r/834 chore(3p/nix): Remove some OS X specific defines	Vincent Ambo	1	-7/+0
	This project will be dropping OS X support until the core is simplified.
2020-05-20	r/788 refactor(3p/nix): Apply clang-tidy's readability-* fixes	Vincent Ambo	1	-4/+4
	This applies the readability fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html
2020-05-20	r/787 refactor(3p/nix): Apply clang-tidy's modernize-* fixes	Vincent Ambo	1	-1/+1
	This applies the modernization fixes listed here: https://clang.llvm.org/extra/clang-tidy/checks/list.html The 'modernize-use-trailing-return-type' fix was excluded due to my personal preference (more specifically, I think the 'auto' keyword is misleading in that position).
2020-05-20	r/780 chore(third_party/nix): Dump of minor accumulated changes	Vincent Ambo	1	-1/+1
	None of these are worthy of a specific commit, or even have a real reason behind them, but I didn't want to lose them.
2020-05-19	r/777 style(3p/nix): Final act in the brace-wrapping saga	Vincent Ambo	1	-6/+11
	This last change set was generated by a full clang-tidy run (including compilation): clang-tidy -p ~/projects/nix-build/ \ -checks=-,readability-braces-around-statements -fix src//*.cc Actually running clang-tidy requires some massaging to make it play nice with Nix + meson, I'll be adding a wrapper or something for that soon.
2020-05-19	r/771 style(3p/nix): Add braces around single-line conditionals	Vincent Ambo	1	-4/+12
	These were not caught by the previous clang-tidy invocation, but were instead sorted out using amber[0] as such: ambr --regex 'if ($.+$)\s([a-z].*;)' 'if $1 { $2 }' [0]: https://github.com/dalance/amber
2020-05-19	r/766 style(3p/nix): Reformat all includes to match new style	Vincent Ambo	1	-1/+2

2020-05-19	r/762 refactor(3p/nix/nix-*): Replace logging with glog in binaries	Vincent Ambo	1	-19/+13

2020-05-17	r/740 style(3p/nix): Reformat project in Google C++ style	Vincent Ambo	1	-201/+210
	Reformatted with: fd . -e hh -e cc \| xargs clang-format -i
2020-05-17	r/724 Add 'third_party/nix/' from commit 'be66c7a6b24e3c3c6157fd37b86c7203d14acf10'	Vincent Ambo	1	-0/+266
	git-subtree-dir: third_party/nix git-subtree-mainline: cf8cd640c1adf74a3706efbcb0ea4625da106fb2 git-subtree-split: be66c7a6b24e3c3c6157fd37b86c7203d14acf10