about summary refs log tree commit diff
path: root/third_party/gerrit (follow)
AgeCommit message (Collapse)AuthorFilesLines
2020-08-02 r/1536 chore(gerrit): Update to latest HEAD.Luke Granger-Brown1-5/+4
Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6786 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1516 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-01 r/1522 fix(gerrit): Don't do a deep fetchLuke Granger-Brown1-4/+2
I don't know what I was smoking. Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6781 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1514 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-27 r/1488 chore(3p/gerrit_plugins): add machinery for compiling Gerrit plugins from sourceLuke Granger-Brown1-3/+3
This looks particularly obnoxious for the owners plugin, because it's actually two plugins with a common library in the same repo. Other plugins are much cleaner to deal with (hence the default for overlayPluginCmd). Change-Id: Ibb9588c8a29b63e8509436fcbb70054e89349712 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1461 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-26 r/1479 fix(gerrit): fix hovercards under FirefoxLuke Granger-Brown8-6/+42
Firefox doesn't implement the IE6 fromElement/toElement, and it's not in the MouseEvent spec (at the moment). Replace with the worse-named but better-specified target and relatedTarget attributes instead. Upstream change: https://gerrit-review.googlesource.com/q/I9eeb26c032a38de9d7185749373c7982c796acb2 Change-Id: I9f9a1eb9342bc80b91b5b364a04cc5fa9a7ccaeb Reviewed-on: https://cl.tvl.fyi/c/depot/+/1442 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-25 r/1474 chore(gerrit): update to 3.2.2-1002-gea26b5ee7aLuke Granger-Brown7-20/+22
This is the version currently (2020-07-25) deployed on https://gerrit-review.googlesource.com/, and includes features such as The Attention Set. Change-Id: Idf29f96c38d7737efb0d64c4cd294dab46fe5412 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1437 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-11 r/1252 fix(gerrit): Load fonts from Google Fonts instead.Luke Granger-Brown7-12/+68
This also incidentally includes a fix for _not_ loading fonts from Google Fonts, but I don't really care about that. Change-Id: I6e00791d0ba06cb1e3c029e1b8617c33000d2ab1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1041 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-10 r/1247 chore(gerrit): update to 3.2.2Luke Granger-Brown5-8/+8
Change-Id: Ia41e19250f9f900c73904553a931f0f4dde3a5bf Reviewed-on: https://cl.tvl.fyi/c/depot/+/860 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: isomer <isomer@tvl.fyi>
2020-07-03 r/1199 fix(gerrit): return HTML titles in more casesLuke Granger-Brown5-11/+64
At present, we don't return HTML titles if there's a trailing slash, or a patchset. Instead, just consume the / and anything after it. This also fixes /123, because this is HTTP redirected to the full path *with a trailing slash* which otherwise wouldn't get the title injected. Change-Id: Idfd0e67752880a37dce0b400a3c1cfc53fac2912 Reviewed-on: https://cl.tvl.fyi/c/depot/+/859 Reviewed-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-06-14 r/956 feat(gerrit): Add CL titles to title tags if accessing a CL or patchset.Luke Granger-Brown2-0/+201
Fine, puck, you win. Change-Id: I47fe8ea6662132f5c337e1e73281dbeca19a414c Reviewed-on: https://cl.tvl.fyi/c/depot/+/321 Reviewed-by: tazjin <mail@tazj.in>
2020-06-14 r/955 fix(3p/gerrit): Fix Gerrit derivation name and module configurationVincent Ambo1-1/+1
Without these changes, the NixOS module isn't able to use the new Gerrit derivation. These changes are already deployed as I needed to make them to get Gerrit back up. Change-Id: Iad3aa6158789a014134fddccd40b508b81486100 Reviewed-on: https://cl.tvl.fyi/c/depot/+/301 Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-06-14 r/952 feat(gerrit): Syntax highlight rules.pl as Prolog.Luke Granger-Brown2-0/+33
This adds support for overriding the detected languages based on the filename - we assume here that rules.pl will always map to a Prolog file. I could've overridden the entire default language to Prolog, since it's unlikely that we'll have any Perl here, but given the relative popularity of the two languages I opted to just override the file we know we'll have (because it's used by Gerrit itself). https://usercontent.irccloud-cdn.com/file/yhZZx1nd/highlighted_prolog.png Change-Id: I26a7e6dab191e0b80a027b026f884020a1f07178 Reviewed-on: https://cl.tvl.fyi/c/depot/+/254 Reviewed-by: tazjin <mail@tazj.in>
2020-06-14 r/951 feat(gerrit): Syntax highlight .nix files.Luke Granger-Brown2-1/+16
highlight.js supports syntax highlighting .nix files, but the Gerrit diff components doesn't map the .nix mimetype onto the nix language. .nix appears to already be taken by another mimetype that isn't Nix-related, but we just map that onto nix anyway. https://usercontent.irccloud-cdn.com/file/AVhoPvrb/highlighted.png Change-Id: I842b29c78355e5bec580e711e25d693284ab6f59 Reviewed-on: https://cl.tvl.fyi/c/depot/+/253 Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: q3k <q3k@q3k.org>
2020-06-14 r/948 feat(gerrit): Create Gerrit derivation.Luke Granger-Brown2-0/+163
This uses the actual Bazel build, using a variety of tricks and hacks to make it actually work. Bazel really wants to download linux binaries from the internet and run them. In lieu of trying to fix the build system to not do this, we instead put bazel inside an FHS environment, which allows the binaries to find their dependencies. We also have to patch a few things: * We use build --nobuild instead of fetch, so we only fetch the dependencies we actually need for the build and not, say, Windows binaries. * We don't remove rules_cc, because we need it as an external dependency, not bundled. * We do some manual fixes on the cache before packing, because we need to remove some in-tree sources (so they don't cause the hash to break, since the hashes differ each time they're generated), and also remove some extraneous files. * We explicitly turn off the repository and disk caches, because the .bazelrc at the root of the Gerrit tree turns them on, with paths pointing into the user's home directory. * detzip is used instead of the zip binary for packing bower_components into an archive. detzip doesn't create entries for directories, and also doesn't store most metadata (timestamps, etc.), and uses store (i.e. uncompressed) compression only. It also sorts the file tree before writing them into the file. Change-Id: I572c43f7175067ecb1b85cdf40dda13a52de1439 Reviewed-on: https://cl.tvl.fyi/c/depot/+/252 Reviewed-by: tazjin <mail@tazj.in>
2020-06-14 r/946 feat(gerrit): Create detzip, a small helper utility for packing zips ↵Luke Granger-Brown1-0/+97
determinstically. detzip will be used in a patch for the Gerrit bower repository helper, which allows us to get consistent hashes for the output of fetching the dependencies for the Bazel build. Change-Id: I6c87b19815b9d747064108aecbb57ed875d2623b Reviewed-on: https://cl.tvl.fyi/c/depot/+/251 Reviewed-by: lukegb <lukegb@tvl.fyi>