about summary refs log tree commit diff
path: root/third_party/gerrit/default.nix
AgeCommit message (Collapse)AuthorFilesLines
2024-07-08 r/8359 chore(3p/gerrit): downgrade mina SSHd againLuke Granger-Brown1-3/+1
This breaks it with "ssh_dispatch_run_fatal: Connection to 2a01:4f8:242:5b21:0:feed:edef:beef port 29418: incorrect signature" Change-Id: I9bafc5fb6d4743ce4f097158ec14fecc791366ca Reviewed-on: https://cl.tvl.fyi/c/depot/+/11965 Tested-by: BuildkiteCI Autosubmit: lukegb <lukegb@tvl.fyi> Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: lukegb <lukegb@tvl.fyi>
2024-07-08 r/8358 chore(3p/gerrit): create buildBazelPackageNG and migrate gerrit to itLuke Granger-Brown1-114/+63
This bumps Gerrit to 3.10.0, and also introduces a new mechanism for building it that should hopefully have some more stable hashes than the previous bodgery. In this world, we only cache what we explicitly want to. There are some hooks implemented for `rules_java` and `rules_nodejs` (before version 6) that force use of local binaries; this means we can drop the use of the FHSUserEnv and use the java and nodejs binaries provided by nixpkgs instead. detzip is deleted; it hasn't been used in yonks. We also add https://gerrit-review.googlesource.com/c/gerrit/+/431977, which bumps the SSHd version so that we can have U2F-based SSH keys. Change-Id: Ie12a9a33bbb1e4bd96aa252580aca3b8bc4a1205 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11963 Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2024-02-12 r/7503 chore(3p/gerrit): 3.8.2 -> 3.9.1Luke Granger-Brown1-6/+6
Change-Id: I8fa10b52c44bd3d5efb0fff740ad6d5da6e96831 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10802 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2023-10-16 r/6821 chore(3p/gerrit): 3.7.0-rc4 -> 3.8.2Luke Granger-Brown1-6/+6
Bump gerrit plugins dep hashes, and for code-owners rebase it against master. Change-Id: If7da0ca391b4a5c0102560ca8d52b6f5a2dfd223 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9734 Autosubmit: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2023-07-03 r/6389 fix(3p/gerrit): mangle the gerrit fetch impure FOD sha256 againAlain Zscheile1-1/+1
Change-Id: I82314aa0f0fd4b0f33dc26f587a8121fd2d7c036 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8921 Reviewed-by: zseri <zseri.devel@ytrizja.de> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2023-04-26 r/6113 refactor(3p/gerrit*): make deps tarball a subtargetsterni1-0/+2
This should make the canon pipeline gcroot the deps tarball, making it less likely to be garbage-collected and rebuilt unnecessarily (which usually incurs a hash change due to impurities). Change-Id: I92a353d0f45056fffbc016c44a1ae05a63d76849 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8527 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Autosubmit: sterni <sternenseemann@systemli.org>
2023-04-09 r/6087 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/gerrit{,_plugins}: adjust for API change to buildBazelPackage https://github.com/NixOS/nixpkgs/commit/440b4de588d950e7fcf7add3b049fb209f097367 * //3p/gerrit_plugins: update hash of deps jar Change-Id: I131d5846acbce718126fb47671893a568d1020dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/8445 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2023-04-07 r/6072 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* Satisfy new assert that the corresponding shell needs to be enabled via programs.* if it is as the login shell of at least one user. * //users/tazjin: “Address” removal of hardware.video.hidpi option. * //3p/gerrit: update fetch sha256 Change-Id: Id0988a0ea7f393d6b7848a7104fc3526ee1177f4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8407 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2023-03-02 r/5866 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/sources: temporarily switch to nixos-unstable-small, since it includes: - evans update we are interested in, allowing us to drop our evans patches. - awscli2 update that unbreaks //users/grfn * //3p/overlays/tvl: - drop evans patches - update tdlib to 1.8.11 to make tazjin's emacs happy - drop obsolete mullvad workaround * //users/grfn/keyboard: disable -Werror for array-bounds warnings. Seems like a non-trivial job to resolve the warning properly, hopefully GCC 12 still generates the same working code as GCC 11 used to. * //users/grfn/system/home: remove yubikey-manager-qt. Yubico can't seem to keep that on pace with yubikey-manager. It requires a <5 version of the latter which is incompatible with the recently released cryptography >= 39. * //3p/gerrit: update changed FOD hash for the fetch step Change-Id: I590ab996247e69b0ab5059cd173840ef4ebfe939 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8133 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi>
2023-01-20 r/5713 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/overlays/haskell: clean up stale override * //3p/overlays/tvl: work around mullvad build failure * //3p/gerrit: update dependencies' output hash Change-Id: Iaea849fb199bb3d059e067c237ca939b3558a766 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7867 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
2023-01-12 r/5651 refactor(3p/gerrit): use Python 3 for buildingsterni1-6/+1
Change-Id: I7d5587efa02052e2a38588d1f2c9e94b6a6c6372 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7811 Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su>
2023-01-12 r/5650 chore(3p/sources): Bump channels & overlayssterni1-1/+6
* //3p/gerrit: prevent python2 from crashing evaluating due to upstream now officially considering it insecure after being EOL for 3 years. Overriding the meta set has the benefit that we do not need to whitelist the package globally, forcing us to opt in everywhere the dependency is acceptable. * //3p/overlays: bump tdlib so tazjin's emacs can build Change-Id: I50df82d35d56b0dd44b5f687e2dcb101db79738d Reviewed-on: https://cl.tvl.fyi/c/depot/+/7809 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-11-23 r/5307 chore(3p/sources): Bump channels & overlayssterni1-1/+1
* //3p/nixpkgs: allow insecure qtwebkit, since a package in grfn's home depends on it. Reasoning for marking qtwebkit as insecure is given here: https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/ * //3p/gerrit: update nondeterministic bazel output hash Change-Id: Ie652905969bf43abb457f6af211f771cff093dce Reviewed-on: https://cl.tvl.fyi/c/depot/+/7353 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-11-06 r/5257 chore(gerrit): bump to 3.7.0-rc4Luke Granger-Brown1-5/+14
Change-Id: Ib6f4fd5817fb5415cff5ea1d8c75c8c9a08d56b4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7185 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-09-11 r/4817 chore(3p): gerrit: 3.4.0 -> 3.6.1Luke Granger-Brown1-19/+16
This change cannot be deployed OOTB: you must upgrade by 3.5.2+ first, and run copy-approvals. Change-Id: Ia2e49da4d801a21a3db59e2d5b054eeb46d7dc79 Reviewed-on: https://cl.tvl.fyi/c/depot/+/6505 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2021-12-15 r/3252 chore(3p): bump NixOS channels to 2021-12-15sterni1-1/+1
* Switch from (unused) NixOS 21.05 to newly released NixOS 21.11 channel. * grfn/machines/yeren: Linux 5.14.x -> 5.15.x * 3p/gerrit, 3p/gerrit_plugin/oauth: update dependency bundle output hashes to what whitby comes up with now. Change-Id: Id3bfe3d07b9223f77ec628954783a6b0a48f4086 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4310 Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2021-08-31 r/2802 chore(3p/gerrit): Remove avatar padding patchVincent Ambo1-1/+0
In the current config, Gerrit doesn't actually seem to realise that avatars are not enabled (this changed in 3.4 somehow). Either way we don't need to maintain this fix since there's an actual upstream one now: https://gerrit-review.googlesource.com/313982 Change-Id: I7efab7b8fa5e9e38bddae86acd8d8a7852b27bb6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3465 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-08-28 r/2798 feat(3p/gerrit): Upgrade Gerrit and plugins to v3.4.0Vincent Ambo1-6/+6
Brings us back to a stable version of Gerrit instead of a random commit. Note that Gerrit 3.4.1 is out, but due to a bug it can not be built publicly because it accidentally points at a private submodule (this is being fixed upstream). Change-Id: I0376c63a649498cef999dfa99bfccba511f2c8da Reviewed-on: https://cl.tvl.fyi/c/depot/+/3444 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-08-24 r/2766 fix(3p/gerrit): Fix hash mismatch in dependency blobVincent Ambo1-1/+1
Change-Id: I8c3392e6b524b3868013df91fe5a7d3094ee757c Reviewed-on: https://cl.tvl.fyi/c/depot/+/3409 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2021-04-06 r/2451 feat(3p/gerrit): expose the Gerrit API in the outputLuke Granger-Brown1-3/+8
Writing Gerrit plugins that don't use the in-tree build system is more convenient if the API is actually exposed in the derivation's output. Change-Id: I3408d35498ca879576d532b005e36fde8ff2ea61 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2871 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-06 r/2450 chore(3p/gerrit): update gerrit and pluginsLuke Granger-Brown1-4/+6
This reverts commit 9551b628d02323b01ecb80220342eea488f7200e (i.e. this is a rollfoward for https://cl.tvl.fyi/c/depot/+/2817) Change-Id: Iaffcf1cdbe119d26ecb09cc88f9a56436b374c08 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2870 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-04-04 r/2424 revert(3p/gerrit): chore(3p/gerrit): update gerrit and pluginslukegb1-3/+3
This reverts commit f59c6214c4b1812120bd500a23d1cb6e160d6665. Reason for revert: new gerrit's JS appears to not have compiled correctly; rolling back until I can figure out why Change-Id: If16fe341aad25bef30ed7be8c6ac49cadf2a732c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2821 Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2021-04-04 r/2423 chore(3p/gerrit): update gerrit and pluginsLuke Granger-Brown1-3/+3
Yeet. Change-Id: I4de6453419f520a44af19d561a36d242195a64e9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2817 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-03-21 r/2303 chore(3p/gerrit): Update pinned dependency hashVincent Ambo1-1/+1
Change-Id: I1807ac1771d23b00e3a78cc36fb2f82a12900993 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2629 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2020-12-20 r/2017 fix(3p/gerrit): fix left padding on account chipLuke Granger-Brown1-0/+1
We don't have an avatar provider at the moment, so it's wonky. I'll make this a CL upstream as well once my work laptop has charged. Change-Id: I79754560b2de6981508ba7e10faf6b50cb9c3f8f Reviewed-on: https://cl.tvl.fyi/c/depot/+/2266 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-12-20 r/2016 chore(3p/gerrit): bump to latest version deployed on gerrit-reviewLuke Granger-Brown1-3/+3
Change-Id: I0aee39b21346f378964bab69bd903e8f43b7e7e8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2265 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-29 r/1957 chore(3p/gerrit): update to latest upstream HEADLuke Granger-Brown1-22/+8
Change-Id: Ia7b17ca83ace164881a4dd8b0288741489bc467c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2164 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-02 r/1536 chore(gerrit): Update to latest HEAD.Luke Granger-Brown1-5/+4
Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6786 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1516 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-01 r/1522 fix(gerrit): Don't do a deep fetchLuke Granger-Brown1-4/+2
I don't know what I was smoking. Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6781 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1514 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-27 r/1488 chore(3p/gerrit_plugins): add machinery for compiling Gerrit plugins from sourceLuke Granger-Brown1-3/+3
This looks particularly obnoxious for the owners plugin, because it's actually two plugins with a common library in the same repo. Other plugins are much cleaner to deal with (hence the default for overlayPluginCmd). Change-Id: Ibb9588c8a29b63e8509436fcbb70054e89349712 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1461 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-26 r/1479 fix(gerrit): fix hovercards under FirefoxLuke Granger-Brown1-0/+1
Firefox doesn't implement the IE6 fromElement/toElement, and it's not in the MouseEvent spec (at the moment). Replace with the worse-named but better-specified target and relatedTarget attributes instead. Upstream change: https://gerrit-review.googlesource.com/q/I9eeb26c032a38de9d7185749373c7982c796acb2 Change-Id: I9f9a1eb9342bc80b91b5b364a04cc5fa9a7ccaeb Reviewed-on: https://cl.tvl.fyi/c/depot/+/1442 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-25 r/1474 chore(gerrit): update to 3.2.2-1002-gea26b5ee7aLuke Granger-Brown1-6/+8
This is the version currently (2020-07-25) deployed on https://gerrit-review.googlesource.com/, and includes features such as The Attention Set. Change-Id: Idf29f96c38d7737efb0d64c4cd294dab46fe5412 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1437 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-11 r/1252 fix(gerrit): Load fonts from Google Fonts instead.Luke Granger-Brown1-0/+2
This also incidentally includes a fix for _not_ loading fonts from Google Fonts, but I don't really care about that. Change-Id: I6e00791d0ba06cb1e3c029e1b8617c33000d2ab1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1041 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-10 r/1247 chore(gerrit): update to 3.2.2Luke Granger-Brown1-2/+2
Change-Id: Ia41e19250f9f900c73904553a931f0f4dde3a5bf Reviewed-on: https://cl.tvl.fyi/c/depot/+/860 Tested-by: BuildkiteCI Reviewed-by: Kane York <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: isomer <isomer@tvl.fyi>
2020-07-03 r/1199 fix(gerrit): return HTML titles in more casesLuke Granger-Brown1-4/+4
At present, we don't return HTML titles if there's a trailing slash, or a patchset. Instead, just consume the / and anything after it. This also fixes /123, because this is HTTP redirected to the full path *with a trailing slash* which otherwise wouldn't get the title injected. Change-Id: Idfd0e67752880a37dce0b400a3c1cfc53fac2912 Reviewed-on: https://cl.tvl.fyi/c/depot/+/859 Reviewed-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-06-14 r/956 feat(gerrit): Add CL titles to title tags if accessing a CL or patchset.Luke Granger-Brown1-0/+1
Fine, puck, you win. Change-Id: I47fe8ea6662132f5c337e1e73281dbeca19a414c Reviewed-on: https://cl.tvl.fyi/c/depot/+/321 Reviewed-by: tazjin <mail@tazj.in>
2020-06-14 r/955 fix(3p/gerrit): Fix Gerrit derivation name and module configurationVincent Ambo1-1/+1
Without these changes, the NixOS module isn't able to use the new Gerrit derivation. These changes are already deployed as I needed to make them to get Gerrit back up. Change-Id: Iad3aa6158789a014134fddccd40b508b81486100 Reviewed-on: https://cl.tvl.fyi/c/depot/+/301 Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-06-14 r/952 feat(gerrit): Syntax highlight rules.pl as Prolog.Luke Granger-Brown1-0/+1
This adds support for overriding the detected languages based on the filename - we assume here that rules.pl will always map to a Prolog file. I could've overridden the entire default language to Prolog, since it's unlikely that we'll have any Perl here, but given the relative popularity of the two languages I opted to just override the file we know we'll have (because it's used by Gerrit itself). https://usercontent.irccloud-cdn.com/file/yhZZx1nd/highlighted_prolog.png Change-Id: I26a7e6dab191e0b80a027b026f884020a1f07178 Reviewed-on: https://cl.tvl.fyi/c/depot/+/254 Reviewed-by: tazjin <mail@tazj.in>
2020-06-14 r/951 feat(gerrit): Syntax highlight .nix files.Luke Granger-Brown1-1/+4
highlight.js supports syntax highlighting .nix files, but the Gerrit diff components doesn't map the .nix mimetype onto the nix language. .nix appears to already be taken by another mimetype that isn't Nix-related, but we just map that onto nix anyway. https://usercontent.irccloud-cdn.com/file/AVhoPvrb/highlighted.png Change-Id: I842b29c78355e5bec580e711e25d693284ab6f59 Reviewed-on: https://cl.tvl.fyi/c/depot/+/253 Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: q3k <q3k@q3k.org>
2020-06-14 r/948 feat(gerrit): Create Gerrit derivation.Luke Granger-Brown1-0/+150
This uses the actual Bazel build, using a variety of tricks and hacks to make it actually work. Bazel really wants to download linux binaries from the internet and run them. In lieu of trying to fix the build system to not do this, we instead put bazel inside an FHS environment, which allows the binaries to find their dependencies. We also have to patch a few things: * We use build --nobuild instead of fetch, so we only fetch the dependencies we actually need for the build and not, say, Windows binaries. * We don't remove rules_cc, because we need it as an external dependency, not bundled. * We do some manual fixes on the cache before packing, because we need to remove some in-tree sources (so they don't cause the hash to break, since the hashes differ each time they're generated), and also remove some extraneous files. * We explicitly turn off the repository and disk caches, because the .bazelrc at the root of the Gerrit tree turns them on, with paths pointing into the user's home directory. * detzip is used instead of the zip binary for packing bower_components into an archive. detzip doesn't create entries for directories, and also doesn't store most metadata (timestamps, etc.), and uses store (i.e. uncompressed) compression only. It also sorts the file tree before writing them into the file. Change-Id: I572c43f7175067ecb1b85cdf40dda13a52de1439 Reviewed-on: https://cl.tvl.fyi/c/depot/+/252 Reviewed-by: tazjin <mail@tazj.in>