depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2020-11-21	r/1887 chore(tazjin/emacs): Minor cleanup of unused modes and config	Vincent Ambo	4	-6/+0
	Change-Id: I38c6a32339bf7606b733a938b4e55df2506a13a7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2107 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-19	r/1886 fix(tvix): Use copy constructor to add strings to protos	Griffin Smith	2	-1/+29
	Passing a string directly to add_paths like this causes the proto class to take ownership over the string, meaning when it is destructed it will explicitly free the string. When the string's actual owner (the derivation struct) then goes out of scope it'll get freed again, causing a double-free. This fixes that to instead use the copy constructor to assign to a pointer to a new path, and covers the whole to_proto method with a rapidcheck test. Fixes: b/64 Change-Id: I84235bed9104ff430a0acf686d4a96f1e2e9a897 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2106 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-19	r/1885 fix(tvix): Use mutable field for assigning proto fields	Griffin Smith	1	-2/+2
	This was accidentally using the proto arena API to assign the derivation field of a BuildDerivationRequest. We thought this was causing a double free, but even with this change that's still happening. That said, this change is probably still a good idea since it's using the proto API as intended. References: b/64 Change-Id: I950a4eafb214e9113639ea54d2dfd4659b7be931 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2104